Re: [cp-patches] RFC: @file support for gjavah & gjar

2008-06-04 Thread Mario Torre
Il giorno mer, 04/06/2008 alle 09.08 -0600, Tom Tromey ha scritto: > Some of the indentation seems wrong to me, though I always find it a > bit hard to tell due to diffs making tabs look weird. I don't know if I say a popular thing or not, but please, expand your tabs into spaces, it makes the wh

Re: [cp-patches] RFC: @file support for gjavah & gjar

2008-06-04 Thread Tom Tromey
> "Robert" == Robert Schuster <[EMAIL PROTECTED]> writes: Robert> The other tools are not affected by this change nor does this modify the Robert> core getopt functionality (except that I made the 'programName' field Robert> protected - was private). I don't think we need this to be protected

Re: [cp-patches] RFC: move from gnu.java.security.action.GetPropertyAction to sun.security.action.GetPropertyAction

2008-06-04 Thread Mark Wielaard
Hi Robert, On Wed, 2008-06-04 at 10:33 +0100, Andrew John Hughes wrote: > Can we also document each sun.* specific change somewhere? I still > regard these as bugs, but not against either > GNU Classpath or OpenJDK -- against the specification itself. If code > is being relied upon by both class

Re: [cp-patches] RFC: move from gnu.java.security.action.GetPropertyAction to sun.security.action.GetPropertyAction

2008-06-04 Thread Andrew John Hughes
2008/6/4 Robert Schuster <[EMAIL PROTECTED]>: > Hi, > the attached patch refactors all of Classpath' code to use > sun.security.action.GetPropertyAction instead of > gnu.java.security.action.GetPropertyAction. > > Additionally the class in question is moved to its new package. > > While I don't lik

Re: [cp-patches] RFC: add a copy of gnu/java/security/action/GetPropertyAction into sun/security/action

2008-06-04 Thread Andrew Haley
Robert Schuster wrote: > Hi. > > Andrew Haley schrieb: >>> What is the public equivalent for GetPropertyAction? >> There isn't any need, is there? > That depends. :) > >> It's just a wrapper for >> (String) AccessController.doPrivileged(new PrivilegedAction() { >> public jav

Re: [cp-patches] RFC: add a copy of gnu/java/security/action/GetPropertyAction into sun/security/action

2008-06-04 Thread Robert Schuster
Hi. Andrew Haley schrieb: >> What is the public equivalent for GetPropertyAction? > > There isn't any need, is there? That depends. :) > It's just a wrapper for > (String) AccessController.doPrivileged(new PrivilegedAction() { > public java.lang.Object run() { >

[cp-patches] RFC: move from gnu.java.security.action.GetPropertyAction to sun.security.action.GetPropertyAction

2008-06-04 Thread Robert Schuster
Hi, the attached patch refactors all of Classpath' code to use sun.security.action.GetPropertyAction instead of gnu.java.security.action.GetPropertyAction. Additionally the class in question is moved to its new package. While I don't like the usage of a non-standard API as much as you I also thin

Re: [cp-patches] RFC: add a copy of gnu/java/security/action/GetPropertyAction into sun/security/action

2008-06-04 Thread Andrew Haley
Robert Schuster wrote: > Hi, > > Andrew John Hughes schrieb: >>> 2008-06-03 Robert Schuster <[EMAIL PROTECTED]> >>> >>> * sun/security/action/GetPropertyAction.java: Functional copy >>> of gnu/java/security/action/GetPropertyAction.java. >>> >>> Regards >>> Robert >>> >> >> Er... fix the binar

Re: [cp-patches] RFC: add a copy of gnu/java/security/action/GetPropertyAction into sun/security/action

2008-06-04 Thread Robert Schuster
Hi, Andrew John Hughes schrieb: >> 2008-06-03 Robert Schuster <[EMAIL PROTECTED]> >> >> * sun/security/action/GetPropertyAction.java: Functional copy >> of gnu/java/security/action/GetPropertyAction.java. >> >> Regards >> Robert >> > > > Er... fix the binary which is clearly broken by relyin