Re: [cp-patches] What's about bug 36560 (Error parsing zip file...)?

2010-07-13 Thread Jeroen Frijters
Hello, I've committed the patch below and closed the bug. Regards, Jeroen Index: InflaterHuffmanTree.java === RCS file: /cvsroot/classpath/classpath/java/util/zip/InflaterHuffmanTree.java,v retrieving revision 1.7 diff -u -r1.7

[cp-patches] ZipFile handling of encrypted entries

2010-07-13 Thread Jeroen Frijters
Hello, I've committed the patch below. When a zip file contains an encrypted entry, we should throw a ZipException (as the JDK does) while reading the zip file directory. This has been in IKVM.NET's ZipFile implementation (which is a fork of GNU Classpath's) for a while. Regards, Jeroen

Re: [cp-patches] What's about bug 36560 (Error parsing zip file...)?

2010-07-13 Thread Andrew John Hughes
On 13 July 2010 13:53, Jeroen Frijters jer...@sumatra.nl wrote: Hello, I've committed the patch below and closed the bug. Thanks. I couldn't include the whole of Daniel's patch as he hasn't signed a copyright assignment. Regards, Jeroen Index: InflaterHuffmanTree.java

Re: [cp-patches] What's about bug 36560 (Error parsing zip file...)?

2010-07-13 Thread Ivan Maidanski
Hello, Andrew and Jeroen! The patched applied to InflaterHuffmanTree.java is ok. But the patch for ZipFile isn't - you just reject any zip file that contains a single encrypted file. Mine (or Daniel's) solution is to fail only when trying to read from an encrypted zip entry. See