Re: [cp-patches] [PATCH v2] Fix VMClass#getSimpleName() implementation

2010-12-13 Thread Dr Andrew John Hughes
On 22:52 Wed 08 Dec , Pekka Enberg wrote: > This patch replaces VMClass#getSimpleName() implementation with JamVM's > version > that supposedly comes from GCJ. This fixes a compatibility problem found by > Malva. > > Signed-off-by: Pekka Enberg > --- > vm/reference/java/lang/VMClass.java |

Re: [cp-patches] [PATCH] Fix java.lang.Class field and method API for null names

2010-12-13 Thread Pekka Enberg
On Mon, Dec 13, 2010 at 2:53 PM, Dr Andrew John Hughes wrote: >> OK, I'm sorry I'm having some difficulties adjusting to GNU style of >> working. I'll update the patch and resend. > > Please just post a ChangeLog in the mail.  Don't include it in the patch > as it makes it hard to apply. 2010-12-

Re: [cp-patches] [PATCH] Fix java.lang.Class field and method API for null names

2010-12-13 Thread Dr Andrew John Hughes
On 14:41 Mon 13 Dec , Pekka Enberg wrote: > On Mon, Dec 13, 2010 at 12:08 PM, Andrew Haley wrote: > > On 12/12/2010 11:46 AM, Pekka Enberg wrote: > >> This patch fixes Class getDeclaredField, getDeclaredMethod, getField, and > >> getMethod API to throw NullPointerException if given name is "nu

Re: [cp-patches] [PATCH] Fix java.lang.Class field and method API for null names

2010-12-13 Thread Pekka Enberg
On Mon, Dec 13, 2010 at 12:08 PM, Andrew Haley wrote: > On 12/12/2010 11:46 AM, Pekka Enberg wrote: >> This patch fixes Class getDeclaredField, getDeclaredMethod, getField, and >> getMethod API to throw NullPointerException if given name is "null". > > Thanks, but two things: > > a.  What happens

Re: [cp-patches] [PATCH] Fix java.lang.Class field and method API for null names

2010-12-13 Thread Andrew Haley
On 12/12/2010 11:46 AM, Pekka Enberg wrote: > This patch fixes Class getDeclaredField, getDeclaredMethod, getField, and > getMethod API to throw NullPointerException if given name is "null". Thanks, but two things: a. What happens with the current code base? b. We need a change log entry. Andr