Please comment on the idea and/or the API.
Dumb question.. why wouldn't it work to just use a WeakHashMap instead
of a HashMap in all those places?
-Archie
______
Archie Cobbs *CTO, Awarix* http://www.awarix.com
Carsten Neumann wrote:
Here is an updated version.
+ * Returns the cube root of x. The sign of the cube root
+ * is equal to the sign of the sign of x.
You've got an extra "the sign of" in there..
-Archie
__
lit("=", 1)" instead? E.g. what if I have
a variable like "FOO=2+2=4".
Actually, even that is not right. E.g., consider "FOO==BAR". The
value is "=BAR" not empty string.
Instead, I think using pair.indexOf('=') is required here...
-Archie
_
rchie
__
Archie Cobbs *CTO, Awarix* http://www.awarix.com
Mark Wielaard wrote:
Hi Archie,
On Tue, 2006-05-23 at 04:57 -0500, Archie Cobbs wrote:
After upgradeing JCVM to 0.91, I'm seeing an exception due to broken
static initializer ordering in java.lang.VMClassLoader. The "bootjars"
static field is initialized on line 173, but this i
#x27;t seem VM-specific but maybe I'm missing something.
Thanks,
-Archie
______
Archie Cobbs *CTO, Awarix* http://www.awarix.com
Index: ChangeLog
at is gained by deferring initialization?
Curiously,
-Archie
__
Archie Cobbs *CTO, Awarix* http://www.awarix.com
nough to change the class initialization
order, which to me seems even more surprising (but possible I guess.. ?)
-Archie
______
Archie Cobbs *CTO, Awarix* http://www.awarix.com
NEWS entry for VM implementors that notifies
them they should set the "securerandom.seed" system property at VM
startup, right? If so please add one to your patch.
Thanks,
-Archie
__________
Archie Cobbs
ionHandler getUncaughtExceptionHandler()
+ {
+return exceptionHandler;
+ }
The Javadoc and the implementation here don't seem consistent: how
could this ever return the thread's ThreadGroup (option #2)?
-Archie
__________
Archie Cobbs
dicates such as isSynthetic.
Looks good to me... accompianied by a NEWS entry of course.
Thanks,
-Archie
______
Archie Cobbs *CTO, Awarix* http://www.awarix.com
to me.
-Archie
______
Archie Cobbs *CTO, Awarix* http://www.awarix.com
dge in there somewhere :-)
-Archie
______
Archie Cobbs *CTO, Awarix* http://www.awarix.com
case, wouldn't easymock fail
to catch a valid equals() invocation?
-Archie
______
Archie Cobbs *CTO, Awarix* http://www.awarix.com
__
Archie Cobbs *CTO, Awarix* http://www.awarix.com
m.loadLibrary() from
within System or Runtime static initializers? Does this cause an
infinite loop? If so what's the loop?
-Archie
______
Archie Cobbs *CTO, Awarix* http://www.awarix.com
.
-Archie
______
Archie Cobbs *CTO, Awarix* http://www.awarix.com
I don't feel free
to ignore me :-)
-Archie
______
Archie Cobbs *CTO, Awarix* http://www.awarix.com
tive thing
while the correct and optimized thing is being worked on. What we have
now is incorrect and optimized :-)
-Archie
__________
Archie Cobbs *CTO, Awarix* h
s whatever exception you want. Then invoke
Class.newInstance() on the class.
-Archie
______
Archie Cobbs *CTO, Awarix* http://www.awarix.com
___
Classpa
there.
-Archie
______
Archie Cobbs *CTO, Awarix* http://www.awarix.com
___
Classpath-patches mailing list
Classpath-patches@gnu.org
http://lists.gnu.org/mailman/listinfo/classpath-patches
ld goose chase of similar changes which may or may not
actually improve anything.
-Archie
__
Archie Cobbs *CTO, Awarix* http://www.awarix.com
___
Classpath-patches mailing list
Classpath-patches@gnu.org
http://lists.gnu.org/mailman/listinfo/classpath-patches
Apologies for the minor IMHO rant.. :-)
-Archie
______
Archie Cobbs *CTO, Awarix* http://www.awarix.com
___
Classpath-patches mailing list
Classpath-patches@gnu.org
http://lists.gnu.org/mailman/listinfo/classpath-patches
h (or wherever),
but don't have a crt_externs.h. Not a big deal (the build should
still work) but it will cause a GCC warning with -Wredundant-decls.
-Archie
______
Archie Cobbs *CTO, Awarix*
ON], [1],
[environ explicitly declared somewhere])])
-Archie
______
Archie Cobbs *CTO, Awarix* http://www.awarix.com
___
Classpath-patches mailing list
Classpath-patches@gnu.org
http://lists.gnu.org/mailman/listinfo/classpath-patches
I've committed the attached patch to fix an infinite loop
between VMStackWalker.getCallingClassLoader() and Class.getClassLoader().
2005-11-13 Archie Cobbs <[EMAIL PROTECTED]>
* vm/reference/gnu/classpath/VMStackWalker.java (getClassLoader()):
added to fix an in
I've checked in this fix for autogen.sh on FreeBSD.
2005-11-11 Archie Cobbs <[EMAIL PROTECTED]>
* autogen.sh: Fix broken libtool version detection on FreeBSD.
-Archie
______
Archie Cobbs *
David Daney wrote:
Archie Cobbs wrote:
Mark Wielaard wrote:
While messing around with FindBugs, I came up with the following useful
patch. It converts all "new Boolean(X)" instances to
"Boolean.valueOf(X)". Ok?
[...]
- return new Boolean(true);
+ return Boolean
ultimate effect should be the same.
-Archie
______
Archie Cobbs *CTO, Awarix* http://www.awarix.com
___
Classpath-patches mailing list
Classpath-patches@gnu
llowed by the JNI spec?
Yes.. patch looks OK to me too.
-Archie
__
Archie Cobbs *CTO, Awarix* http://www.awarix.com
___
Classpath-patches mailin
g loader or not, only the
VM knows this.
Tiny clarification.. that should be "an initiating loader" rather
than "the initiating loader"... there can be more than one for
a given class, right?
-Archie
______
Arc
lement
a lot of other native methods too, and this one should be fairly easy.
-Archie
______
Archie Cobbs *CTO, Awarix* http://www.awarix.com
___
Classpath-
oved a bit.
Rob and Archie, is this (close to) what you both need?
Yes, that looks great to me :-)
My only comment is that findLoadedClass() needs some Javadoc.
-Archie
______
Archie Cobbs *CTO, Awarix*
t what
the VM should be doing (e.g., it's not immediately obvious when a type
should be added to the initiated types tree, or even that a VM is
required to maintain one).
-Archie
______
Archie Cobbs *CTO,
best answer is.
-Archie
______
Archie Cobbs *CTO, Awarix* http://www.awarix.com
___
Classpath-patches mailing list
Classpath-patches@gnu.org
http://lists.gnu.org/mailman/listinfo/classpath-patches
cking. This patch eliminates
the assertion failures in native_state.c. I committed it to mainline.
Thank you! :-)
-Archie
__
Archie Cobbs *CTO, Awarix* http://www.awari
ent why being used) would be better.
-Archie
______
Archie Cobbs *CTO, Awarix* http://www.awarix.com
___
Classpath-patches mailing list
Classpath-patches@gnu.org
ht
es that it caches this list internally for all ClassLoaders, then
it has every right to make such a claim... ?
-Archie
______
Archie Cobbs *CTO, Awarix* http://www.
can.
-Archie
______
Archie Cobbs *CTO, Awarix* http://www.awarix.com
___
Classpath-patches mailing list
Classpath-patches@gnu.org
http://lists.gnu.org/mailman/listinfo/classpath-patches
not necessary.
With array clone(), also typically a native method, none of that
checking is ever needed.
This is a good example of the advandages of a JVM written in Java
(a coincidence? :-) There is no "optimization barrier" into "native"
code like System.arraycopy().
-
/share/jc/doc/jc.html#Classes%20and%20Types
Cheers,
-Archie
__________
Archie Cobbs *CTO, Awarix* http://www.awarix.com
___
Classpath-patches mailing list
Classpath-patches@gnu.org
http://lists.gnu.org/mailman/listinfo/classpath-patches
them after the associated class has been unloaded... ?
In any case, how is a class ever going to be unloaded if your
Hashtable is referencing it? :-)
-Archie
______
Archie Cobbs *CTO, Awarix
kes for an interesting programming
exercise then.. :-)
-Archie
______
Archie Cobbs *CTO, Awarix* http://www.awarix.com
___
Classpath-patches mailing list
Classpa
own?
See java.lang.VMString.intern() for an example.
- Do you mean to use hashCode()/equals() or System.identityHashCode()/==?
-Archie
______
Archie Cobbs *CTO, Awarix* http://www.
27; >> ${top_builddir}/lib/classes.1
+ | sort | grep '\.java$' >> ${top_builddir}/lib/classes.1
fi
Tiny improvement: you'll save 'sort' some work if you grep | sort
instead of sort | grep..
-Archie
t?
-Archie
______
Archie Cobbs *CTO, Awarix* http://www.awarix.com
___
Classpath-patches mailing list
Classpath-patches@gnu.org
http://lists.gnu.org/mailman/listinfo/classpath-patches
like a pretty obscure case.
-Archie
______
Archie Cobbs *CTO, Awarix* http://www.awarix.com
___
Classpath-patches mailing list
Classpath-patches@gnu.org
http://lists.gnu.org/mailman/listinfo/classpath-patches
nough :-)
As long as soft references are used, the idea sounds OK to me.
-Archie
______
Archie Cobbs *CTO, Awarix* http://www.awarix.com
___
Classpath-patches maili
x27;t these mutable objects though?
-Archie
__
Archie Cobbs *CTO, Awarix* http://www.awarix.com
___
Classpath-patches mailing list
Classpath-patches@gnu.org
merge your stuff over.
-Archie
______
Archie Cobbs *CTO, Awarix* http://www.awarix.com
___
Classpath-patches mailing list
Classpath-patches@gnu.org
http://lists.gnu.org/mailman/listinfo/classpath-patches
t it in the
Classpath reference implementation.
That sounds like a decent approach. Do you plan to commit that soon?
If not I can commit my patch as an interim solution.
-Achie
______
Archie Cobbs *CTO, Awarix
VMClassLoader.getResource() does not handle ZIP files on the boot loader
class path. The attached patch fixes this.
2005-03-17 Archie Cobbs <[EMAIL PROTECTED]>
* vm/reference/java/lang/VMClassLoader.java: handle ZIP files
on the boot loader class path in getResources(
Archie Cobbs wrote:
In gnu_java_awt_peer_gtk_GdkPixbufDecoder.c, in the function
query_formats(), there is a loop where (*env)->NewStringUTF()
is invoked over and over again. There are two bugs actually:
1- The function exhausts the pool of local native references.
It should use DeleteLocal
Archie Cobbs wrote:
Another common problem is using too many local native references, e.g.,
when creating and populating an array. You only get 16, and have to use
DeleteLocalRef() to free up the ones you don't need anymore.
Well, soon as I sent that I ran into exactly this problem. Don&#
for maintaining a reference to
the associated class, to avoid it from being unloaded, while using jfieldID
and jmethodID variables:
http://java.sun.com/j2se/1.4.2/docs/guide/jni/spec/design.html#wp17074
______
Archie Cobbs
a global native reference around "classRawData".
This fixes the problem for me. I'll commit the attached patch unless
there are issues.
2005-03-15 Archie Cobbs <[EMAIL PROTECTED]>
* native/jni/java-nio/java_nio_VMDirectByteBuffer.c: use
global native referen
I've checked in the attached patch which fixes a core dump (in the
child process) when a zero length command array is passed.
2005-03-11 Archie Cobbs <[EMAIL PROTECTED]>
* native/jni/java-lang/java_lang_VMProcess.c: Fix segfault
in the case that a zero length comma
ale setting.
You need to set your LC_ALL to "C" instead of "en" to get the
traditional sorting, if you're using a tool like sort(1) to do the sort.
-Archie
______
Archie Cobbs *CTO, Awarix
).
-Archie
______
Archie Cobbs *CTO, Awarix* http://www.awarix.com
___
Classpath-patches mailing list
Classpath-patches@gnu.org
http://lists.gnu.org/mailman/listinfo
;)");
return super.initCause(cause);
}
public static void main(String[] args) {
temp t = new temp("test", new Exception());
}
}
-Archie
______
Archie Cobbs *CTO, Awarix
lined at every instantiation site, bloating code size.
Note that initCause() is not final, so a subclass could override it;
however the constructor does not specify that it calls initCause() to
initialize the cause so this doesn't change any specified behavior.
2005-02-19 Archie Cobbs <[EM
61 matches
Mail list logo
