[cp-patches] [generics] Copied org/omg/PortableServer/portable/Delegate.java

2005-09-22 Thread Jeroen Frijters
Hi, org/omg/PortableServer/portable/Delegate.java was missing on the generics branch, so I copied it over. Regards, Jeroen ___ Classpath-patches mailing list Classpath-patches@gnu.org http://lists.gnu.org/mailman/listinfo/classpath-patches

RE: [cp-patches] Patch: FYI: BorderLayout -vs- 1.5

2005-09-22 Thread Jeroen Frijters
Tom Tromey wrote: > (vgap, hgap, north, south, east, west): Reordered > fields to conform to serialization spec. Field order is not significant for serialization (even in the absence of a serialVersionUID field). Regards, Jeroen ___ Classpath-p

[cp-patches] FYI: Fix to javax/security/auth/login/Configuration.java

2005-09-09 Thread Jeroen Frijters
Hi, I committed the attached patch to fix a NPE in LoginContext (it calls the package private getConfig() method, but if the config field hadn't previously been initialized that would return null). Regards, Jeroen 2005-09-09 Jeroen Frijters <[EMAIL PROTECTED]> * javax/se

[cp-patches] FYI: Moved System.loadLibrary() calls from ObjectInputStream/ObjectOutputStream to VM classes

2005-09-09 Thread Jeroen Frijters
Hi, I committed the attached patch to move the System.loadLibrary calls to the VM classes. Regards, Jeroen 2005-09-09 Jeroen Frijters <[EMAIL PROTECTED]> * java/io/ObjectInputStream.java: Removed static initializer. * java/io/ObjectOutputStream.java: Removed

[cp-patches] FYI: Small Proxy fix

2005-09-09 Thread Jeroen Frijters
Hi, I committed the attached patch to fix the class name of proxies that implement only public interfaces (the name was "null$Proxy0", but it should be "$Proxy0"). Regards, Jeroen 2005-09-09 Jeroen Frijters <[EMAIL PROTECTED]> * java/lang/reflect/Proxy.java

[cp-patches] FYI: Proxy serialization fixes

2005-09-08 Thread Jeroen Frijters
l now, but it's a first step. Regards, Jeroen 2005-09-08 Jeroen Frijters <[EMAIL PROTECTED]> * java/io/ObjectInputStream.java (readObject): Removed println and fixed Proxy class descriptor deserialization. (resolveProxyClass): Use Class.forName

[cp-patches] RE: FYI: Serialization implementation for javax/naming/CompoundName.java

2005-09-08 Thread Jeroen Frijters
Again, with the patch this time. > -Original Message- > From: Jeroen Frijters > Sent: Thursday, September 08, 2005 10:33 > To: Classpath-Patches > Subject: FYI: Serialization implementation for > javax/naming/CompoundName.java > > Hi, > > I impleme

[cp-patches] FYI: Serialization implementation for javax/naming/CompoundName.java

2005-09-08 Thread Jeroen Frijters
Hi, I implemented serialization support for javax.naming.CompoundName. Regards, Jeroen 2005-09-08 Jeroen Frijters <[EMAIL PROTECTED]> * javax/naming/CompoundName.java (readObject, writeObject): New methods. ___ Classpath-p

RE: [cp-patches] FYI: Made PixelGrabber more robust

2005-08-19 Thread Jeroen Frijters
Mark Wielaard wrote: > Sent: Thursday, August 18, 2005 22:57 > To: Roman Kennke > Cc: Classpath-Patches > Subject: Re: [cp-patches] FYI: Made PixelGrabber more robust > > Hi, > > On Thu, 2005-08-18 at 15:41 +0200, Roman Kennke wrote: > > public void run () > > { > > -

RE: [cp-patches] RFC: AWT painting broken?

2005-08-16 Thread Jeroen Frijters
Roman Kennke wrote: > Oh sorry, the diff has confused me. It is ok then. Please check it in. Thanks. I've checked it in. Regards, Jeroen 2005-08-16 Jeroen Frijters <[EMAIL PROTECTED]> * java/awt/Component.java (dispatchEventImpl): Always call pe

RE: [cp-patches] RFC: AWT painting broken?

2005-08-16 Thread Jeroen Frijters
Roman Kennke wrote: > No it does not. The method processEvent is only intended to give > applications with Component subclasses a chance to process the event. > The AWT itself should not do any logic in these methods. Please take another look at my patch. I did not alter the call to processEvent a

[cp-patches] RFC: AWT painting broken?

2005-08-16 Thread Jeroen Frijters
Hi, Maybe it's me (I'm always fighting with AWT whenever I work on it), but the recent batch of changes to AWT broke painting for me (using my own peers). I don't pretend to understand how this is supposed to work, so it could very well be something in my peers, but I think attached patch makes s

[cp-patches] FYI: java/awt/Container.java fix.

2005-08-16 Thread Jeroen Frijters
Hi, A small fix to Container. Regards, Jeroen 2005-08-16 Jeroen Frijters <[EMAIL PROTECTED]> * java/awt/Container.java (addImpl, remove): Only repaint if the container is showing. Index: java/awt/Containe

RE: [cp-patches] [generics] Patch: FYI: update Timer

2005-08-13 Thread Jeroen Frijters
Hi Tom, Why are you checking this into the generics branch? I was under the impression that 1.5 functionality could also be applied to the main branch, as long as it doesn't require any 1.5 language features. Regards, Jeroen > -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAI

[cp-patches] FYI: java/io/ObjectInputStream.java fix

2005-08-13 Thread Jeroen Frijters
Hi, I applied to attached patch to fix bug #23377. Regards, Jeroen 2005-08-13 Jeroen Frijters <[EMAIL PROTECTED]> * java/io/ObjectInputStream.java (readClassDescriptor): Don't cache caller's class loader. (resolveClass): Don't cache caller'

RE: [cp-patches] [RFC/JDWP] ClassLoaderReferenceCommandSet

2005-08-09 Thread Jeroen Frijters
Archie Cobbs wrote: > Jeroen Frijters wrote: > > I strongly agree with Archie. Also, approach #2 is > incorrect, because > > the classes that should be returned are the "classes for which this > > class loader has been recorded as the initiating loader". The cla

RE: [cp-patches] [RFC/JDWP] ClassLoaderReferenceCommandSet

2005-08-09 Thread Jeroen Frijters
Archie Cobbs wrote: > Aaron Luchko wrote: > > There's only a single command which asks for a list of > every class the > > ClassLoader has been requested to load. The first way to do > this is just > > use a hook in the vm. I don't know enough with how ClassLoaders are > > handled within the vm t

[cp-patches] FYI: Some 1.5 Exception constructors merged back from generics branch

2005-08-07 Thread Jeroen Frijters
Hi, I merged some new 1.5 exception constructors from the generics branch to HEAD. Regards, Jeroen 2005-08-06 Jeroen Frijters <[EMAIL PROTECTED]> * java/lang/IllegalArgumentException.java, java/lang/IllegalStateException.java, java/lang/SecurityExceptio

[cp-patches] FYI: java/io/ObjectInputStream.java clean up

2005-08-07 Thread Jeroen Frijters
-pattern "return from finally".) Regards, Jeroen 2005-08-06 Jeroen Frijters <[EMAIL PROTECTED]> * java/io/ObjectInputStream.java (readClassDescriptor): Removed bogus handling of primitive types. (readFields.GetField.defaulted): Pass ca

[cp-patches] FYI: ObjectInputStream bug fix (23236)

2005-08-05 Thread Jeroen Frijters
Hi, I've committed the attached patch to fix bug 23236. Regards, Jeroen 2005-08-05 Jeroen Frijters <[EMAIL PROTECTED]> * java/io/ObjectInputStream.java (read(byte[],int,int)): Simplified and fixed bug 23236. Index: java/io/ObjectInput

RE: [cp-patches] [generics] Enum#valueOf implementation

2005-08-03 Thread Jeroen Frijters
Andrew John Hughes wrote: > Currently, what appears to be a bug in ecj > (https://bugs.eclipse.org/bugs/show_bug.cgi?id=105531) is > preventing me from doing a full compile, but no other errors cropped > up from this patch. I've seen this ecj bug as well, but it never seems to happen if you do a

[cp-patches] FYI: ClassLoader security patch

2005-08-01 Thread Jeroen Frijters
Hi, I committed the attached patch to fix some potential security holes in ClassLoader. I also created a Mauve testcase (gnu/testlet/java/lang/ClassLoader/initialize.java) that tests for this. Regards, Jeroen 2005-08-01 Jeroen Frijters <[EMAIL PROTECTED]> * java/lang/ClassLoade

[cp-patches] FYI: Class & class loader VM interface simplification applied

2005-08-01 Thread Jeroen Frijters
Hi, As previously discussed, I've committed the attached patch to simplify the VM interface for Class and ClassLoader. Regards, Jeroen 2005-08-01 Jeroen Frijters <[EMAIL PROTECTED]> * NEWS: Added info about VM interfaces changes. * java/lang/Class.java (for

[cp-patches] RE: RFC: New class loader patch proposal

2005-07-29 Thread Jeroen Frijters
Robert Lougher wrote: > On 7/28/05, Jeroen Frijters <[EMAIL PROTECTED]> wrote: > > Hi, > > > > Here's an alternative patch that rips out most of the complexity and > > leaves everything to the VM. It took me about three minutes > to implement > > t

[cp-patches] RFC: New class loader patch proposal

2005-07-28 Thread Jeroen Frijters
Hi, Here's an alternative patch that rips out most of the complexity and leaves everything to the VM. It took me about three minutes to implement this new interface for IKVM, so I know I'm happy with it! The only thing missing that the documentation should be improved a bit. Rob and Archie, is t

RE: [cp-patches] Re: RFC: Class Loader patch to recordclasswithinitiating class loader

2005-07-28 Thread Jeroen Frijters
Robert Lougher wrote: > Flame away, I deleted everything I agree with. Since I'm partly to blame for the current mess in Class.forName(), I'll include a clean up of this in my next version of the patch. Regards, Jeroen ___ Classpath-patches mailing l

RE: [cp-patches] RFC: Class Loader patch to record class withinitiating class loader

2005-07-28 Thread Jeroen Frijters
David Gilbert wrote: > I hope when I mentioned that JamVM was broken, it didn't sound like a > complaint, because that wasn't what I intended. Not at all. I was just a bit surprised that it is possible to live on the bleeding edge of development and still maintain the notion: > how VMs work...as

RE: [cp-patches] RFC: Class Loader patch to record classwithinitiating class loader

2005-07-28 Thread Jeroen Frijters
Mark Wielaard wrote: > It looks like that is also what gcj and jamvm do already. > That is why I am surprised that we really need the double callbacks > everywhere. Does that make the interface really more flexible? > In the case of Class.forName() you mean that when we need to delegate > to Class

RE: [cp-patches] RFC: Class Loader patch to record class withinitiating class loader

2005-07-28 Thread Jeroen Frijters
Archie Cobbs wrote: > For what it's worth, JCVM maintains its own intiated types and > defined types tables internally, so this patch does not make life > better (or worse). I would have to disable this code. This raises the question, how many VMs are actually using the loadedClasses hashtable in

RE: [cp-patches] RFC: Class Loader patch to record class withinitiating class loader

2005-07-28 Thread Jeroen Frijters
Mark Wielaard wrote: > On Wed, 2005-07-27 at 13:18 +0200, Jeroen Frijters wrote: > > While digging around the class loading issues, I discovered that we > > didn't record a class with the "initiating loader" [1]. This is > > necessary to maintain type safe

[cp-patches] RFC: Class Loader patch to record class with initiating class loader

2005-07-27 Thread Jeroen Frijters
ass(java.lang.String) 2005-07-27 Jeroen Frijters <[EMAIL PROTECTED]> * java/lang/Class.java (forName(String), forName(String,boolean,ClassLoader)): Added call to VMClassLoader.registerInitiatingLoader. * java/lang/ClassLoader.java (defineC

RE: [cp-patches] RFC: RMI Class loader fix

2005-07-26 Thread Jeroen Frijters
Andrew Haley wrote: > All of this is fairly ill-specified. As usual :-( I just re-read the relevant part of the 1.5 API spec and JLS (which it refers to) and I think you can actually interpret it to prohibit loading array classes via ClassLoader.loadClass (indirectly based on the definition of "b

RE: [cp-patches] RFC: RMI Class loader fix

2005-07-26 Thread Jeroen Frijters
Andrew Haley wrote: > Tom Tromey writes: > > >>>>> "Jeroen" == Jeroen Frijters <[EMAIL PROTECTED]> writes: > > > > Jeroen>* java/rmi/server/RMIClassLoader.java > > Jeroen>(loadClass(String, String)): Us

[cp-patches] FYI: Proxy -> VMProxy patch

2005-07-26 Thread Jeroen Frijters
Hi, I moved to native methods in Proxy to VMProxy and moved the configuration flags that control whether the native methods are used from gnu.classpath.Configuration to VMProxy as well. Regards, Jeroen 2005-07-26 Jeroen Frijters <[EMAIL PROTECTED]> * NEWS: Added comment abo

RE: [cp-patches] FYI: Small additional ClassLoader VMextensibility point

2005-07-26 Thread Jeroen Frijters
Mark Wielaard wrote: > On Mon, 2005-07-25 at 11:43 +0200, Jeroen Frijters wrote: > > I committed the attached patch, that allows a VM implementer to hook > > Classloader.findLoadedClass. > > When adding new VM hooks could you please add a little note > to the NEWS file. T

RE: [cp-patches] FYI: ClassLoader caching Part 2

2005-07-26 Thread Jeroen Frijters
Mark Wielaard wrote: > On Mon, 2005-07-25 at 18:17 +0200, Jeroen Frijters wrote: > > Is this an important scenario? I thought you long haired > types didn't > > like binary distributions ;-) > > He he. Sure we don't. But if you follow the harmony effort of the

[cp-patches] FYI: RMI Class loader fix

2005-07-25 Thread Jeroen Frijters
Hi, I applied the attached fix. Regards, Jeroen * java/rmi/server/RMIClassLoader.java (loadClass(String, String)): Use Class.forName() instead of directly calling ClassLoader.loadClass(), to handle array types correctly. Index: java/rmi/server/RMIClassLoader.java

RE: [cp-patches] FYI: ClassLoader caching Part 2

2005-07-25 Thread Jeroen Frijters
Jeroen Frijters wrote: > Mark Wielaard wrote: > > On Mon, 2005-07-25 at 16:29 +0200, Jeroen Frijters wrote: > > > I committed the attached patch to complete to ability of the VM to > > > bypass the class caching in ClassLoader. > > > > > > 2

RE: [cp-patches] RFC: RMI Class loader fix

2005-07-25 Thread Jeroen Frijters
Mark Wielaard wrote: > On Mon, 2005-07-25 at 14:52 +0200, Jeroen Frijters wrote: > > I'm not an RMI person, but an IKVM user ran into an RMI > problem that I > > think is caused by a problem in the RMI class loader that > the attached > > patch should fix. > &

RE: [cp-patches] FYI: ClassLoader caching Part 2

2005-07-25 Thread Jeroen Frijters
Mark Wielaard wrote: > Yes, but unfortunately that doesn't change the byte-code of the > ClassLoader class. static final primitive (and String) field > values are actually inlined into other classes. So you can replace > VMClassLoader all you want with a version the has VM_USE_CACHE set > to anoth

RE: [cp-patches] FYI: ClassLoader caching Part 2

2005-07-25 Thread Jeroen Frijters
Mark Wielaard wrote: > On Mon, 2005-07-25 at 16:29 +0200, Jeroen Frijters wrote: > > I committed the attached patch to complete to ability of the VM to > > bypass the class caching in ClassLoader. > > > > 2005-07-25 Jeroen Frijters <[EMAIL PROTECTED]

[cp-patches] FYI: ClassLoader caching Part 2

2005-07-25 Thread Jeroen Frijters
Hi, I committed the attached patch to complete to ability of the VM to bypass the class caching in ClassLoader. Regards, Jeroen 2005-07-25 Jeroen Frijters <[EMAIL PROTECTED]> * java/lang/ClassLoader.java (loadedClasses): Set based on VMClassLoader.VM_USE

[cp-patches] RFC: RMI Class loader fix

2005-07-25 Thread Jeroen Frijters
Hi, I'm not an RMI person, but an IKVM user ran into an RMI problem that I think is caused by a problem in the RMI class loader that the attached patch should fix. Please comment. Regards, Jeroen * java/rmi/server/RMIClassLoader.java (loadClass(String, String)): Use Class.forNam

[cp-patches] FYI: Small additional ClassLoader VM extensibility point

2005-07-25 Thread Jeroen Frijters
Hi, I committed the attached patch, that allows a VM implementer to hook Classloader.findLoadedClass. Regards, Jeroen 2005-07-25 Jeroen Frijters <[EMAIL PROTECTED]> * java/lang/ClassLoader.java (findLoadedClass): Call VMClassLoader.findLoadedClass. * vm/referenc

RE: [cp-patches] Re: Serialization: readResolve and writeReplaceinparent class

2005-07-08 Thread Jeroen Frijters
Daniel Bonniot wrote: > > I'm fairly confident that IKVM.NET does the right thing. My guess is > > that JamVM incorrectly allows calls to private methods. > > Is this a known missing feature in jamvm? Are there mauve > tests to check it? I think that gnu.testlet.java.lang.reflect.Method.invoke i

RE: [cp-patches] Re: Serialization: readResolve and writeReplace inparent class

2005-07-08 Thread Jeroen Frijters
Daniel Bonniot wrote: > > Your patch broke the Mauve > gnu.testlet.java.io.Serializable.readResolve > > test. > > What VM do you get this failure with? I tried again with > jamvm and classpath with my patch (and without yours) and all > java.io.Serializable tests pass (0/5 failures). I used my

[cp-patches] FYI: Serialization Patch: fix support for private readResolve and writeReplace methods

2005-07-08 Thread Jeroen Frijters
Hi again, I applied the attached patch to fix the problem. Regards, Jeroen 2005-07-07 Jeroen Frijters <[EMAIL PROTECTED]> * java/io/ObjectStreamClass.java (findAccessibleMethod): Added code to make method accessible. > -Original Message- > From: Jer

RE: [cp-patches] Re: Serialization: readResolve and writeReplace inparent class

2005-07-08 Thread Jeroen Frijters
Hi Daniel, Your patch broke the Mauve gnu.testlet.java.io.Serializable.readResolve test. If the readResolve method is in the current class and it is private it is no longer found. Regards, Jeroen > -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] > On Behalf Of

RE: [cp-patches] RFC: java.awt.DefaultKeyboardFocusManager fix

2005-06-29 Thread Jeroen Frijters
Thomas Fitzsimmons wrote: > On Wed, 2005-06-29 at 15:14 +0200, Jeroen Frijters wrote: > > Hi, > > > > Can someone who is more up to speed with AWT please take a > > look at the attached patch? While running some AWT code I got > > a ClassCastException in t

[cp-patches] RFC: java.awt.DefaultKeyboardFocusManager fix

2005-06-29 Thread Jeroen Frijters
Hi, Can someone who is more up to speed with AWT please take a look at the attached patch? While running some AWT code I got a ClassCastException in this code and while I didn't quite understand the point of the code (or why it failed), it looked to me as if the logic was wrong. It tries to find t

[cp-patches] FYI: Small nio refactoring

2005-06-28 Thread Jeroen Frijters
Hi, I applied the attached patch to make life a little easier for VMs that don't use an int to represent a socket handle. Regards, Jeroen 2005-06-28 Jeroen Frijters <[EMAIL PROTECTED]> * gnu/java/nio/DatagramChannelImpl.java (getNativeFD): Removed. * g

RE: [cp-patches] [generics] RFC: VM interface changes

2005-06-19 Thread Jeroen Frijters
Andrew John Hughes wrote: > On Fri, 2005-06-17 at 15:29 +0200, Jeroen Frijters wrote: > > Hi, > > > > Here is the first part of my proposed VM interface changes > to make the > > VM interface more compatible with HEAD. > > Two main comments, the rest is pr

[cp-patches] [generics] RFC: VM interface changes

2005-06-17 Thread Jeroen Frijters
Hi, Here is the first part of my proposed VM interface changes to make the VM interface more compatible with HEAD. Please comment. Regards, Jeroen Index: java/lang/Class.java === RCS file: /cvsroot/classpath/classpath/java/lang/Clas

[cp-patches] [generics] FYI: java/util/TreeMap.java & java/lang/ThreadLocal.java compilation fixes

2005-06-17 Thread Jeroen Frijters
Hi, I committed the attached patch. Regards, Jeroen 2005-06-17 Jeroen Frijters <[EMAIL PROTECTED]> * java/lang/ThreadLocal.java, java/util/TreeMap.java: Fixes to make compiling with Eclipse Java Compiler SVN HEAD possible. Index: java/lang/ThreadLoca

RE: [cp-patches] FYI: Fixlet for DataInputStream.readLine

2005-06-16 Thread Jeroen Frijters
Roman Kennke wrote: > Am Mittwoch, den 15.06.2005, 18:00 +0200 schrieb Jeroen Frijters: > > Hi Roman, > > > > I don't think this is a good idea. It adds a dependency on > > the internals of two other classes and assumes invariants > > that may not even be

RE: [cp-patches] FYI: Fixlet for DataInputStream.readLine

2005-06-15 Thread Jeroen Frijters
Hi Roman, I don't think this is a good idea. It adds a dependency on the internals of two other classes and assumes invariants that may not even be true (for example, think of subclasses of BufferedInputStream). It also seems like it is too complicated for very little gain. Do you have a real worl

RE: [cp-patches] PATCH: debug logging

2005-06-05 Thread Jeroen Frijters
Casey Marshall wrote: > Attached is an initial implementation of a component-level logging > system, like I mentioned earlier on the Classpath list. Comments are > welcome. This looks like a very good idea to me. >String defaults = (String) AccessController.doPrivileged > (new GetPropert

[cp-patches] FYI: java/net/ServerSocket

2005-05-31 Thread Jeroen Frijters
Hi, I committed the attached patch to java/net/ServerSocket.java to make it more compatible with the JDK. I also added a testcase to Mauve. Regards, Jeroen 2005-05-31 Jeroen Frijters <[EMAIL PROTECTED]> * java/net/ServerSocket.java (bound): Removed. (local): New

[cp-patches] FYI: FileChannelImpl factory method instead of constructor

2005-05-30 Thread Jeroen Frijters
Hi, Since nobody objected, I committed this patch. Regards, Jeroen 2005-05-31 Jeroen Frijters <[EMAIL PROTECTED]> * gnu/java/nio/channels/FileChannelImpl.java (FileChannelImpl()): Removed. (FileChannelImpl(File,int)): Made private. (create): New

[cp-patches] RFC: FileChannelImpl factory method instead of constructor

2005-05-28 Thread Jeroen Frijters
Hi, I'd like to be able to substitute different subclasses (based on what OS we're running on) for FileChannelImpl, so I'd like to change the public constructor to a factory method. Any objections/comments? Regards, Jeroen 2005-05-28 Jeroen Frijters <[EMAIL PROTECTED]>

RE: [cp-patches] Patch: FYI: set encoding for classpath sources

2005-05-24 Thread Jeroen Frijters
Tom Tromey wrote: > I think the problem is that without '-encoding' there is no way to > enforce this constraint, as compilers tend to use the locale's > encoding. I understand, but what I meant was that we can try to enforce ASCII encoding on the platforms that support it and other platforms it w

RE: [cp-patches] Patch: FYI: set encoding for classpath sources

2005-05-23 Thread Jeroen Frijters
Tom Tromey wrote: > >>>>> "Jeroen" == Jeroen Frijters <[EMAIL PROTECTED]> writes: > > Jeroen> The version of Jikes I use (1.22 on Windows) doesn't > support the > Jeroen> -encoding option. Are there any pressing reasons why > we

RE: [cp-patches] Patch: FYI: set encoding for classpath sources

2005-05-23 Thread Jeroen Frijters
Tom Tromey wrote: > I'm checking this in. > > This sets Classpath's file encoding to "UTF-8". The version of Jikes I use (1.22 on Windows) doesn't support the -encoding option. Are there any pressing reasons why we can't simply stick to ASCII? Regards, Jeroen __

RE: [cp-patches] [Patch][RFC] Moving locale data to properties files

2005-05-10 Thread Jeroen Frijters
Michael Koch wrote: > I moved all locale data into properties file now. > These files are generated by an experimental version fo gnu.localegen > part of cp-tools. The functional changes to our sources are attached. > The locale data changes is uploaded here: > http://www.kaffe.org/~mkoch/locales-d

[cp-patches] FYI: java/lang/ClassLoader.java

2005-05-10 Thread Jeroen Frijters
Hi, I refactored ClassLoader.defaultGetSystemClassLoader() to allow VMClassLoader to more easily reuse the different steps of creating the system class loader hierarchy. Regards, Jeroen 2005-05-10 Jeroen Frijters <[EMAIL PROTECTED]> * java/lang/ClassLoade

RE: [cp-patches] Nio-charset patch commited (Patch to Stringcommited)

2005-04-18 Thread Jeroen Frijters
Sven de Marothy wrote: > Whoops, accidentily hit "send" before writing anything. > Anyway, it's fixed, patch attached. Now you've made them private, but the comments still say that they're package visible. I don't know if they should be private or not, but if not, it's probably better to update th

[cp-patches] FYI: java/nio/ByteBufferImpl.java, java/nio/CharBufferImpl.java

2005-04-18 Thread Jeroen Frijters
Hi, I committed the attached patch to fix CharBufferImpl to use array_offset properly and to optimize the get/put methods of ByteBufferImpl and CharBufferImpl, because these are now used heavily by String's new nio based character decoding/encoding. Regards, Jeroen 2005-04-18 Jeroen Fri

[cp-patches] FYI: java/lang/Class.java, vm/reference/java/lang/VMClass.java

2005-04-18 Thread Jeroen Frijters
Hi, I committed my earlier proposed patch to differentiate between "real" accessibility of a class and what is reported by reflection (for inner classes, which have a both a real accessibility and an additional one that is reported by reflection). Regards, Jeroen 2005-04-18 Jeroe

[cp-patches] FYI: gnu/java/beans/IntrospectionIncubator.java

2005-04-18 Thread Jeroen Frijters
Hi, I committed the attached fix. Regards, Jeroen 2005-04-18 Jeroen Frijters <[EMAIL PROTECTED]> * gnu/java/beans/IntrospectionIncubator.java (addToPropertyHash, addToListenerHash): Don't confuse get(), set(), is(), add() and remove() with properties or ev

[cp-patches] FYI: java/awt/GraphicsEnvironment.java

2005-04-18 Thread Jeroen Frijters
Hi, I committed the attached patch. Regards, Jeroen 2005-04-18 Jeroen Frijters <[EMAIL PROTECTED]> * java/awt/GraphicsEnvironment.java (localGraphicsEnvironment): New field. (getLocalGraphicsEnvironment): Added support for java.awt.graphicsenv pr

RE: [cp-patches] Nio-charset patch commited

2005-04-17 Thread Jeroen Frijters
Sven de Marothy wrote: > The final version has been comitted. It differs somewhat, so > here's that patch again. > > 2005-04-15 Sven de Marothy <[EMAIL PROTECTED]> > > * gnu/java/nio/charset/EncodingHelper.java: Added method > * java/io/InputStreamReader.java, > * java/io/Out

RE: PING: Re: [cp-patches] RFC: Fix for "XXX" use in java.util.Currency

2005-04-10 Thread Jeroen Frijters
Andrew John Hughes wrote: > On Mon, 2005-03-28 at 01:41 +0100, Andrew John Hughes wrote: > > The attached patch allows examples such as the following: > > > > NumberFormat.getCurrencyInstance(Locale.ENGLISH).getCurrency() > > > > to succeed with the result of a Currency instance containing "XXX"

[cp-patches] FYI: encoding alias patch committed

2005-03-29 Thread Jeroen Frijters
nd we still get the benefit of case insensitivity for the built in aliases. Regards, Jeroen 2005-03-29 Jeroen Frijters <[EMAIL PROTECTED]> * gnu/classpath/SystemProperties.java (static): Converted encoding aliases to lower case and removed redudant aliases. *

RE: RFC: Re: [cp-patches] Re: [commit-cp] classpath ./ChangeLogexamples/gnu/classpath/ex...

2005-03-27 Thread Jeroen Frijters
Tom Tromey wrote: > One question I haven't looked into is how strict we need to be about > rejecting "ldc " in class files with pre-1.5 versions. > > On the one hand, it is probably pedantically correct to reject this. > On the other hand, it can't possible hurt type safety (or anything > else I c

[cp-patches] RFC: Making character encoding aliases case-insensitive

2005-03-26 Thread Jeroen Frijters
existing startup scripts that specify an additional encoding alias that is not in lower case, will break. Any objections or comments? Regards, Jeroen 2005-03-26 Jeroen Frijters <[EMAIL PROTECTED]> * gnu/classpath/SystemProperties.java (static): Converted encoding aliases to

[cp-patches] FYI: java/awt/image/PixelGrabber.java

2005-03-26 Thread Jeroen Frijters
Hi, I applied the attached fix to PixelGrabber. Regards, Jeroen 2005-03-26 Jeroen Frijters <[EMAIL PROTECTED]> * java/awt/image/PixelGrabber.java (setPixels(int,int,int,int, ColorModel,byte[],int,int): Fixed byte to int conversion. Index: java/awt/image/PixelGrabbe

[cp-patches] FYI: javax/imageio/spi/IIORegistry.java

2005-03-26 Thread Jeroen Frijters
Hi, I applied the attached fix to IIORegistry. Regards, Jeroen 2005-03-26 Jeroen Frijters <[EMAIL PROTECTED]> * javax/imageio/spi/IIORegistry.java (IIORegistry): Don't assume that awt Toolkit is always ClasspathToolkit. Index: javax/imageio/spi/IIORe

RE: [cp-patches] RFC: Reflection refactoring

2005-03-22 Thread Jeroen Frijters
Archie Cobbs wrote: > Jeroen Frijters wrote: > > I would like to add an indirection layer to reflection (attached is > > java.lang.reflect.Field, but I also want to do this for Method and > > Constructor). By doing this, we can start caching these > objects in Class

[cp-patches] RFC: Reflection refactoring

2005-03-22 Thread Jeroen Frijters
Hi, I would like to add an indirection layer to reflection (attached is java.lang.reflect.Field, but I also want to do this for Method and Constructor). By doing this, we can start caching these objects in Class and have a Classpath common reflection caching mechanism. To give an idea of how that

[cp-patches] RFC: Class/VMClass patch

2005-03-21 Thread Jeroen Frijters
class modifiers to do the access check (i.e. it ignores the modifiers in the InnerClasses attribute), but Class.getModifiers() returns the modifiers from the InnerClasses attribute (obviously only if the class is an inner class). Regards, Jeroen 2005-03-21 Jeroen Frijters <[EMAIL P

RE: [cp-patches] FYI: Patch java/lang/Class.java

2005-03-11 Thread Jeroen Frijters
Michael Koch wrote: > On Fri, Mar 11, 2005 at 12:20:02PM +0100, Jeroen Frijters wrote: > > Hi, > > > > The previous patch wasn't quite enough. Fixed it. Attached > is the second > > patch that I committed. > > And an you actually tell as what this fixe

RE: [cp-patches] FYI: Patch java/lang/Class.java

2005-03-11 Thread Jeroen Frijters
Hi, The previous patch wasn't quite enough. Fixed it. Attached is the second patch that I committed. Regards, Jeroen 2005-03-11 Jeroen Frijters <[EMAIL PROTECTED]> * java/lang/Class.java (newInstance): Fixed previous patch. > -Original Message- > From:

[cp-patches] FYI: Patch java/lang/Class.java

2005-03-11 Thread Jeroen Frijters
Hi, I committed the attached patch. Regards, Jeroen 2005-03-11 Jeroen Frijters <[EMAIL PROTECTED]> * java/lang/Class.java (newInstance): Fix bug related to package private classes. Index: java/lang/Clas

RE: [cp-patches] Re: FYI: java/io/FileInputStream.java& java/io/FileOutputStream.java

2005-03-10 Thread Jeroen Frijters
Dalibor Topic wrote: > Sent: Thursday, March 10, 2005 15:24 > To: Jeroen Frijters > Subject: Re: [cp-patches] Re: FYI: > java/io/FileInputStream.java& java/io/FileOutputStream.java > > Jeroen Frijters wrote: > > Dalibor Topic wrote: > > >>OK, I'll p

RE: [cp-patches] Re: FYI: java/io/FileInputStream.java& java/io/FileOutputStream.java

2005-03-10 Thread Jeroen Frijters
Dalibor Topic wrote: /* Open a file. MODE is a combination of the above mode flags. */ - public FileChannelImpl (String path, int mode) throws FileNotFoundException + public FileChannelImpl (File file, int mode) throws FileNotFoundException { +final String path = file.getPath(); f

RE: [cp-patches] Re: FYI: java/io/FileInputStream.java& java/io/FileOutputStream.java

2005-03-09 Thread Jeroen Frijters
Dalibor Topic wrote: > Jeroen Frijters wrote: > > If another application creates a directory after the check, > but before > > the file is created, an incorrect error is thrown. So > ideally the native > > code that calls the platform file open API needs to ha

RE: [cp-patches] Re: FYI: java/io/FileInputStream.java& java/io/FileOutputStream.java

2005-03-09 Thread Jeroen Frijters
Dalibor Topic wrote: > Yeah, i can understand the inefficient part, as the same code is > duplicated in two classes. Could you elaborate some more on > the racy part? If another application creates a directory after the check, but before the file is created, an incorrect error is thrown. So idea

RE: [cp-patches] Re: FYI: java/io/FileInputStream.java& java/io/FileOutputStream.java

2005-03-09 Thread Jeroen Frijters
Dalibor Topic wrote: > Jeroen Frijters sumatra.nl> writes: > > 2005-03-03 Jeroen Frijters frijters.net> > > > > * java/io/FileInputStream.java (FileInputStream(File)), > > java/io/FileOutputStream.java (FileOutputStream(File)): > >

[cp-patches] FYI: java/net/URI.java

2005-03-07 Thread Jeroen Frijters
Hi, I committed the attached patch to fix URI authority parsing. Regards, Jeroen 2005-03-07 Jeroen Frijters <[EMAIL PROTECTED]> * java/net/URI.java (AUTHORITY_REGEXP): Corrected regexp. (AUTHORITY_USERINFO_GROUP,AUTHORITY_HOST_GROUP,AUTHORITY_PORT_GROUP): Adjusted to

[cp-patches] FYI: java/io/DataInputStream.java

2005-03-07 Thread Jeroen Frijters
Hi, I committed the attached patch. Regards, Jeroen 2005-03-07 Jeroen Frijters <[EMAIL PROTECTED]> * java/io/DataInputStream.java (ignoreInitialNewline): Removed (readLine): Changed newline handling. Index: java/io/DataInputStrea

RE: [cp-patches] The Any and the Principal.

2005-03-07 Thread Jeroen Frijters
Tom Tromey wrote: > > "Audrius" == Meskauskas Audrius <[EMAIL PROTECTED]> writes: > > Audrius> public abstract org.omg.CORBA.portable.InputStream > create_input_stream(); > > IMO it would be more idiomatic to import this class or use a wildcard > import for the package. Writing out fully

RE: [cp-patches] RFC: java/io/DataInputStream.java patch

2005-03-04 Thread Jeroen Frijters
I wrote: > I'd like to propose the attached patch to make > DataInputStream.readLine() simpler and more compatible with Sun's > implementation. I had an IKVM user report a problem because the \n > wasn't read eagerly by readLine(). The proposed patch works > much better than the current hack and i

[cp-patches] RFC: java/io/DataInputStream.java patch

2005-03-03 Thread Jeroen Frijters
nd is also much cleaner. Regards, Jeroen 2005-03-03 Jeroen Frijters <[EMAIL PROTECTED]> * java/io/DataInputStream.java (ignoreInitialNewline): Removed (readLine): Simplified handling of \r Index: java/io/DataInputStream.java ==

[cp-patches] FYI: ThreadLocal rewrite

2005-03-03 Thread Jeroen Frijters
Hi, Since nobody complained I committed my ThreadLocal rewrite. I'm also adding a testcase to Mauve for InheritableThreadLocal. Regards, Jeroen 2005-03-03 Jeroen Frijters <[EMAIL PROTECTED]> * java/lang/InheritableThreadLocal.java (threadMa

[cp-patches] FYI: java/io/FileInputStream.java & java/io/FileOutputStream.java

2005-03-03 Thread Jeroen Frijters
Hi, I committed the attached patch. Regards, Jeroen 2005-03-03 Jeroen Frijters <[EMAIL PROTECTED]> * java/io/FileInputStream.java (FileInputStream(File)), java/io/FileOutputStream.java (FileOutputStream(File)): Removed unnecessary File.isDirectory() check. Index

RE: [cp-patches] RFC: Different ThreadLocal implementation

2005-02-17 Thread Jeroen Frijters
I wrote: > I'd like to propose a different way to implement ThreadLocal. > The patch is attached. I realised that my new version would "leak" the ThreadLocal objects, so I've attached a new version of the patch that uses a WeakHashMap in Thread to store the locals. I liked the previous patch bet

[cp-patches] RFC: Different ThreadLocal implementation

2005-02-17 Thread Jeroen Frijters
Local: -local.valueMap.put(childThread, (childValue == null - ? NULL : parentValue)); Any comments? Regards, Jeroen 2005-02-17 Jeroen Frijters <[EMAIL PROTECTED]> * java/lang/InheritableThreadLocal.java (threadMa

RE: [cp-patches] Suggested patch: java/text/Collator.java

2005-02-10 Thread Jeroen Frijters
Michael Koch wrote: > Thanks, please apply imidiately. This make it at least possible to use > gjdoc with jamvm. I got an OutOfMemoryError now but the collation > thingie is at least worked around. Done. Regards, Jeroen 2005-02-10 Jeroen Frijters <[EMAIL PROTECTED]>

[cp-patches] Suggested patch: java/text/Collator.java

2005-02-10 Thread Jeroen Frijters
Hi, I'd like to apply the attached patch to make Collator.getInstance() work even if the required resource is missing (as it currently is) and to throw an InternalError instead of returning null should the rules fail to parse. Regards, Jeroen Index: java/text/Collator.java ===

<    1   2   3