Re: [cp-patches] FYI: javax.tools stuff

2008-01-09 Thread Michael Koch
On Wed, Jan 09, 2008 at 11:13:00PM +0100, Roman Kennke wrote: I'm beginning the implementation of javax.tools with two interfaces. 2006-01-09 Roman Kennke [EMAIL PROTECTED] * javax/tools/Diagnostic.java, * javax/tools/DiagnosticListener.java: New interfaces. Hmmm,

[cp-patches] Fix alsa support with GCC 4.2

2007-09-08 Thread Michael Koch
they dont know that option. Cheers, Michael 2007-09-08 Michael Koch [EMAIL PROTECTED] * native/jni/midi-alsa/Makefile.am (AM_CFLAGS): Removed @ERROR_CFLAGS@ to not fail build with GCC 4.2. Index: native/jni/midi-alsa/Makefile.am

Re: [cp-patches] Guidelines for annotations?

2007-03-09 Thread Michael Koch
On Fri, Mar 09, 2007 at 08:25:37PM +0100, Mario Torre wrote: Il giorno ven, 09/03/2007 alle 10.35 -0800, Keith Seitz ha scritto: @Override public void foo(); I suggest this one. It seems more clear to me. +1 Cheers, Michael -- .''`. | Michael Koch [EMAIL PROTECTED] : :' : | Free

Re: [cp-patches] Guidelines for annotations?

2007-03-09 Thread Michael Koch
about comments/javadoc? 1) Before @Override /** * foo */ 2) After /** * foo */ @Override I presume most people would prefer #1? +1 for 2. Michael -- .''`. | Michael Koch [EMAIL PROTECTED] : :' : | Free Java Developer http://www.classpath.org `. `' | `-| 1024D/BAC5

Re: [cp-patches] FYI: JTable fixlet:Mail Message possibly broken?

2006-07-25 Thread Michael Koch
On Tue, Jul 25, 2006 at 08:42:58AM +0200, Audrius Meskauskas wrote: The Thunderbird cannot open the attached patch which should be even not compressed. I can easily open all other patches, including the patch on LightweightDispatcher form Roman today. I would suggest to resend for the peace

Re: [cp-patches] FYI: X peers

2006-07-01 Thread Michael Koch
On Sat, Jul 01, 2006 at 10:33:10AM +0200, Roman Kennke wrote: Hi Raif, Am Samstag, den 01.07.2006, 09:24 +1000 schrieb Raif S. Naffah: hello Roman, On Friday 30 June 2006 01:27, Roman Kennke wrote: I checked in the Escher-based X peers and added some configury for enabling it. To

Re: [cp-patches] FYI: X peers

2006-07-01 Thread Michael Koch
On Sat, Jul 01, 2006 at 08:22:46PM +1000, Raif S. Naffah wrote: hello Michael, On Saturday 01 July 2006 20:05, Michael Koch wrote: On Sat, Jul 01, 2006 at 10:33:10AM +0200, Roman Kennke wrote: Am Samstag, den 01.07.2006, 09:24 +1000 schrieb Raif S. Naffah: On Friday 30 June 2006 01:27

Re: [cp-patches] X/Escher peers

2006-06-30 Thread Michael Koch
On Thu, Jun 29, 2006 at 11:28:52PM +0100, Andrew John Hughes wrote: I second that. Putting it in external/ would be best, at least until the distributions pick up on it and start including it in a uniform way. I second that too. But please do it in a way where distros can decide the use the

Re: [cp-patches] RFC: GConf preference api backend

2006-06-20 Thread Michael Koch
On Tue, Jun 20, 2006 at 08:29:04PM +0200, Mario Torre wrote: Using a root of /apps/java makes it clear we are storing java things there, if Sun implements a GConf based backend (or if someone likes my standalone plugin :) they likely will use this name (apps is standard for application in

Re: [cp-patches] RFC: GConf preference api backend

2006-06-18 Thread Michael Koch
On Sun, Jun 18, 2006 at 11:15:26AM +0200, Mark Wielaard wrote: Hi Michael, On Sat, 2006-06-17 at 18:07 +0200, Michael Koch wrote: As Mario has no CVS access yet I commited this for him. If you commit something for someone else you MUST make sure that it compiles cleanly, even

Re: [cp-patches] RFC: GConf preference api backend

2006-06-17 Thread Michael Koch
On Fri, Jun 16, 2006 at 01:56:13PM -0400, Thomas Fitzsimmons wrote: Thanks for this contribution! (FWIW, I wouldn't object if you wanted to make this the default backend now). Please commit, As Mario has no CVS access yet I commited this for him. Cheers, Michael --

Re: [cp-patches] [generics] Patch: RFC: import jsr166

2006-06-08 Thread Michael Koch
On Thu, Jun 08, 2006 at 10:34:57AM +0200, Jeroen Frijters wrote: Also, I've cleaned up my version of AnnotationInvocationHandler and will post it shortly. That would be great, then I can post my jamvm patch to use this too. Cheers, Michael -- Escape the Java Trap with GNU Classpath!

Re: [cp-patches] RFC: AnnotationInvocationHandler

2006-06-08 Thread Michael Koch
On Thu, Jun 08, 2006 at 11:05:53AM +0200, Jeroen Frijters wrote: Hi, As promised here is my cleaned up version of AnnotationInvocationHandler. I intend to check this into the trunk. Thanks. Please use a Unix file encoding when checking it in (line endings). Cheers Michael -- Escape the

Re: [cp-patches] FYI: rename libjawtgnu.so to libjawt.so

2006-05-26 Thread Michael Koch
On Fri, May 26, 2006 at 01:50:10PM -0400, Thomas Fitzsimmons wrote: Hi, applications that use the AWT Native Interface refer to libjawt.so. For binary compatibility with other AWT Native Interface implementations our .so must be named the same. Note to packagers: libjawt.so should be

Re: [cp-patches] FYI: Socket timeout impl and fix

2006-05-13 Thread Michael Koch
On Sat, May 13, 2006 at 04:54:02PM +0200, Sven de Marothy wrote: On Sat, 2006-05-13 at 13:54 +0200, Robert Schuster wrote: Hi, could you test whether Socket.setSoTimeout() really sets the send and receive timeout? I did, and it seems to work fine for me (A difference in 3 minutes

Re: [cp-patches] FYI: Socket timeout impl and fix

2006-05-13 Thread Michael Koch
On Sat, May 13, 2006 at 05:11:16PM +0200, Sven de Marothy wrote: On Sat, 2006-05-13 at 16:58 +0200, Michael Koch wrote: AFAIK Linux is the only one. If we want to stay portable we need to use select() and wait for the time of the timeout. In libgcj its already handled this way. Thats

Re: [cp-patches] RFC: defaultLocale changes

2006-04-11 Thread Michael Koch
On Tue, Apr 11, 2006 at 05:40:17PM +0200, Christian Thalinger wrote: On Wed, Mar 22, 2006 at 11:23:50AM +0100, Christian Thalinger wrote: On Tue, 2006-03-14 at 16:56 +0100, Michael Koch wrote: Together with a mauve testcase that proves this I'm fine with it. :-) (as I told you on IRC

Re: [cp-patches] Generating jarsigner script

2006-03-26 Thread Michael Koch
On Sun, Mar 26, 2006 at 04:08:30PM +1100, Raif S. Naffah wrote: +# -* bash *- + +java gnu.classpath.tools.jarsigner.Main $@ You should add a a shebang line to this file: #!/bin/sh The questions is if we should hardcode java or better check for a java executable in configure.ac and use

Re: [cp-patches] Re: RFC: gdkpixbuf looking vs main gdk lock

2006-03-26 Thread Michael Koch
On Mon, Mar 20, 2006 at 01:28:30PM -0500, Thomas Fitzsimmons wrote: On Mon, 2006-03-20 at 19:20 +0100, Mark Wielaard wrote: Hi Rob, On Mon, 2006-03-20 at 15:37 +, Robert Lougher wrote: On 3/20/06, Mark Wielaard [EMAIL PROTECTED] wrote: Done. If you have a scroll mouse please try

Re: [cp-patches] [Patch] locale data update - part 2

2006-03-25 Thread Michael Koch
On Mon, Mar 20, 2006 at 03:33:42PM +0100, Mark Wielaard wrote: Hi Michael, On Sun, 2006-03-19 at 22:40 +, Michael Koch wrote: I just commited another update for the locale data update to CLDR 1.3. The only things still missing is the update of the currency formats and the new locales

Re: [cp-patches] Re: [commit-cp] classpath ./ChangeLog gnu/java/lang/ClassHelper... [generics-branch]

2006-03-25 Thread Michael Koch
On Sat, Mar 25, 2006 at 04:41:02PM +, Andrew John Hughes wrote: On Sat, 2006-03-25 at 10:41 +0100, Mark Wielaard wrote: Hi Andrew, Nice to see you update the generics branch. But can you post to the patches list when you do so others are kept in the loop? I am curious why just this

[cp-patches] [Patch] added news entry about cldr 1.3 update

2006-03-25 Thread Michael Koch
Hello list, I added a news entry to our NEWS file that we now support CLDR 1.3. Cheers, Michael 2006-03-25 Michael Koch [EMAIL PROTECTED] * NEWS: Added item for CLDR 1.3 update. Index: NEWS === RCS file: /sources

[cp-patches] [Patch] removed locales for cldr 1.3 compatibility

2006-03-25 Thread Michael Koch
Hi list, I commited the attached patch to remove the locales that gor removed in CLDR 1.3. Michael 2006-03-25 Michael Koch [EMAIL PROTECTED] * resource/gnu/java/locale/LocaleInformation_ar_IN.properties, resource/gnu/java/locale/LocaleInformation_ar_IQ.properties

[cp-patches] [Patch] currency formats in locale data

2006-03-25 Thread Michael Koch
Hi list, I updated our locale data to have the fixed currency formats from CLDR 1.3. Cheers, Michael 2006-03-25 Michael Koch [EMAIL PROTECTED] * resource/gnu/java/locale/LocaleInformation_ar_JO.properties, resource/gnu/java/locale/LocaleInformation_ar_QA.properties

[cp-patches] [Patch] randome locale data udpates

2006-03-25 Thread Michael Koch
Hello, I forgot to commit some randome fixes to our locale data earlier. Cheers, Michael 2006-03-25 Michael Koch [EMAIL PROTECTED] * resource/gnu/java/locale/LocaleInformation_fa.properties, resource/gnu/java/locale/LocaleInformation_kn.properties, resource/gnu

[cp-patches] [Patch] locale data update - part 2

2006-03-19 Thread Michael Koch
Hello, I just commited another update for the locale data update to CLDR 1.3. The only things still missing is the update of the currency formats and the new locales. Cheers, Michael 2006-03-19 Michael Koch [EMAIL PROTECTED] * resource/gnu/java/locale

[cp-patches] [Patch] locale data update - part 1

2006-03-18 Thread Michael Koch
unzipped). You cna find the fill patch here: http://www.kaffe.org/~mkoch/locale.diff.gz2 Cheers, Michael 2006-03-18 Michael Koch [EMAIL PROTECTED] * resource/gnu/java/locale/LocaleInformation_aa.properties, resource/gnu/java/locale/LocaleInformation_af.properties

Re: [cp-patches] RFC: defaultLocale changes

2006-03-14 Thread Michael Koch
On Tue, Mar 14, 2006 at 01:12:06PM +0100, Christian Thalinger wrote: On Fri, Mar 10, 2006 at 03:38:02PM +0100, Christian Thalinger wrote: Hi! We had a problem with a mauve testlet which turned out to be related to the default locale. CACAO sets the user.country property instead of the

Re: [cp-patches] RFC:Collation rules for Lithuanian locale

2006-03-09 Thread Michael Koch
On Thu, Mar 09, 2006 at 08:10:32PM +0100, Audrius Meskauskas wrote: Index: resource/gnu/java/locale/LocaleInformation_lt.properties === RCS file:

[cp-patches] [Patch] InetSocketAddress.createUnresolved()

2006-03-08 Thread Michael Koch
Hello list, I commited the attached patch to introduce a new method from 1.5. I backed it up by a new mauve testcase which I will commit soon. Cheers, Michael 2006-03-08 Michael Koch [EMAIL PROTECTED] * java/net/InetSocketAddress.java (InetSocketAddress(String,int,resolve

[cp-patches] [Patch] java.net.Proxy and friends

2006-03-07 Thread Michael Koch
Hello all, I implemented some proxy stuff from Java 1.5. It needs enums and generics. Cheers, Michael 2006-03-07 Michael Koch [EMAIL PROTECTED] * gnu/java/net/DefaultProxySelector.java, java/net/Proxy.java, java/net/ProxySelector.java: New files. Index: gnu/java

[cp-patches] [Patch] Removed empty file

2006-02-21 Thread Michael Koch
Hello list, I removed the attached file as its empty, no java class inside. And it confuses GCJ when using current classpath CVS as snapshot when building gcj 4.1 or gcj trunk. Cheers, Michael 2006-02-21 Michael Koch [EMAIL PROTECTED] * gnu/javax/net/ssl/provider/PRNG.java

Re: [cp-patches] FYI: JComponent fixes: New regressions.

2006-02-16 Thread Michael Koch
On Thu, Feb 16, 2006 at 01:49:47PM +0100, Audrius Meskauskas wrote: Now the bottom close button disappears in the Swing Demo after any attempt to expand a tree node or resize the table column. Listen, it may sound nasty, but PLEASE USE SWING ACTIVITY BOARD AND MAUVE TESTS TO CHECK THE

[cp-patches] [Patch] Ignore tools.zip

2006-02-16 Thread Michael Koch
Hello list, I just commited the attached to ignore the generated tools.zip by CVS. Cheers, Michael 2006-02-17 Michael Koch [EMAIL PROTECTED] * tools/.cvsignore: Ignore tools.zip. Index: tools/.cvsignore === RCS file

[cp-patches] [Patch]

2006-02-14 Thread Michael Koch
Hello list, With the help of Thomas Fitzsimmons I prepared the attached patch that fixes the drawing in embedded windows. With gcjwebplugin I saw a shifted droplet when visiting http://www.classpath.org/. The attached patch fixes this. Ok to commit? Cheers, Michael 2006-02-15 Michael Koch

Re: [cp-patches] RFC: Stupid spec constants revisited

2006-02-10 Thread Michael Koch
On Fri, Feb 10, 2006 at 05:33:37PM +, David Gilbert wrote: FWIW, I'm in favour of committing this patch... Note that you need to disable CVS keyword substitiution. Otherwise value of the RCSID will change on every commit of this file. Just in case you are not aware of this. Cheers, Michael

Re: [cp-patches] RFC: Stupid spec constants revisited

2006-02-10 Thread Michael Koch
On Fri, Feb 10, 2006 at 02:50:32PM -0500, Stuart Ballard wrote: RTFP ;) hmmm, you are right. I would prefer the disbaled to make at least the definition of these evil constants look good. Cheers, Michael -- Escape the Java Trap with GNU Classpath! http://www.gnu.org/philosophy/java-trap.html

[cp-patches] RFC: new release of gjdoc

2005-12-18 Thread Michael Koch
- @@ -1,3 +1,7 @@ +2005-11-30 Michael Koch [EMAIL PROTECTED] + + * configure.ac (AC_INIT): Set version to 0.7.7. + 2005-11-30 Stephan Michels [EMAIL PROTECTED] PR gjdoc/24722: Index: configure.ac === RCS file

Re: [cp-patches] FYI: Added some real functionality to SystemFlavorMap

2005-11-28 Thread Michael Koch
On Tue, Nov 29, 2005 at 12:33:29AM +0100, Jan R?hrich wrote: I started to exchange some of SystemFlavorMaps implementation to a version with real functionality. Btw. I implemented the methods that were missing to JDK1.4 interface conformance. ... + /** + * This map maps native

Re: [cp-patches] Patch: RFC: javax.sound.sampled

2005-11-13 Thread Michael Koch
On Sat, Nov 12, 2005 at 05:51:55PM -0700, Tom Tromey wrote: I'm not checking this in yet. I haven't really done much testing of it, and I wanted some feedback first as well. This implements javax.sound.sampled and javax.sound.sampled.spi. I would say: Please commit. Bugs can be fixed later.

Re: [cp-patches] Patch: FYI: typo fix

2005-10-25 Thread Michael Koch
On Mon, Oct 24, 2005 at 06:18:44PM -0600, Tom Tromey wrote: I'm checking this in. This fixes a small javadoc typo I happened to see. Tom 2005-10-24 Tom Tromey [EMAIL PROTECTED] * java/io/ObjectOutputStream.java (useProtocolVersion): Fixed typo in javadoc. Index:

Re: [cp-patches] javax.swing.undo cleanup

2005-10-19 Thread Michael Koch
On Wed, Oct 19, 2005 at 08:46:16PM +0200, Roman Kennke wrote: Hi Micheal, -public class CannotRedoException - extends RuntimeException +public class CannotRedoException extends RuntimeException { The old version is according to our formatting rules. The new version is not.

Re: [cp-patches] FYI: javax.swing.filechooser.FileSystemView

2005-10-11 Thread Michael Koch
On Tue, Oct 11, 2005 at 10:31:22AM +, David Gilbert wrote: I committed this patch, there is no need for a new FileSystemView to be created for each call to getFileSystemView(): 2005-10-11 David Gilbert [EMAIL PROTECTED] * javax/swing/filechooser/FileSystemView.java

Re: [cp-patches] RFC: TreePath.toString

2005-06-05 Thread Michael Koch
On Sat, Jun 04, 2005 at 04:19:25PM -0700, Ka-Hing Cheung wrote: This makes TreePath.toString behave like Sun's 2005-06-04 Ka-Hing Cheung [EMAIL PROTECTED] * javax/swing/tree/TreePath.java: Implements toString(). Commited. Thanks for your contribution. Michael -- Escape the Java Trap

[cp-patches] Re: FYI: removed old native declarations.

2005-06-03 Thread Michael Koch
On Fri, Jun 03, 2005 at 01:42:23PM +0200, Sven de Marothy wrote: On Fri, 2005-06-03 at 06:01 +0200, Michael Koch wrote: Looks like this patch broke the JNI method check. Have you tried to build a clean tree with this patch before commiting? Yes, I did. I didn't have a problem

Re: [cp-patches] RFC: GtkImage patch.

2005-06-02 Thread Michael Koch
On Thu, Jun 02, 2005 at 12:23:32PM +0200, Sven de Marothy wrote: On Wed, 2005-06-01 at 18:30 -0400, Thomas Fitzsimmons wrote: /** * This is an old method, no idea if it's correct. */ private int[] convertPixels (byte[] pixels) Can this comment be removed? Only if you

Re: [cp-patches] FYI: Implementing Little Endian and Big Endian encodings.

2005-05-31 Thread Michael Koch
On Tue, May 31, 2005 at 08:38:38AM +0200, Meskauskas Audrius wrote: Following the OMG specification, CORBA must support both Big and Little Endian encodings (I did not find any notes about this in Java API - proably silence is the sign of agreement). The CORBA messages contain the flags,

Re: [cp-patches] FYI: Implementing Little Endian and Big Endian encodings.

2005-05-31 Thread Michael Koch
On Tue, May 31, 2005 at 01:45:03PM +0200, Meskauskas Audrius wrote: java.nio gives handling of little-, big- and mixed-endianess for free. Perhaps you wanna look into using this. This will probably increase performance of the CORBA code too. The direct use of the .nio package would make

[cp-patches] [Patch] removed used method in gtk peer

2005-05-25 Thread Michael Koch
Hi list, I commited the attached patch to remove a new method in the gtk peer which was never used and broke the build. Michael 2005-05-25 Michael Koch [EMAIL PROTECTED] * native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkScrollBarPeer.c (connetJObject): Removed. Index: native

Re: [cp-patches] [patch] fix GTK scrollbar peer

2005-05-25 Thread Michael Koch
On Tue, May 24, 2005 at 09:18:38PM -0400, Thomas Fitzsimmons wrote: Hi, This patch fixes a long-standing bug in the GTK scrollbar peer. The proper fix required some GTK work: http://bugzilla.gnome.org/show_bug.cgi?id=133263 The patch there landed in GTK 2.6. The attached patch, which

[cp-patches] [Patch] java.util.Locale.getISOStrings

2005-05-24 Thread Michael Koch
Hi list, I just commited the attached patch to fox an issue with java.util.Locale.getISOStrings(String) to handle the new locale properties files correctly. This fixes bug #13172. Michael 2005-05-25 Michael Koch [EMAIL PROTECTED] * java/util/Locale.java (getISOStrings): Re

Re: [cp-patches] FYI: Added getWindowAncestor in javax.swing.SwingUtilities

2005-05-23 Thread Michael Koch
On Mon, May 23, 2005 at 01:12:26PM +0200, Roman Kennke wrote: 2005-05-23 Roman Kennke [EMAIL PROTECTED] * javax/swing/JFileChooser.java: Fixed the values of several public constant fields. /Roman Index: javax/swing/SwingUtilities.java

Re: [cp-patches] RFC: notice cairo in INSTALL file

2005-05-20 Thread Michael Koch
On Fri, May 20, 2005 at 02:11:13AM +0200, Robert Schuster wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi. While searching for info how to enable cairo support our INSTALL was not helpful. This patch fixes that. 2005-05-20 Robert Schuster [EMAIL PROTECTED] * INSTALL:

[cp-patches] [Patch] locale stuff - functional changes

2005-05-19 Thread Michael Koch
I list, I commited the locale changes now as following. Michael 2005-05-19 Michael Koch [EMAIL PROTECTED] * java/text/DateFormatSymbols.java (getStringArray): New method. (getZoneStrings): Likewise. (DateFormatSymbols): Load symbols from properties files

Re: [cp-patches] FYI: Added loadClass(URL, String) method to RMIClassLoader.java

2005-05-19 Thread Michael Koch
On Wed, May 18, 2005 at 08:37:58AM -0600, Luis Sanabria wrote: Sorry, I sent this message to the incorrect list! 2005-05-15 Luis Sanabria [EMAIL PROTECTED] * java/rmi/server/RMIClassLoader.java: Added method loadClass (URL, String) which calls the method loadClass

Re: [cp-patches] FYI: fixed isShowing in java.awt.Window

2005-05-19 Thread Michael Koch
On Wed, May 18, 2005 at 03:03:19PM +0200, Roman Kennke wrote: Bogdan Grigurescu discovered a bug in Classpath, which prevented AWT Windows from painting lightweight components. Attached is a simple testcase that demostrates this. The problem was that the Window was not considered as

Re: [cp-patches] Re: Patch: FYI: fix http Headers oddity

2005-05-19 Thread Michael Koch
On Thu, May 19, 2005 at 10:30:40AM -0400, Bryce McKinlay wrote: Chris Burdess wrote: Bryce McKinlay wrote: Does anyone know why we use the custom LineInputStream class instead of, say, BufferedReader here? At one point BufferedReader.readLine() was buggy and could read too much and

[cp-patches] [Patch] Fixing locale list generator

2005-05-19 Thread Michael Koch
Hi list, I commited the attached patch to fix the generation of the locale list. Thanks to Robert Schuster for reporting this. CU, Michael 2005-05-20 Michael Koch [EMAIL PROTECTED] * scripts/generate-locale-list.sh: Use the new locale properties files. Index: scripts

Re: PING: Re: RFC: [cp-patches] META-INF support

2005-05-18 Thread Michael Koch
On Mon, May 16, 2005 at 01:19:47PM +0100, Andrew John Hughes wrote: On Sun, 2005-04-17 at 15:34 +0100, Andrew John Hughes wrote: On Mon, 2005-04-11 at 17:35 +0100, Andrew John Hughes wrote: On Mon, 2005-04-11 at 07:40 +0200, Michael Koch wrote: On Mon, Apr 11, 2005 at 03:59:00AM +0100

Re: [cp-patches] FYI: The first working CORBA prototype

2005-05-16 Thread Michael Koch
On Sun, May 15, 2005 at 03:17:24AM +0200, Meskauskas Audrius wrote: 2005-05-15 Audrius Meskauskas, Lithuania [EMAIL PROTECTED] I have just committed the following IIOP (CORBA) implementation: You broke Classpath compilation by introducing code using JUnit. Please fix this. Michael --

[cp-patches] [Patch][RFC] Moving locale data to properties files

2005-05-04 Thread Michael Koch
(the file is 530 kb in bzip2 format, 5.5 MB unpacked) Please comment on the changes. Michael 2005-05-04 Michael Koch [EMAIL PROTECTED] * java/text/DateFormatSymbols.java (getStringArray): New method. (getZoneStrings): Likewise. (DateFormatSymbols): Load symbols

Re: [cp-patches] Patch: FYI: update eclipse infrastructure

2005-05-03 Thread Michael Koch
On Mon, May 02, 2005 at 09:37:11AM +0200, Robert Schuster wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Tom, I am right that this needs at least Eclipse 3.0? Afaik this needs 3.1M?. 3.0 doesnt work for me. Michael -- Escape the Java Trap with GNU Classpath!

[cp-patches] [Patch] java.text.DecimalFormat

2005-05-02 Thread Michael Koch
Hi list, I just commited the attached patch to fix bug #12877. It fixes an issue with java.text.DecimalFormat.hashCode(). Michael 2005-05-02 David Gilbert [EMAIL PROTECTED] * java/text/DecimalFormat.java (hashCode): Reimplemented and added API docs. Index:

Re: [cp-patches] RFC: hacking guide - unrealistic code paths

2005-05-02 Thread Michael Koch
On Mon, May 02, 2005 at 09:35:48AM +0200, Robert Schuster wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi. I would prefer our own Error/Excpetion with preset text message. Otherwise we will get a different message string all over depending on who wrote the code. I think that

[cp-patches] [Patch] gnu.java.net.protocol.http.HTTPConnection

2005-04-29 Thread Michael Koch
Hi list, I commited the attached obvious patch to remove user agent handling in gnu.java.net.protocol.http.HTTPConnection. This is done in a better way in gnu.classpath.SystemProperties and friends. Michael 2005-04-29 Michael Koch [EMAIL PROTECTED] * gnu/java/net/protocol/http

[cp-patches] [Patch] java.nio.charset.Charset.defaultCharset()

2005-04-29 Thread Michael Koch
Hi list, I commited the attached patch to reformat the defaultCharset() method of java.nio.charset.Charset. Michael 2005-04-29 Michael Koch [EMAIL PROTECTED] * java/nio/charset/Charset.java (defaultCharset): Reformatted. Index: java/nio/charset/Charset.java

[cp-patches] [Patch] java.net.ServerSocket

2005-04-23 Thread Michael Koch
Hi list, I just commited the attached patch to merge java.net.ServerSocket with gcc HEAD again. Michael 2005-04-23 Michael Koch [EMAIL PROTECTED] * java/net/ServerSocket.java (getChannel): Improved javadoc comment. Index: java/net/ServerSocket.java

[cp-patches] [Patch] gnu.classpath.SystemProperties

2005-04-22 Thread Michael Koch
Hi list, I just commited the attached patch to reformat the class gnu.classpath.SystemProperties to meet our style. Michael 2005-04-22 Michael Koch [EMAIL PROTECTED] * gnu/classpath/SystemProperties.java: Reformatted. Index: gnu/classpath/SystemProperties.java

[cp-patches] [Patch] new nio jni headers regenerated

2005-04-21 Thread Michael Koch
Hi list, I just committed that attached patch to fix up our jni headers in CVS. Michael 2005-04-21 Michael Koch [EMAIL PROTECTED] * include/gnu_java_nio_charset_iconv_IconvDecoder.h, include/gnu_java_nio_charset_iconv_IconvEncoder.h: Regenerated with gcjh from gcc

[cp-patches] [Patch] VM interface for java.io.ObjectInputStream

2005-04-16 Thread Michael Koch
Hi list, I just commited the attached patch to put the native methods of java.io.ObjectInputInterface into the VM interface. Michael 2005-04-16 Michael Koch [EMAIL PROTECTED] * include/Makefile.am: Removed java_io_ObjectInputStream.h and added java_io_VMObjectInputStream.h

[cp-patches] [Patch] java.rmi.server.RemoteObject

2005-04-16 Thread Michael Koch
Hi list, I just commited the attached patch to remove an unused import statement. Michael 2005-04-16 Michael Koch [EMAIL PROTECTED] * java/rmi/server/RemoteObject.java: Removed unused import statement. Index: java/rmi/server/RemoteObject.java

Re: [cp-patches] FYI: MetalTabbedPaneUI fix

2005-04-15 Thread Michael Koch
On Fri, Apr 15, 2005 at 11:03:45AM +0200, Roman Kennke wrote: The following fix lets MetalTabbedPaneUI create one instance of itself instead of sharing a singleton. 2005-04-15 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/metal/MetalTabbedPaneUI.java (createUI):

Re: [cp-patches] FYI: fixed year in copyright notice of new Metal classes

2005-04-14 Thread Michael Koch
On Thu, Apr 14, 2005 at 06:28:53PM +0100, Andrew John Hughes wrote: Someone correct me if I'm wrong, but I think the amendment should be to list both years, not to throw away the first (i.e. 2002,2005 rather than 2005) Generally right but wrong in this case because these files were written

[cp-patches] [Patch] NetworkInterface constructors

2005-04-12 Thread Michael Koch
Hi list, I just commited the attached patch to fix a constructor in java.net.NetworkInterface and to introduce another convenience constructor. Michael 2005-04-12 Michael Koch [EMAIL PROTECTED] * java/net/NetworkInterface.java (NetworkInterface): Made constructor package

[cp-patches] [Patch] java.awt.FontMetrics

2005-04-12 Thread Michael Koch
Hi list, I just commited the attached patch to add teh missing getStringBounds methods. Michael 2005-04-12 Michael Koch [EMAIL PROTECTED] * java/awt/FontMetrics.java (getStringBounds): New methods. Index: java/awt/FontMetrics.java

[cp-patches] [Patch] java.awt.FontMetrics reformatted

2005-04-12 Thread Michael Koch
Hi list, I just commited the attached patch to reformat java/awt/FontMetics.java and to to make one method more general. Michael 2005-04-12 Michael Koch [EMAIL PROTECTED] * java/awt/FontMetrics.java: Reformatted. (getFontRenderContext): Handle case when java.awt.Graphics

[cp-patches] [Patch] java.awt.image.RasterOp

2005-04-12 Thread Michael Koch
Hi list, I just commited the attached patch to properly format the source. Michael 2005-04-12 Michael Koch [EMAIL PROTECTED] * java/awt/image/RasterOp.java: Fixed wrong formatting. Index: java/awt/image/RasterOp.java

[cp-patches] [Patch] HTMLDocument

2005-04-12 Thread Michael Koch
Hi list, I just commited the attached patch to add a new file written by Audrius. Michael 2005-04-12 Audrius Meskauskas, Lithuania [EMAIL PROTECTED] * javax/swing/text/html/HTMLDocument.java: New file. Index: javax/swing/text/html/HTMLDocument.java

[cp-patches] [Patch] java.io.FilePermission

2005-04-12 Thread Michael Koch
Hi list, I just commited the attached patch to implement handling of 'ALL FILES' in java.io.FilePermission. Michael 2005-04-12 Michael Koch [EMAIL PROTECTED] * java/io/FilePermission.java (serialVersionUID): Made private. (ALL_FILES): New constant. (implies

Re: PING: Re: [cp-patches] RFC: Fix for XXX use in java.util.Currency

2005-04-11 Thread Michael Koch
On Mon, Apr 11, 2005 at 08:46:42AM +0200, Jeroen Frijters wrote: Andrew John Hughes wrote: On Mon, 2005-03-28 at 01:41 +0100, Andrew John Hughes wrote: The attached patch allows examples such as the following: NumberFormat.getCurrencyInstance(Locale.ENGLISH).getCurrency() to

Re: [cp-patches] Re: -ko on libjava/external/sax/org/xml/sax/helpers/NamespaceSupport.java

2005-04-10 Thread Michael Koch
On Sat, Apr 09, 2005 at 11:17:55PM +0100, Andrew John Hughes wrote: On Sat, 2005-04-09 at 13:07 -0700, Geoffrey Keating wrote: I did cvs admin -ko libjava/external/sax/org/xml/sax/helpers/NamespaceSupport.java because it contains an $Id$ tag. (I would have just removed the tag,

Re: [cp-patches] META-INF support

2005-04-10 Thread Michael Koch
On Sun, Apr 10, 2005 at 03:42:39AM +0200, Robert Schuster wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, AFAIK we support not only delivery as glibj.zip but as glibj.jar and as a plain directory. The patch looks as if it only works for the zip-case. Are there any reasons to make

Re: [cp-patches] Reindented native/jni code

2005-04-09 Thread Michael Koch
On Sat, Apr 09, 2005 at 02:19:03AM +0200, Mark Wielaard wrote: Hi Guilhem. On Fri, 2005-04-08 at 14:34 +0200, Guilhem Lavaux wrote: GNU Indent (GNU style) seems to show a lot of differences after having been run on the native/jni code. I have run it on classpath, java-* directories and

[cp-patches] [Patch] PipedInputStream.read()

2005-04-01 Thread Michael Koch
Hi list, I commited the attached patch to fix a bug reported by Olafur Bragason. Michael 2005-04-01 Michael Koch [EMAIL PROTECTED] * java/io/PipedInputStream.java (read): Make sure a positive byte value is returned. Revised javadoc. Thanks to Olafur Bragason

[cp-patches] [Patch] GTK peer and java.beans fixes

2005-03-31 Thread Michael Koch
Hi list, I just commited the attached patch to merge code from Graphics2D.java to Graphics.java and to implement some mre methods in BeanContextSupport.java. Michael 2005-03-31 Michael Koch [EMAIL PROTECTED] * gnu/java/awt/peer/gtk/GdkGraphics.java (getClipBounds): Handle

Re: [cp-patches] [generics] FYI: Minor fixes to java.lang

2005-03-27 Thread Michael Koch
On Tue, Mar 22, 2005 at 10:09:00AM +0100, Meskauskas Audrius wrote: +/** + * For compatability with Sun's JDK + */ If possible, I would suggest not referring to our shiny Sun without the real need. Generally, it is very good to have serialVersionUID fixed, and not just

Re: [cp-patches] Patch: RFC: enable Jessie by default

2005-03-27 Thread Michael Koch
On Wed, Mar 23, 2005 at 02:43:21PM -0700, Tom Tromey wrote: What do people think of letting our URL implementation know about Jessie by default? We recommend Jessie on our front page, so this seemed reasonable to me. (Also, in java-gcj-compat, we currently set java.protocol.handler.pkgs to

Re: [cp-patches] Patch: FYI: MainThread -vs- class loader

2005-03-16 Thread Michael Koch
On Wed, Mar 16, 2005 at 04:41:30PM -0700, Tom Tromey wrote: I'm checking this in. I'm going to put something similar in libgcj shortly. While implementing java.endorsed.dirs, I discovered that MainThread tries to load the main class using its own class loader. However, it is probable that

Re: [cp-patches] RFC: JNI implementation of Selector #1

2005-03-16 Thread Michael Koch
On Thu, Mar 17, 2005 at 06:49:50AM +0100, Robert Schuster wrote: Brings Sourceforge's current no2 most-often downloaded p2p app to life. Well, this code is a straight adaption of GCJ's CNI equivalent. However two bug reports have been created out of this. Great work. Please review the

[cp-patches] [Patch] Typo fix in XmlParser.java

2005-03-13 Thread Michael Koch
Hi list, I just commited the attached patch to fix a typo in XmlParser.java. Michael 2005-03-13 Michael Koch [EMAIL PROTECTED] * gnu/xml/aelfred2/XmlParser.java: Fixed typo. Index: gnu/xml/aelfred2/XmlParser.java

[cp-patches] [Patch] imports fixed in https handler

2005-03-13 Thread Michael Koch
Hi list, I just commited the attached obvious fix for the import statements in the https handler. Michael 2005-03-13 Michael Koch [EMAIL PROTECTED] * gnu/java/net/protocol/https/Handler.java: Reworked import statements. Index: gnu/java/net/protocol/https/Handler.java

[cp-patches] [Patch] code cleanup in org.omg.CORBA

2005-03-13 Thread Michael Koch
Hi list, I commited the attached patch to do some code style changes found by checkstyle. Michael 2005-03-13 Michael Koch [EMAIL PROTECTED] * org/omg/CORBA/ARG_IN.java: Removed redundant modifiers. * org/omg/CORBA/ARG_INOUT.java: Likewise. * org/omg/CORBA

[cp-patches] Re: [commit-cp] classpath ./ChangeLog testsuite/javax.swing.tex...

2005-03-10 Thread Michael Koch
On Thu, Mar 10, 2005 at 07:29:58AM -0500, Audrius Me?kauskas wrote: CVSROOT: /cvsroot/classpath Module name: classpath Branch: Changes by: Audrius MeĀškauskas [EMAIL PROTECTED] 05/03/10 12:29:57 Modified files: . : ChangeLog Added files:

[cp-patches] [Patch] use standard copyright header on org.omg.CORBA

2005-03-09 Thread Michael Koch
Hi list, I just commited the attached patch to make org.omg.CORBA use our standard copyright header. Michael 2005-03-09 Michael Koch [EMAIL PROTECTED] * org/omg/CORBA/ARG_IN.java, org/omg/CORBA/ARG_INOUT.java, org/omg/CORBA/ARG_OUT.java, org/omg/CORBA

Re: [cp-patches] [Patch] use standard copyright header on org.omg.CORBA

2005-03-09 Thread Michael Koch
On Wed, Mar 09, 2005 at 02:52:11PM +0100, Meskauskas Audrius wrote: The copyright headers seems looking exactly as they were before applying the patch and the CVS repository returns an empty page after I ask for the differences. Is our CVS server still working properly? You maybe have -bB

Re: [cp-patches] FYI:swing.text.html.parser

2005-03-07 Thread Michael Koch
On Mon, Mar 07, 2005 at 06:15:14PM +0100, Meskauskas Audrius wrote: I commit the implementation of the error tolerant swing.text.html.parser package (SGML DTD driven HTML 4.01 parser). The implementation is too large to be sent into mailing list directly. Instead, you need to download from

[cp-patches] [Patch] import statement cleanup for gnu.java.security

2005-03-02 Thread Michael Koch
Hi list, I just commited the patch with the ChangeLog entry below. Unfortunately I forgot to create a patch before commiting. It was pretty straightforward. It just reordered import statements and replaced implicit imports with explicit imports. Michael 2005-03-02 Michael Koch [EMAIL

Re: [cp-patches] scrollable JList

2005-02-28 Thread Michael Koch
On Mon, Feb 28, 2005 at 11:27:30AM +0100, Roman Kennke wrote: Hi, please review the attached patch that improves the behaviour of JList within a scrolling container, especially with layoutOrientation set to JList.HORIZONTAL_WRAP or VERTICAL_WRAP. Is the ChangeLog entry ok? 2005-02-27

Re: [cp-patches] Report #4742: the patch is easy to make, but should we really fix that bug?

2005-02-28 Thread Michael Koch
On Mon, Feb 28, 2005 at 04:09:54PM +0100, Meskauskas Audrius wrote: The bug #4742 contains a comprehensive test, verifying the work of StreamTokenizer by parsing randomly generated data under randomly set options. It reveals the single difference between the Sun and Classpath implementations.

Re: [cp-patches] Formatting change of JTextComponent.java

2005-02-27 Thread Michael Koch
On Sun, Feb 27, 2005 at 06:48:25PM +0100, Meskauskas Audrius wrote: Because otherwise the path is impossible to read, as my text editor was configured not to use tabs. As a result, the path contains instructions to replace tabs by spaces, including lines where I have never done any changes.

  1   2   >