Re: [cp-patches] RFC: ClassLoader reference implementation using getResources

2006-05-11 Thread Olivier Jolly
of the packages referenced in all dependant (or own) .jar from many resource. Anyway, I think it's better to add some code in the Parser rather than the reference layer. I'll handle this (when I'll have time). Thx +Olivier 2006-05-11 Olivier Jolly [EMAIL PROTECTED] * vm/reference/java/lang

[cp-patches] FYI: Fix for PR27128

2006-05-06 Thread Olivier Jolly
Committed. Olivier Jolly wrote: Hi, this patch makes sure that the UnmodifiableMap.entrySet() result can't be used to change the wrapped map using toArray() or toArray(Object[]). It does so by recreating a resulting array using UnmodifiableMapEntry, which has been extracted from the inner

[cp-patches] FYI: Force calendar complete() before clear(int) [PR27362]

2006-05-06 Thread Olivier Jolly
Hi, this tiny patch ensure that the calendar internal state is completed before the clear(int) main code is performed so that it doesn't swallow pending changes. Seen its size and impact, it's going to be committed in a minut .. Regards +Olivier 2006-05-06 Olivier Jolly [EMAIL PROTECTED

[cp-patches] RFC: Fix for PR27128

2006-04-23 Thread Olivier Jolly
in the iterator method of UnmodifableEntrySet. However, I find this solution quite bulky and inelegant. If anyone is thinking of a cleaner way, please shout on me. Cheers +Olivier 2006-04-23 Olivier Jolly [EMAIL PROTECTED] * java/util/Collections.java(UnmodifiableMap.UnmodifiableEntrySet

Re: [cp-patches] RFC: change in VMClassLoader to define boot packages

2006-04-19 Thread Olivier Jolly
for me. About the Index.list file, maybe we should force it to be in glibj.zip? Best, Nicolas Olivier Jolly wrote: Hi, in the VMClassLoader reference file, we have a method to define boot packages and tell vm implementors that they may override it. I propose this patch to use the META-INF

[cp-patches] RFC: change in VMClassLoader to define boot packages

2006-04-13 Thread Olivier Jolly
in this archive. Thanks for the feedback. Regards +Olivier 2006-04-13 Olivier Jolly [EMAIL PROTECTED] * vm/reference/java/lang/VMClassLoader.java (getBootPackages): Loads boot packages list from the META-INF/INDEX.LIST file if it exists. Index: VMClassLoader.java

Re: [cp-patches] RFC: Checking file resource validity by walking path components

2006-03-25 Thread Olivier Jolly
Mark Wielaard wrote: Hi Olivier, On Mon, 2006-03-20 at 20:27 +0100, Olivier Jolly wrote: here is attached another version of the patch rewrote with StringTokenizer and an iterative algorithm. It still passes all the mauve test about resources and looks more efficient. Yes. Thanks

Re: [cp-patches] RFC: Checking file resource validity by walking path components

2006-03-20 Thread Olivier Jolly
Re Mark Wielaard wrote: I propose to check the validity of a File resource by walking through all the path components and making sure that all intermediate components are valid (ie File.isDirectory and File.exists are true) and that we never try to get out the root directory. I only

Re: [cp-patches] RFC: Checking file resource validity by walking path components

2006-03-10 Thread Olivier Jolly
Gary Benson a écrit : Olivier Jolly wrote: I propose to check the validity of a File resource by walking through all the path components and making sure that all intermediate components are valid (ie File.isDirectory and File.exists are true) and that we never try to get out the root

Re: [cp-patches] RFC: Checking file resource validity by walking path components

2006-03-09 Thread Olivier Jolly
Gary Benson a écrit : Olivier Jolly wrote: I propose to check the validity of a File resource by walking through all the path components and making sure that all intermediate components are valid (ie File.isDirectory and File.exists are true) and that we never try to get out the root

[cp-patches] RFC: Checking file resource validity by walking path components

2006-03-07 Thread Olivier Jolly
a StringTokenizer but it doesn't handle '//' as a single separator and split cie are 1.4+ additions. Thanks for comments Olivier 2006-03-07 Olivier Jolly [EMAIL PROTECTED] * java/net/URLClassLoader.java (FileURLLoader.getResource): Added test to validate all component of a resource path

[Fwd: Re: [cp-patches] RFC: file resources can be directory too]

2006-03-05 Thread Olivier Jolly
Hi, since no one objected on the fact that we should consider directories as valid resources, I committed the attached trivial patch with this changelog 2006-03-05 Olivier Jolly [EMAIL PROTECTED] Fixes PR 22813 * java/net/URLClassLoader.java (FileURLLoader.getResource): Allows

[cp-patches] RFC: file resources can be directory too

2006-02-28 Thread Olivier Jolly
with it. Since it seems that there already were a discussion (or rather fuss) about the nature of resource and how to deal with non plain files, if this patch seems too daring for you, don't hesitate to shout and discuss about it. Olivier 2006-02-28 Olivier Jolly [EMAIL PROTECTED] * java/net

Re: [cp-patches] RFC: fix in proxy creation of interfaces redefining toString, equals or hashCode

2006-02-20 Thread Olivier Jolly
and parameter types only), it is skipped. Since we're already adding them automatically, it is not missing of the resulting proxy and the declaring class remains Object.class 2006-02-19 Olivier Jolly olivier.jolly * java/lang/reflect/Proxy.java (ProxyData.getProxyData): Skipped overriding

Re: [cp-patches] RFC: fix in proxy creation of interfaces redefining toString, equals or hashCode

2006-02-20 Thread Olivier Jolly
Archie Cobbs wrote: Olivier Jolly wrote: I bumped into a major problem with spring and easymock which boiled down to being a subtle definition of a Proxy. In the case of the creation of a proxy which defines the same method as Object (which is non final and public), the method

Re: [cp-patches] RFC: fix in proxy creation of interfaces redefining toString, equals or hashCode

2006-02-20 Thread Olivier Jolly
Archie Cobbs wrote: Olivier Jolly wrote: [...] What does the failure look like? Within an InvocationHandler, the method instance which is given as parameter is not equals to Object.class.getDeclaredMethod(..., ...) if the interface the proxy is built on redefines one of the core Object

Re: [cp-patches] RFC: fix in proxy creation of interfaces redefining toString, equals or hashCode

2006-02-20 Thread Olivier Jolly
with an extra comment for this method 2006-02-20 Olivier Jolly [EMAIL PROTECTED] * java/lang/reflect/Proxy.java (ProxyData.getProxyData): Skipped overriding of core methods. (ProxyData.isCoreObjectMethod): New method. Thanks, Mark Olivier Index: Proxy.java

[cp-patches] RFC: fix in proxy creation of interfaces redefining toString, equals or hashCode

2006-02-19 Thread Olivier Jolly
name and parameter types only), it is skipped. Since we're already adding them automatically, it is not missing of the resulting proxy and the declaring class remains Object.class 2006-02-19 Olivier Jolly olivier.jolly * java/lang/reflect/Proxy.java (ProxyData.getProxyData): Skipped

[cp-patches] Request for approval in deserialization fix

2006-02-15 Thread Olivier Jolly
Hi, as discussed on irc, I request the approval of this fix in the deserialization part with the following changelog : 2006-02-15 Olivier jolly [EMAIL PROTECTED] Fixed bug #14144 * java/io/ObjectInputStream.java (readClassDescriptor) Class doesn't have to be abstract

[cp-patches] Request for approval in serialization fix

2006-02-15 Thread Olivier Jolly
Hi, here is another individual fix proposition in the serialization area, but in the serialization process itself this time. I propose to commit it with the following changelog : 2006-02-15 Olivier Jolly [EMAIL PROTECTED] * java/io/ObjectOutputStream.java (writeClassDescriptor): Call

Re: [cp-patches] Patch: request for approval of serialization related fixes

2006-02-13 Thread Olivier Jolly
this: // find the first non-serializable, non-abstract // class in clazz's inheritance hierarchy That should be changed to say what the code does now. And could you add 2006 to the copyright years in both files? A good ChangeLog entry for this part would be: 2006-02-12 Olivier Jolly [EMAIL PROTECTED

[cp-patches] Patch: request for approval of serialization related fixes

2006-02-12 Thread Olivier Jolly
Hi, this is my first patch proposition to classpath. I just have my paperwork done with FSF and I have created an account on savannah as ojolly. Those patches are both dealing with serialization. One deals with the generation of back reference handle in the output stream which was forgotten