[cp-patches] FYI: Fix for java.lang.Integer

2007-07-03 Thread Tania Bento
ed stating that this behaviour is expected: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6576055. Here is the Changelog: 2007-07-03 Tania Bento <[EMAIL PROTECTED]> * java/lang/Integer.java: (parseInt(String,int,boolean)): Throw NumberFormatException if St

[cp-patches] RFC: Fix in Currency.getInstance(Locale)

2007-06-22 Thread Tania Bento
: gnu.testlet.java.util.Currency.getInstance. 2007-06-22 Tania Bento <[EMAIL PROTECTED]> * java/util/Currency.java: (getInstance (Locale)): Check that the country of the locale given is valid. If it is not, throw an IllegalArgumentException. Index: java/util/Currenc

Re: [cp-patches] Guidelines for annotations?

2007-03-09 Thread Tania Bento
On Fri, 2007-03-09 at 15:17 -0500, Francis Kung wrote: > @Override > public void foo(); > >> > >> Me too. Three votes... maybe the motion passes? :) > > > > So that's several votes for this style already. > > +1, FWIW > > > 2) After > > /** > > * foo > > */ > > @Override > > +1 f

Re: [cp-patches] FYI: Permission minor fix

2007-01-10 Thread Tania Bento
Sorry... I attached the wrong file. This one actually shows what I am referring to when I write Test 1, Test 2, Test 3 and Test 4. On Wed, 2007-01-10 at 16:41 -0500, Tania Bento wrote: > Hey, > > On Tue, 2007-01-09 at 18:01 -0800, David Daney wrote: > > Roman Kennke

Re: [cp-patches] FYI: Permission minor fix

2007-01-10 Thread Tania Bento
Hey, On Tue, 2007-01-09 at 18:01 -0800, David Daney wrote: > Roman Kennke wrote: > > Hi, > > > > > >> This fixes a minor bug in Permission's toString method. I also changed > >> it to use a StringBuffer instead. > >> > > > > Why not use StringBuilder? Seems slightly more efficient. > >

[cp-patches] FYI: Permission minor fix

2007-01-09 Thread Tania Bento
Hey, This fixes a minor bug in Permission's toString method. I also changed it to use a StringBuffer instead. Cheers, Tania 2007-01-09 Tania Bento <[EMAIL PROTECTED]> * java/security/Permission.java: (toString): If there are no actions, then there should not

[cp-patches] FYI: CardLayout fix

2007-01-03 Thread Tania Bento
test for these changes. Cheers, Tania 2007-01-03 Tania Bento <[EMAIL PROTECTED]> * java/awt/CardLayout.java: (maximumLayoutSize): Return a new Dimension with a width of value Integer.MAX_VALUE and a height of value Integer.MAX_VALUE if Component

[cp-patches] FYI: Another ScrollPane fix

2006-12-08 Thread Tania Bento
Hey, This patch fixes a bug in java.awt.ScrollPane's doLayout method. When doLayout() is called, the location of the scrollpane's child should be set to (0,0). This patch now causes a failing Harmony test to pass. I have also committed a mauve test for it. Cheers, Tania 2006-12

[cp-patches] FYI: ScrollPane fixes

2006-12-08 Thread Tania Bento
ithin the allowed bounds. That is, x >= 0, y >=0 , width <= (child's width - viewport width) and height <= (child's height - viewport height). This patch passes a couple of failing Harmony's tests. I have also commited mauve tests for these changes. Cheers, Tania

Re: [cp-patches] FYI: CompoundBorder fix

2006-12-06 Thread Tania Bento
Hey, On Wed, 2006-12-06 at 12:51 -0500, Tania Bento wrote: > Hi David, > > On Wed, 2006-12-06 at 16:39 +, David Gilbert wrote: > > Hi Tania, > > > > It is a good idea to report such problems (in the specification) to > > Sun. Although, this one has alr

Re: [cp-patches] FYI: CompoundBorder fix

2006-12-06 Thread Tania Bento
Hi David, On Wed, 2006-12-06 at 16:39 +, David Gilbert wrote: > Hi Tania, > > It is a good idea to report such problems (in the specification) to > Sun. Although, this one has already been reported: > > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4778988 Thanks for the info. I act

[cp-patches] FYI: CompoundBorder fix

2006-12-06 Thread Tania Bento
mauve test I just committed (gnu.testlet.javax.swing.border.CompoundBorder.isBorderOpaque) shows that if both the inside and outside borders are null, then true is returned. This patch fixes a failing Harmony test. Cheers, Tania 2006-12-06 Tania Bento <[EMAIL PROTECTED]> *

[cp-patches] FYI: TagParser fix

2006-11-29 Thread Tania Bento
glib's g_strcompress function. This patch fixes also fixes the following Bugzilla Bug: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216038 Cheers, Tania 2006-11-29 Tania Bento <[EMAIL PROTECTED]> * tools/gnu/classpath/tools/appletviewer/TagParser.java: (

[cp-patches] FYI: TextHitInfo fixes

2006-11-24 Thread Tania Bento
now cause a couple of failing Harmony's tests to pass. I have also committed mauve tests. Cheers, Tania 2006-11-24 Tania Bento <[EMAIL PROTECTED]> * java/awt/font/TextHitInfo.java (equals(TextHitInfo)): If TextHitInfo parameter is null, return false. (b

[cp-patches] FYI: JRootPane fix

2006-11-22 Thread Tania Bento
ion's API. I have also committed a mauve test. Cheers, Tania 2006-11-22 Tania Bento <[EMAIL PROTECTED]> * javax/swing/JRootPane.java (setLayeredPane): Added documentation; throw IllegalComponentStateException if layered pane parameter is null. In

[cp-patches] JLabel fix

2006-11-09 Thread Tania Bento
ritten and commited mauve tests. Cheers, Tania 2006-11-09 Tania Bento <[EMAIL PROTECTED]> * javax/swing/JLabel.java (JLabel(Icon)): Changed documentation; Changed text to null. (JLabel(Icon,int)): Likewise. (JLabel(text)): Changed documenation.

[cp-patches] FYI: FlowLayout fix

2006-11-07 Thread Tania Bento
ed a mauve test. Cheers, Tania 2006-11-07 Tania Bento <[EMAIL PROTECTED]> * java/awt/FlowLayout.java (getSize): If parent does not have a component, then a different formula is used to calcuate the width. Index: java/awt

[cp-patches] Re: FYI: TextComponent fix

2006-11-06 Thread Tania Bento
Sorry... Forgot to attach the patch. On Mon, 2006-11-06 at 15:15 -0500, Tania Bento wrote: > Hey, > > This patch fixes a bug in java.awt.TextComponent.setSelectionStart(int) > that was exposed by Harmony's testsuites. I have committed a mauve test > for this change.

[cp-patches] FYI: TextComponent fix

2006-11-06 Thread Tania Bento
Hey, This patch fixes a bug in java.awt.TextComponent.setSelectionStart(int) that was exposed by Harmony's testsuites. I have committed a mauve test for this change. Cheers, Tania 2006-11-06 Tania Bento <[EMAIL PROTECTED]> * java/awt/TextComponent.java (setSel

[cp-patches] FYI: TextField fixes

2006-11-06 Thread Tania Bento
Hey, This patch fixes a bug that was exposed by Harmony's testsuites. I have also committed a mauve test. The bugs were in the minimizeSize(int) and preferredSize(int) methods. Cheers, Tania 2006-11-06 Tania Bento <[EMAIL PROTECTED]> * java/awt/TextField.java (

[cp-patches] FYI: TextArea fixes

2006-11-03 Thread Tania Bento
er to display, and on the size of the font in which the text would be displayed." This is not the case. I have written mauve test that shows this. Cheers, Tania 2006-11-03 Tania Bento <[EMAIL PROTECTED]> * java/awt/TextArea.java (getMinimumSize): Changed documenta

[cp-patches] FYI: ComponentEvent fix

2006-11-03 Thread Tania Bento
Hey, This patch modifies the string representation returned in java.awt.event.ComponentEvent.paramString(). This fix now passes a failing intel test. I have also committed a mauve test. Cheers, Tania 2006-11-03 Tania Bento <[EMAIL PROTECTED]> * java/awt/event/ComponentEven

[cp-patches] FYI: ScrollPaneAdjustable fix

2006-11-01 Thread Tania Bento
Hey, This patch modifies the string representation returned in java.awt.ScrollPaneAdjustable.paramString(). This fix now passes a failing intel test. I have also committed a mauve test. Cheers, Tania 2006-11-01 Tania Bento <[EMAIL PROTECTED]> * java/awt/ScrollPaneAdjustabl

[cp-patches] FYI: GridBagLayout method implemented

2006-11-01 Thread Tania Bento
Hey, This implements the missing toString() method in java.awt.GridBagLayout. This patch now passes a failing intel test. I have also committed a mauve test. Cheers, Tania 2006-11-01 Tania Bento <[EMAIL PROTECTED]> * java/awt/GridBagLayout.java (toString): Implemented

Re: [cp-patches] FYI: JTextField fix

2006-10-31 Thread Tania Bento
Roman Yup, you are right. When actionCommand is null, then getText() is used instead. I have written a mauve test (gnu.testlet.javax.swing.JTextField.fireActionPerformed) that checks this and have committed it. Once you give me the okay, I'll commit this patch. Thanks, Tania 2006-10-31

[cp-patches] FYI: JTextField fix

2006-10-31 Thread Tania Bento
login session and allows the application to load. Tom helped me out with this problem. It turned out to be much simpler than what I had thought. Cheers, Tania 2006-10-31 Tania Bento <[EMAIL PROTECTED]> * javax/swing/JTextField.java (fireActionPerformed): When creating t

Re: [cp-patches] FYI: Dialog and FileDialog fixes

2006-10-26 Thread Tania Bento
Hey Tom, You're right. Thanks. Tania On Wed, 2006-10-25 at 15:33 -0600, Tom Tromey wrote: > >>>>> "Tania" == Tania Bento <[EMAIL PROTECTED]> writes: > > Tania> + if (file == "") > Tania> +this.file = null; > > You probably want: if ("".equals(file)) > > Tom

[cp-patches] FYI: Dialog and FileDialog fixes

2006-10-25 Thread Tania Bento
Hey, This patch fixes a couple of bugs in java.awt.Dialog and java.awt.FileDialog. I have commited a mauve test for these changes. Cheers, Tania 2006-10-25 Tania Bento <[EMAIL PROTECTED]> * java/awt/Dialog.java: Created new private variable next_dialog_

Re: [cp-patches] RFC: Scrollbar fixes

2006-10-24 Thread Tania Bento
Hey, On Fri, 2006-10-20 at 18:07 -0400, Thomas Fitzsimmons wrote: > > 4. I removed the two bigger if-clauses that deals with the range because > > (a) it will never happen that the range = 0 because we know that maximum > > will never equal minimum) and (b) it doesn't matter if lineIncrement is >

[cp-patches] RFC: Scrollbar fixes

2006-10-20 Thread Tania Bento
cessary (refer to (4) above) and if the value of lineIncrement is 0, then lineIncrement should be set to 1 and not 0. These changes also applied to setBlockIncrement. Again, could someone kindly comment on or approve this patch. Thanks, Tania 2006-10-20 Tania Bento <[EMAIL PROTECTED]>

Re: Re: [cp-patches] RFC: GtkButtonPeer fix

2006-10-19 Thread Tania Bento
I've already spoken to Robert about this via email. On Wed, 2006-10-18 at 22:21 +0100, Robert Lougher wrote: > Any details on how to reproduce it? Is it 100% reproducible? Send > some details and I'll have a look at it. > > Rob. > > On 10/18/06, Tania Bento <[E

[cp-patches] FYI: CardLayout fixes

2006-10-18 Thread Tania Bento
to pass. Cheers, Tania 2006-10-18 Tania Bento <[EMAIL PROTECTED]> * java/awt/CardLayout.java: (maximumLayoutSize): Return a new Dimension with Integer.MAX_VALUE as its height and width if Container passed as argument is null. (gotoComponent): Consider th

Re: [cp-patches] RFC: GtkButtonPeer fix

2006-10-18 Thread Tania Bento
Hey, Upon further inspection, it turns out that this is a bug in jamvm. Sorry, Tania On Wed, 2006-10-18 at 16:36 -0400, Tania Bento wrote: > Hey, > > This patch fixes a segmentation fault caused when the button's label was > null. > > Can someone kindly comment o

[cp-patches] RFC: GtkButtonPeer fix

2006-10-18 Thread Tania Bento
Hey, This patch fixes a segmentation fault caused when the button's label was null. Can someone kindly comment on or approve this patch? Thanks, Tania 2006-10-18 Tania Bento <[EMAIL PROTECTED]> *native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkButtonPeer.c: (

[cp-patches] FYI: Yet another ScrollPane fix

2006-10-13 Thread Tania Bento
Hey, The setLayout method should never be called. If it is, an AWTError should be thrown. There is not stated in the Java API, so I wrote a mauve test to show this (committed). Tania 2006-10-13 Tania Bento <[EMAIL PROTECTED]> * java/awt/ScrollPane.java (setLayout):

[cp-patches] FYI: ScrollPaneAdjustable fixes

2006-10-13 Thread Tania Bento
Hey, These are minor fixes that now causing failing Intel tests to pass. These three methods should just throw an AWTError whenever called. Here is Java's API that supports this: http://java.sun.com/j2se/1.4.2/docs/api/java/awt/ScrollPaneAdjustable.html 2006-10-13 Tania Bento &l

[cp-patches] FYI: ScrollPane fixes

2006-10-13 Thread Tania Bento
Hey, These fixes are minor and now pass failing Intel tests. 2006-10-13 Tania Bento <[EMAIL PROTECTED]> * java/awt/ScrollPane.java (addImpl): When calling super, index should be value passed, not -1. (getIsValidString): New helper method for param

Re: [cp-patches] RFC: JTable, ComponentGraphics and BasicTableUI fixes

2006-09-29 Thread Tania Bento
on is > avoided. This should be done in a separate patch if possible. ( I must > blame myself here, as I sometimes post such patches myself ). > > Cheers, Roman > > > > > > Thanks, > > Tania > > > > 2006-08-28 Tania Bento <[EMAIL PROTECTED]>

[cp-patches] RFC: JTable, ComponentGraphics and BasicTableUI fixes

2006-09-28 Thread Tania Bento
Hey, This patch fixes a few bugs exposed by Bugzilla Bug #203674. I think the ChangeLog explains the changes well. Could someone kindly approve/comment on this patch. Thanks, Tania 2006-08-28 Tania Bento <[EMAIL PROTECTED]> * javax/swing/plaf/basic/BasicTableU

[cp-patches] FYI: Rectangle and GridLayout fixes

2006-09-26 Thread Tania Bento
Hey, These fixes are minor and fix failing Intel tests. I have also committed a mauve test (committed) for the Rectangle fixes. Tania 2006-09-26 Tania Bento <[EMAIL PROTECTED]> * java/awt/GridLayout.java (toString): There is no common before hgap. * ja

[cp-patches] RFC: GConfNativePeer fix

2006-09-21 Thread Tania Bento
ks, Tania 2006-09-21 Tania Bento <[EMAIL PROTECTED]> * native/jni/gconf-peer/GConfNativePeer.c (Java_gnu_java_util_prefs_gconf_GConfNativePeer_gconf_1client_1add_1dir): Changed the condition of the if-clause. Index: native/jni/gconf-p

[cp-patches] JTabbedPane fix

2006-09-20 Thread Tania Bento
DDemo. Can someone kindly approve/comment on this patch. Cheers, Tania 2006-09-20 Tania Bento <[EMAIL PROTECTED]> * javax/swing/JTabbedPane.java: (insertTab): Notify ChangeListeners if the tab inserted is selected. (setModel): A ChangeListener should be created on

Re: [cp-patches] RFC: JTable, BasicTableUI, ComponentGraphics

2006-09-13 Thread Tania Bento
Hey Tom, > Looks fine, except: > > > +if (row == 0 && column == 0) > > + cellRect.width = 75; > > How is this value derived? > > Tom I wrote a mauve test for this. I just committed it. Tania

[cp-patches] RFC: JTable, BasicTableUI, ComponentGraphics

2006-09-13 Thread Tania Bento
er window, over another and back again. Could someone kindly comment on or approve this patch. Cheers, Tania Here's the ChangeLog entry: 2006-09-13 Tania Bento <[EMAIL PROTECTED]> * javax/swing/JTable.java (columnAtPoint): Added check to avoid Arra

Re: [cp-patches] RFA: MenuShortcut.java

2006-08-28 Thread Tania Bento
Commited. On Tue, 2006-08-22 at 15:33 -0400, Tania Bento wrote: > Hey, > > This patch fixes a failing test in Intel's TestSuite. I have committed > a mauve test for this. > > Could someone kindly comment on and/or approve this patch. > > Cheers, > Tania >

Re: [cp-patches] RFA: List.java

2006-08-24 Thread Tania Bento
Ignore this patch for now. I'm doing more testing. On Thu, 2006-08-24 at 14:20 -0400, Tania Bento wrote: > Hey, > > This patch fixes a bug that was exposed by Intel's testSuite in the > setMultipleMode method of List.java. I have committed a new mauve test > fi

[cp-patches] RFA: List.java

2006-08-24 Thread Tania Bento
Hey, This patch fixes a bug that was exposed by Intel's testSuite in the setMultipleMode method of List.java. I have committed a new mauve test file that tests that method. Could someone please approve/comment on this patch. Thanks, Tania 2006-08-24 Tania Bento <[EMAIL P

[cp-patches] FYI: Color.java

2006-08-23 Thread Tania Bento
Hey, This patch (committed) fixes the brighter method. The existing algorithm for calculating the new colour wasn't 100% correct. I have commited a new mauve test for this. Tony and I worked on this. Cheers, Tania 2006-08-23 Tania Bento <[EMAIL PROTECTED]> * java/awt

[cp-patches] RFA: MenuShortcut.java

2006-08-22 Thread Tania Bento
Hey, This patch fixes a failing test in Intel's TestSuite. I have committed a mauve test for this. Could someone kindly comment on and/or approve this patch. Cheers, Tania 2006-08-22 Tania Bento <[EMAIL PROTECTED]> * java/awt/MenuShortcut.java (MenuShortcut (i

[cp-patches] RFC: JTree and BasicToolBarUI

2006-08-21 Thread Tania Bento
Hey, The application JabRef was not even starting on Classpath. This patch enables it to start up. However, it seems to freeze once that happens. It still needs some work. Could someone kindly approve this patch so that I may commit it. Thanks! Tania 2006-08-21 Tania Bento <[EM

[cp-patches] FYI: Choice.java

2006-08-01 Thread Tania Bento
Hey, This patch modifies the remove(int) method. It now makes classpath pass a couple of failing Intel tests. I have a mauve test for the remove method and will be committing it after I commit this patch. 2006-08-01 Tania Bento <[EMAIL PROTECTED]> * java/awt/Choic

[cp-patches] FYI: CardLayout.java minor fix

2006-08-01 Thread Tania Bento
Hey, This patch fixes the format outputted of the toString method and the order of the if-clause. This patch now fixes a couple of failing Intel tests. 2006-08-01 Tania Bento <[EMAIL PROTECTED]> * java/awt/CardLayout.java (toString): Changed format of string out

[cp-patches] FYI: List.java NPE fix

2006-08-01 Thread Tania Bento
Hey, This patch just fixes a NPE that was being thrown in the select(int) method. 2006-08-01 Tania Bento <[EMAIL PROTECTED]> * java/awt/List.java (select): Check if selected is null before execution of for-loop. If it is null, selected is instantiat

[cp-patches] RFA: List.java

2006-07-26 Thread Tania Bento
ifications were also based on harmony's test suites. If someone could kindly review this patch and approve and/or comment on it, that would be great. Thanks. Tania 2006-07-26 Tania Bento <[EMAIL PROTECTED]> * java/awt/List.java Initialized private v

[cp-patches] FYI: GridLayout.java minor fixes

2006-07-18 Thread Tania Bento
Hey, These changes (committed) now pass a few of Intel's tests. 2006-07-18 Tania Bento <[EMAIL PROTECTED]> * java/awt/GridLayout.java (setHgap): Illegal Argument Exception should not be thrown if hgap < 0. (setVgap): Illegal Argument Exception

Re: [cp-patches] RFA: FlowLayout.java

2006-07-14 Thread Tania Bento
Thanks. Committed. On Fri, 2006-07-14 at 10:22 -0400, Lillian Angel wrote: > On Fri, 2006-07-14 at 10:10 -0400, Tania Bento wrote: > > Hey, > > > > According to Java's API, setHgap and setVgap do not throw an Illegal > > Argument Exception if hgap or vgap are

[cp-patches] RFA: FlowLayout.java

2006-07-14 Thread Tania Bento
lease comment on and/or approve this patch. Thanks. Tania 2006-07-14 Tania Bento <[EMAIL PROTECTED]> * java/awt/FlowLayout.java (setHgap): Illegal Argument Exception should not be thrown if hgap has a negative value. (setVgap): Illegal Argument Exception

Re: [cp-patches] FYI: Generate name the same way as Sun

2006-07-10 Thread Tania Bento
Hey, based on Robert Schuster's suggestion, I have modified Cursor.java. Could someone kindly approve or comment on this patch, so that I may commit it. On Sat, 2006-07-08 at 09:46 +0200, Robert Schuster wrote: > Hi Tania > > >>+if (type == 0) > >>+ name = "Default Cursor"; > >>+else

Re: [cp-patches] FYI: Generate name the same way as Sun

2006-07-07 Thread Tania Bento
Sorry... Wrong patch. Attached is the good one. On Fri, 2006-07-07 at 16:09 -0400, Tania Bento wrote: > Hey, > > This patch generates the default name the same way as Sun as does. If > someone could please comment on or approve this patch, that would be > great. > > Thanks,

[cp-patches] FYI: Generate name the same way as Sun

2006-07-07 Thread Tania Bento
Hey, This patch generates the default name the same way as Sun as does. If someone could please comment on or approve this patch, that would be great. Thanks, Tania 2006-07-07 Tania Bento * gnu/java/awt/peer/ClasspathFontPeer.java (isLogicalFontName): Return true if name

[cp-patches] RFA: Canvas.java

2006-07-06 Thread Tania Bento
Hey, This patch fixes a Harmony Test that was failing on Classpath. We now generate the canvas name in the same manner as Sun. If someone could please approve/comment on this patch, that would be great. 2006-07-06 Tania Bento <[EMAIL PROTECTED]> * gnu/java/awt/Canva

[cp-patches]: RFA: TextArea and TextComponent fixes

2006-06-30 Thread Tania Bento
Hey, Based on David Gilbert's comments and suggestions, I have made these modifcations. I have also committed mauve tests for these changes. If someone could please approve/comment on this patch, that would be great. Thanks, Tania 2006-06-30 Tania Bento <[EMAIL PROTECTED]>

[cp-patches] RFA: more TextArea.java fixes

2006-06-29 Thread Tania Bento
rove/comment on this patch so that I can commit it. Thanks, Tania 2006-06-29 Tania Bento <[EMAIL PROTECTED]> *java/awt/TextArea.java (TextArea): If text == null, change it to "". (InsertText): Added the case when peer == null. (AppendText): Added th

Re: [cp-patches] RFA: TextArea

2006-06-28 Thread Tania Bento
Sorry, I forgot to mention that this patch also fixes some unexpected exceptions (ie. the exceptions thrown if columns/rows/scrollbarVisibility had an invalid value). Again, this is based on Harmony's TestSuite. On Wed, 2006-06-28 at 13:35 -0400, Tania Bento wrote: > Hey guys, > &

[cp-patches] RFA: TextArea

2006-06-28 Thread Tania Bento
Hey guys, This patch fixes a failing Harmony Test (TextAreaTest.testReplaceText). These changes follow the reference implementation. Can someone please approve and/or comment on this patch. Thanks, Tania 2006-06-28 Tania Bento <[EMAIL PROTECTED]> *java/awt/TextAre

[cp-patches] RFA: Container.java

2006-06-27 Thread Tania Bento
-27 Tania Bento <[EMAIL PROTECTED]> * java/awt/Container.java (applyComponentOrientation): Implemented method. Index: java/awt/Container.java === RCS file: /cvsroot/classpath/classpath/java/awt/Container.

[cp-patches] RFA: Component.java Fix

2006-06-27 Thread Tania Bento
it. Thanks. Cheers, Tania 2006-06-27 Tania Bento <[EMAIL PROTECTED]> * java/awt/Component.java (setComponentOrientation): NPE should not be thrown. Index: java/awt/Component.java === RCS file: /cvsroot/cla

[cp-patches] FYI: Minor changes to List.java

2006-06-26 Thread Tania Bento
n the makeVisible method. Cheers, Tania 2006-06-26 Tania Bento <[EMAIL PROTECTED]> * java/awt/List.java (List): A list should have at least 4 visible rows. (replaceItem): Should throw an ArrayIndexOutOfBoundsException, not an IllegalArgumentException. (

[cp-patches] RFA: TextField

2006-06-23 Thread Tania Bento
to 0. This patch is based on Harmony's testTextFieldString(test.java.awt.TextFieldTest). Could someone please approve this. Thanks. Tania 2006-06-23 Tania Bento <[EMAIL PROTECTED]> * java/awt/TextField.java (TextField): Check if the string passed is nul

[cp-patches] RFA: TextField.java

2006-06-23 Thread Tania Bento
Hey, This patch just checks if the desired column number is valid. If it is invalid, it sets it to 0. This patch is based on Harmony's testFieldInt(test.java.awt.TextFieldTest.java). Could someone please approve this. Thanks. Tania 2006-06-23 Tania Bento <[EMAIL P

[cp-patches] RFA: TextField

2006-06-23 Thread Tania Bento
Hey, The default number of columns a TextField should have is 0, not 1. This change is based on Harmony's testTextField and testGetColumns (test.java.awt.TextFieldTest). Could someone please approve this patch. Thanks. Tania 2006-06-23 Tania Bento <[EMAIL PROTECTED]>

[cp-patches] RFA: Window.java

2006-06-22 Thread Tania Bento
Hey, The invalidate() method should be called within the hid() method of Window.java. This now causes Harmony's testDispse(test.java.awt.WindowRTest) to pass on Classpath. Could someone please approve this patch so that I can commit it. Thanks. Here's the Changelog Entry: 2006-06

[cp-patches] RFA: Container.java

2006-06-22 Thread Tania Bento
n the results of Harmony's WindowTest. Could someone please approve this patch so that I can commit it. Thanks. Here's the changelog entry: 2006-06-22 Tania Bento <[EMAIL PROTECTED]> * java/awt/Container.java: (applyComponentOrientation): Set the ComponentOrientatio

Re: [cp-patches] RFA: JMenu Constructor Regressions

2006-06-21 Thread Tania Bento
s the changelog entry for this change. When someone approves this patch, I'll combine the two changelog entries when I commit it. Thanks. Here's the changelog entry: 2006-06-21 Tania Bento <[EMAIL PROTECTED]> *javax/swing/plaf/basic/BasicPopupMenu.UI.java (popup

[cp-patches] RFA: More JMenu Constructor Regressions

2006-06-20 Thread Tania Bento
patch so that I can commit it. Thanks. Here is the Changelog entry: 2006-06-20 Tania Bento <[EMAIL PROTECTED]> * javax/swing/JMenu.java (remove): An IllegalArgumentException should be thrown if either index < 0 or if index > 0 and there are no menu

Re: [cp-patches] RFA: JMenu Constructor Regressions

2006-06-20 Thread Tania Bento
Sorry, forgot to mention that these specific changes are due to the getPopUpMenu.java mauve test I just committed. Tania On Tue, 2006-06-20 at 16:52 -0400, Tania Bento wrote: > Hey, > > I have written a test for all of JMenu's constructors and found many > constructor regressio

[cp-patches] RFA: JMenu Constructor Regressions

2006-06-20 Thread Tania Bento
Hey, I have written a test for all of JMenu's constructors and found many constructor regressions. This patches fixes all of them. Could someone please approve this patch so that I may commit it. Thanks. Here's the Changelog entry: 2006-06-20 Tania Bento <[EM

[cp-patches] RFA: JMenu Constructor Regressions

2006-06-20 Thread Tania Bento
Hey, This patch fixes more constructor regressions from JMenu's constructor. I have commited a mauve test for this (constructors.java). Again, could someone please approve this patch so that I can commit it. Thanks. Here's the Changelog entry: 2006-06-20 Tania Bento <[EM

[cp-patches] FYI: MetalScrollButton

2006-06-15 Thread Tania Bento
Hey, This is the last of the classes that sets 'focusable' to false. I will be committing this and its mauve test immediately after posting this. Cheers, Tania 2006-06-15 Tania Bento <[EMAIL PROTECTED]> * javax/swing/plaf/metal/MetalS

[cp-patches] FYI: BasicArrowButton

2006-06-15 Thread Tania Bento
Hey, This is another one of the classes that sets 'focusable' to false. I will be committing this and its mauve test immediately after posting this. Cheers, Tania 2006-06-15 Tania Bento <[EMAIL PROTECTED]> * javax/swing/plaf/basic/Basic

[cp-patches] FYI: JRadioButtonMenuItem

2006-06-15 Thread Tania Bento
Hey, This is another one of the classes that sets 'focusable' to false. I will be committing this and its mauve test immediately after posting this. Cheers, Tania 2006-06-15 Tania Bento <[EMAIL PROTECTED]> * javax/swing/JRadioButtonMenuItem.java (JRad

[cp-patches] RFA: JCheckBoxMenuItem

2006-06-15 Thread Tania Bento
Hey, This is one of the classes that sets 'focusable' to false. I will be committing the mauve test soon. Could someone please approve this for me so that I can commit it. Cheers, Tania 2006-06-15 Tania Bento <[EMAIL PROTECTED]> * javax/swing/JCheck

Re: [cp-patches] [cp--patches] RFA: AbstractButton

2006-06-15 Thread Tania Bento
Sorry, changelog should be: 2006-06-15 Tania Bento <[EMAIL PROTECTED]> * javax/swing/AbstractButton.java: (AbstractButton): 'Focusable' should be set to true and not false. On Thu, 2006-06-15 at 13:29 -0400, Tania Bento wrote: > Hey, > > In

[cp-patches] [cp--patches] RFA: AbstractButton

2006-06-15 Thread Tania Bento
onMenuItem, JCheckMenuBoxItem, BasicArrowButton, and MetalScrollButton). I will be posting these classpath patches and mauve tests soon. Can someone please approve this modication to AbstractButton so that I can commit it. Cheers, Tania 2006-06-15 Tania Bento <[EMAIL PROTECTED]>

Re: [cp-patches] RFC: AbstractButton

2006-06-14 Thread Tania Bento
Again, thanks Tom. Its been committed. On Tue, 2006-06-13 at 12:09 -0400, Thomas Fitzsimmons wrote: > Tania Bento wrote: > > Hey, > > > > In the constructor, focusable should be set to false and not true. > > Could someone please approve and commit this for me. Thank

Re: [cp-patches] Re: [cp-pathes] RFC: JMenuItem

2006-06-14 Thread Tania Bento
Thanks Tom. It's been committed. On Tue, 2006-06-13 at 12:07 -0400, Thomas Fitzsimmons wrote: > Tania Bento wrote: > > Sorry... wrong patch. Here's the right one. > > > > On Tue, 2006-06-13 at 11:52 -0400, Tania Bento wrote: > >> Hey, > >> > &

Re: [cp-patches] RFC: JCheckBoxMenuItem

2006-06-14 Thread Tania Bento
Thanks Tom. I've just committed it. On Tue, 2006-06-13 at 12:07 -0400, Thomas Fitzsimmons wrote: > Tania Bento wrote: > > Hey, > > > > Before setting the value of the button's selected property to true, i > > added a check that ensures that state first be se

[cp-patches] RFC: AbstractButton

2006-06-13 Thread Tania Bento
Hey, In the constructor, focusable should be set to false and not true. Could someone please approve and commit this for me. Thanks a bunch. 2006-06-13 Tania Bento <[EMAIL PROTECTED]> * javax/swing/AbstractButton.java (AbstractButton): Set focusable to false, no

[cp-patches] Re: [cp-pathes] RFC: JMenuItem

2006-06-13 Thread Tania Bento
Sorry... wrong patch. Here's the right one. On Tue, 2006-06-13 at 11:52 -0400, Tania Bento wrote: > Hey, > > Changed the horizontal alignment from JButton.LEFT to JButton.LEADING. > Could someone please approve this and commit it for me. Thanks. > > 2006-06-13 Tania B

[cp-patches] [cp-pathes] RFC: JMenuItem

2006-06-13 Thread Tania Bento
Hey, Changed the horizontal alignment from JButton.LEFT to JButton.LEADING. Could someone please approve this and commit it for me. Thanks. 2006-06-13 Tania Bento <[EMAIL PROTECTED]> * javax/swing/JMenuItem.java (init): Changed horizontalAlignment from JButton.L

[cp-patches] RFC: JCheckBoxMenuItem

2006-06-13 Thread Tania Bento
Hey, Before setting the value of the button's selected property to true, i added a check that ensures that state first be set to true. 2006-06-13 Tania Bento <[EMAIL PROTECTED]> * classpath/javax/swing/JCheckBoxMenuItem.java (JCheckBoxMenuItem): Added check to set t