Re: [cp-patches] What's about bug 36560 (Error parsing zip file...)?

2010-07-15 Thread Daniel Noll
2010/7/16 Ivan Maidanski : > Hello Daniel! > > So, which behavior should we reflect in Classpath (fail fast or fail on > reading encrypted entry stream)? I guess a switch to failing fast in JDK6 > wasn't intentional. Fail on reading an encrypted stream is much more useful - the reason is that yo

Re: [cp-patches] What's about bug 36560 (Error parsing zip file...)?

2010-07-15 Thread Ivan Maidanski
Hello Daniel! So, which behavior should we reflect in Classpath (fail fast or fail on reading encrypted entry stream)? I guess a switch to failing fast in JDK6 wasn't intentional. Wed, 14 Jul 2010 17:11:14 +1000 Daniel Noll : > On Wed, Jul 14, 2010 at 16:50, Jeroen Frijters wrote: > > Hello I

Re: [cp-patches] What's about bug 36560 (Error parsing zip file...)?

2010-07-15 Thread Daniel Noll
On Wed, Jul 14, 2010 at 16:50, Jeroen Frijters wrote: > Hello Ivan, > > The JDK also fails to open zip files that contain encrypted entries. This was a regression in 1.6.0. 1.5.x and below worked as you would expect. It has been filed to Sun: http://bugs.sun.com/view_bug.do?bug_id=6502004 No

Re: [cp-patches] What's about bug 36560 (Error parsing zip file...)?

2010-07-13 Thread Jeroen Frijters
Jeroen Frijters > Subject: Re[2]: [cp-patches] What's about bug 36560 (Error parsing zip > file...)? > > Hello, Andrew and Jeroen! > > The patched applied to InflaterHuffmanTree.java is ok. > But the patch for ZipFile isn't - you just reject any zip file that > co

Re: [cp-patches] What's about bug 36560 (Error parsing zip file...)?

2010-07-13 Thread Ivan Maidanski
hrow new DataFormatException("incomplete dynamic bit lengths tree"); > > > > /* Now create and fill the extra tables from longest to shortest > > * bit len. This way the sub trees will be aligned. > > > > > >> -Original Message- >

Re: [cp-patches] What's about bug 36560 (Error parsing zip file...)?

2010-07-13 Thread Andrew John Hughes
s tree"); > >     /* Now create and fill the extra tables from longest to shortest >      * bit len.  This way the sub trees will be aligned. > > >> -Original Message- >> From: classpath-patches-boun...@gnu.org [mailto:classpath-patches- >> boun...@gnu.org] O

Re: [cp-patches] What's about bug 36560 (Error parsing zip file...)?

2010-07-13 Thread Jeroen Frijters
> To: classpath-patches > Cc: Daniel Noll; Andrew John Hughes > Subject: [cp-patches] What's about bug 36560 (Error parsing zip > file...)? > > Hello! > > Andrew - > could you apply the proposed patch > (http://gcc.gnu.org/bugzilla/attachment.cgi?id=1868

[cp-patches] What's about bug 36560 (Error parsing zip file...)?

2010-06-28 Thread Ivan Maidanski
Hello! Andrew - could you apply the proposed patch (http://gcc.gnu.org/bugzilla/attachment.cgi?id=18682&action=view) and close bug 36560? I can't immediately propose the test case for this bug but I've discovered this issue when tried to use Classpath Inflater/InflaterInputStream with OpenJDK