Re: [cp-patches] Patch: Container fix

2006-03-15 Thread Thomas Fitzsimmons
On Wed, 2006-03-15 at 11:10 -0500, Lillian Angel wrote: > locate(...) should not ignore invisible components. I have committed a > mauve test for this. I added a lot more documentation to all the methods > listed. The new documentation seems to be cut-n-pasted from Sun's javadocs. Please revert th

Re: [cp-patches] Patch: Container fix

2006-03-15 Thread Lillian Angel
On Wed, 2006-03-15 at 11:10 -0500, Lillian Angel wrote: > getComponentAt needs special handling for lightweight components. I am > working on this as well. Done. 2006-03-15 Lillian Angel <[EMAIL PROTECTED]> * java/awt/Container.java (getComponentAt): Fixed mistake in comments.

[cp-patches] Patch: Container fix

2006-03-15 Thread Lillian Angel
locate(...) should not ignore invisible components. I have committed a mauve test for this. I added a lot more documentation to all the methods listed. Also, I removed findComponentForMouseEvent because it was package-private and never used. getComponentAt needs special handling for lightweight co

Re: [cp-patches] Patch: Container fix

2006-03-15 Thread Lillian Angel
On Wed, 2006-03-15 at 12:44 +0100, Roman Kennke wrote: > Hi Lillian, > > This change in Container.addImpl causes massive painting problems in > Swing. Could you reconsider this? It might be the case that we only need > a if(isShowing() { repaint... } instead of completely removing the > repaint.

Re: [cp-patches] Patch: Container fix

2006-03-15 Thread Roman Kennke
Hi Lillian, This change in Container.addImpl causes massive painting problems in Swing. Could you reconsider this? It might be the case that we only need a if(isShowing() { repaint... } instead of completely removing the repaint. Note that I am not saying that you are wrong. If it turns out that

[cp-patches] Patch: Container fix

2006-03-14 Thread Lillian Angel
Sun doesn't call repaint after each component is added to a container. I will commit a mauve test for this. 2006-03-14 Lillian Angel <[EMAIL PROTECTED]> * java/awt/Container.java (addImpl): Removed call to repaint. No need to repaint here. Index: java/awt/Container.java ===

[cp-patches] Patch: Container fix

2006-02-24 Thread Lillian Angel
Paint in Container repainted the heavyweights (all the time) in case they were erased when the background was cleared. I added a boolean to keep track if the background was cleared or not. If it was not, then we should not have to repaint the heavyweights. I noticed some weird double painting in

Re: [cp-patches] Patch: Container fix

2005-11-11 Thread Lillian Angel
> This looks fine to me. > > Tom Committed. Thanks. ___ Classpath-patches mailing list Classpath-patches@gnu.org http://lists.gnu.org/mailman/listinfo/classpath-patches

[cp-patches]: Patch: Container fix

2005-09-16 Thread Lillian Angel
2005-09-16 Lillian Angel <[EMAIL PROTECTED]> Fixes Bug #22610 * java/awt/Container.java (remove): Removed component listeners from the component being removed. This was a problem if that same component that was removed was added to a new component. Index: