Re: [cp-patches] [Patch] Improve/fix gnu.java.net.LineInputStream...

2005-09-13 Thread Chris Burdess
David Daney wrote: gnu.java.net.LineInputStream has at least one bug in it, but think its whole approach is incorrect. First the bug: len = in.available(); len = (len MIN_LENGTH) ? MIN_LENGTH : len; I think the idea was to read all available bytes into its buffer

Re: [cp-patches] [Patch] Improve/fix gnu.java.net.LineInputStream...

2005-09-13 Thread David Daney
Chris Burdess wrote: David Daney wrote: gnu.java.net.LineInputStream has at least one bug in it, but think its whole approach is incorrect. First the bug: len = in.available(); len = (len MIN_LENGTH) ? MIN_LENGTH : len; I think the idea was to read all available

Re: [cp-patches] [Patch] Improve/fix gnu.java.net.LineInputStream...

2005-09-13 Thread Tom Tromey
Chris == Chris Burdess [EMAIL PROTECTED] writes: I did take the liberty of adding my own micro-optimization, in that if the encoding is US-ASCII, we can skip using String's character encoding system and just request hibyte of 0. I did this because a year ago with libgcj-3.4.3 we were

Re: [cp-patches] [Patch] Improve/fix gnu.java.net.LineInputStream...

2005-09-13 Thread David Daney
Tom Tromey wrote: Chris == Chris Burdess [EMAIL PROTECTED] writes: I did take the liberty of adding my own micro-optimization, in that if the encoding is US-ASCII, we can skip using String's character encoding system and just request hibyte of 0. I did this because a year ago with

[cp-patches] [Patch] Improve/fix gnu.java.net.LineInputStream...

2005-09-12 Thread David Daney
gnu.java.net.LineInputStream has at least one bug in it, but think its whole approach is incorrect. First the bug: len = in.available(); len = (len MIN_LENGTH) ? MIN_LENGTH : len; I think the idea was to read all available bytes into its buffer (but not more that