Re: [cp-patches] [RFA] Fix JDWP Values

2007-03-09 Thread Kyle Galloway
Keith Seitz wrote: [my apologies for the delay in getting back to you] Kyle Galloway wrote: Keith Seitz wrote: > I see that this method can throw InvalidObjectException if the object ID is not known by the ID manager. How is JdwpInternalErrorException thrown? This gets thrown by JdwpString.

Re: [cp-patches] [RFA] Fix JDWP Values

2007-03-09 Thread Keith Seitz
[my apologies for the delay in getting back to you] Kyle Galloway wrote: Keith Seitz wrote: > I see that this method can throw InvalidObjectException if the object ID is not known by the ID manager. How is JdwpInternalErrorException thrown? This gets thrown by JdwpString.readString(). Ah..

Re: [cp-patches] [RFA] Fix JDWP Values

2007-03-08 Thread Tom Tromey
> "Kyle" == Kyle Galloway <[EMAIL PROTECTED]> writes: >> Missing a break for these cases. Did the compiler not output any >> warnings? Please double-check. Kyle> Yeah, I must have missed the warnings, classpath just has so many of Kyle> them (1000+) it's hard to see if they pertain to you. I

Re: [cp-patches] [RFA] Fix JDWP Values

2007-03-05 Thread Keith Seitz
Kyle Galloway wrote: Questions/Comments/Concerns? I like it. Just some minor nits (some cosmetic, even). Index: gnu/classpath/jdwp/value/Value.java === RCS file: gnu/classpath/jdwp/value/Value.java diff -N gnu/classpath/jdwp/val