[cp-patches] FYI: BasicListUI fixlet

2006-08-08 Thread Roman Kennke
The keyboard focus must be explicitly requested now for Swing components. Done here for JList. 2006-08-05 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicListUI.java (MouseInputHandler.mousePressed): Request focus on list component. /Roman Index:

[cp-patches] FYI: BasicListUI keyboard actions

2006-06-26 Thread Roman Kennke
This fixes BasicListUI.installKeyboardActions to fit with the InputMap/ActionMap architecture, and implements the missing uninstallKeyboardActions. 2006-06-26 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicListUI.java (installKeyboardActions): Rewritten to fit

[cp-patches] FYI: BasicListUI fix

2006-01-28 Thread Roman Kennke
This patch corrects the calculation of the cell width for VERTICAL layoutOrientation in JLists and greatly improves performance of JList painting by saving most updateLayoutState() calls from within paint(). 2006-01-28 Roman Kennke [EMAIL PROTECTED] *

[cp-patches] FYI: BasicListUI fixlet

2006-01-10 Thread Roman Kennke
Hi there, this makes the BasicListUI update its layout also when the list itself has been invalidated since the last update. 2006-01-10 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicListUI.java (maybeUpdateLayoutState): Also update the layout state, if the

[cp-patches] FYI: BasicListUI API doc fixlet

2006-01-10 Thread Roman Kennke
I added a @since to BasicListUI.playSound. 2006-01-10 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicLookAndFeel.java (playSound): Added @since 1.4 to the API docs. /Roman Index: javax/swing/plaf/basic/BasicLookAndFeel.java

Re: [cp-patches] FYI: BasicListUI fix

2006-01-05 Thread Mark Wielaard
Hi, On Wed, 2006-01-04 at 21:40 +, Roman Kennke wrote: 2006-01-04 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicListUI.java (locationToIndex): Added FIXME about getVisibleRowCount() usage. Adjusted iteration to not use visibleRowCount and instead

[cp-patches] FYI: BasicListUI fix

2006-01-04 Thread Roman Kennke
This fixes some exception in the BasicListUI. Thanks to Christopher for discussing this on IRC. 2006-01-04 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicListUI.java (locationToIndex): Added FIXME about getVisibleRowCount() usage. Adjusted iteration to not

[cp-patches] FYI: BasicListUI preferredSize fix

2006-01-04 Thread Roman Kennke
Hi, I have rewritten the BasicListUI.getPreferredSize() method so that it does what the specs say. This is one of the very few methods that are exceptionally well documented :-) 2006-01-04 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicListUI.java

[cp-patches] FYI: BasicListUI fix

2006-01-03 Thread Roman Kennke
This patch fixes JList rendering and size calculations for wrapping JLists. 2006-01-03 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicListUI.java (locationToIndex): Special case for when variable cell heights are possible. (cellHeights is used instead of

Re: [cp-patches] FYI: BasicListUI fix

2006-01-03 Thread Chris Lansdown
Roman, The loops loop like they will throw an OOB exception if the mouse click is below the last item, if there are too few items. Am I missing something? Thanks, Chris Lansdown On 01/03, Roman Kennke wrote: This patch fixes JList rendering and size calculations for wrapping JLists.

[cp-patches] FYI: BasicListUI fix

2005-11-15 Thread Roman Kennke
My last 'fix' for BasicListUI introduced some new misbehaviour in JList rendering. This should be fixed by this patch. 2005-11-15 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicListUI.java Fixed API docs all over to better explain the changed (but correct)

Re: [cp-patches] FYI: BasicListUI

2005-11-11 Thread Lillian Angel
On Fri, 2005-11-11 at 16:09 -0500, Lillian Angel wrote: On Thu, 2005-11-10 at 20:35 +, Roman Kennke wrote: Hi, I fixed some buggies in the BasicListUI. The fixed cell height and width should now correctly be recognized. In addition to that I optimized the painting so that only the

[cp-patches] FYI: BasicListUI

2005-11-10 Thread Roman Kennke
Hi, I fixed some buggies in the BasicListUI. The fixed cell height and width should now correctly be recognized. In addition to that I optimized the painting so that only the cells within the clip bounds are painted. This greatly improved performance when scrolling. This is really smooth now.

[cp-patches] FYI: BasicListUI fixlet

2005-07-28 Thread Anthony Balkissoon
Changed KeyEvent.isShiftDown() and KeyEvent.isControlDown() to comparisons between KeyEvent.getModifiers() and InputEvent.SHIFT_MASK and CTRL_MASK. Also switched the order of shift and control handling in MouseInputHandler.mousePressed to correspond to the JDK's behaviour. Patch attached.

[cp-patches] FYI: BasicListUI PAGE UP and PAGE DOWN implemented

2005-07-28 Thread Anthony Balkissoon
Implemented {,SHIFT-} PAGE {UP,DOWN} key action in BasicListUI. Also had to make a small correction to JViewport's scrollRectToVisible that PAGE DOWN revealed where we were off by 1 pixel. Patch attached. 2005-07-28 Anthony Balkissoon [EMAIL PROTECTED] * javax/swing/JViewport.java:

[cp-patches] FYI: BasicListUI fixlet

2005-07-27 Thread Anthony Balkissoon
I commited this patch which makes sure that after a change in the selection model via the mouse or keyboard, we make sure that the new lead selection index is visible. Note: you can only see this work after JViewport.scrollRectToVisible() is implemented (I submitted this patch for approval

[cp-patches] FYI: BasicListUI fixlet and BasicLookAndFeel addition

2005-07-22 Thread Anthony Balkissoon
Added this small fixlet to BasicListUI (and corresponding default to BasicLookAndFeel) so that the most recently updated cell in a JList has a border around it. Patch attached. 2005-07-22 Anthony Balkissoon [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicListUI.java: (paintCell): Set