[cp-patches] FYI: BasicTextUI fixlet

2006-08-13 Thread Roman Kennke
In BasicTextUI we need to unregister the document handler in order to clean up correctly on UI change. 2006-08-13 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicTextUI.java (uninstallListeners): Unregister document listener. /Roman Index:

[cp-patches] FYI: BasicTextUI fixlet

2006-06-03 Thread Roman Kennke
This fixes an NPE in BasicTextUI, seen with Protege. 2006-06-03 Roman Kennke [EMAIL PROTECTED] PR 27418 * javax/swing/plaf/basic/BasicTextUI.java (damageRange): Added null check to avoid NPE. /Roman -- “Improvement makes straight roads, but the crooked roads, without

[cp-patches] FYI: BasicTextUI fixlet

2006-02-16 Thread Roman Kennke
This sligthly changes the ordering in which the BasicTextUI installs its bits on text components. I once had a problem here with some component having a null font while building up its View, resulting in an NPE. 2006-02-16 Roman Kennke [EMAIL PROTECTED] *

[cp-patches] FYI: BasicTextUI fixlet

2006-02-09 Thread Roman Kennke
While hacking on text stuff and observing Sun's behaviour I noticed that View.setSize() is always called before paint() by the RootView. That makes sense, that makes sure that the layout of a view hierarchy is updated correctly before painting anything. 2006-02-09 Roman Kennke [EMAIL PROTECTED]

[cp-patches] FYI: BasicTextUI fixlet

2006-01-31 Thread Roman Kennke
The method BasicTextUI.createKeymap() used to store a KeyBinding[] into the UIManager focusInputMap for the text component. This is certainly wrong. If at all the KeyBinding[] should be stored as prefix + .bindings. However I think that this method should not even do this. AFAICS no Swing class

[cp-patches] FYI: BasicTextUI fixlet

2005-11-14 Thread Roman Kennke
In the BasicTextUI.propertyChange() we fetch the new value of the editable flag from the textcomponent itself. This would not work because when the property event is fired, the component still has the old value. This should fix the problem in the TextFieldDemo where changing the editable flag does

[cp-patches] FYI: BasicTextUI fixlet

2005-11-09 Thread Roman Kennke
I committed this little fixlet for the BasicTextUI. This should solve the problem with textfields where the text is slightly off when displaying right-aligned. 2005-11-09 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicTextUI.java (getVisibleEditorRect): Correctly

Re: [cp-patches] FYI: BasicTextUI fixlet

2005-11-09 Thread David Gilbert
Oddly, this seems to also have fixed a problem with the vertical alignment of text in editable JComboBoxes under the MetalLookAndFeel. I'm very happy about that... Regards, Dave Roman Kennke wrote: I committed this little fixlet for the BasicTextUI. This should solve the problem with

Re: [cp-patches] FYI: BasicTextUI fixlet

2005-11-09 Thread David Gilbert
I looked more closely at the patch, and it's not so odd that this problem is fixed. Thanks Roman! Regards, Dave David Gilbert wrote: Oddly, this seems to also have fixed a problem with the vertical alignment of text in editable JComboBoxes under the MetalLookAndFeel. I'm very happy about