Re: [cp-patches] FYI: JComponent fixes

2006-06-27 Thread Mark Wielaard
On Mon, 2006-06-26 at 11:42 +0200, Roman Kennke wrote: Hiyo, Roman 1. All PropertyChangeEvent methods have been removed. According to JAPI, two of the firePropertyChange methods were public in this class, but are protected in the superclass. So, this part of the change should be

Re: [cp-patches] FYI: JComponent fixes

2006-06-26 Thread Roman Kennke
Hiyo, Roman 1. All PropertyChangeEvent methods have been removed. According to JAPI, two of the firePropertyChange methods were public in this class, but are protected in the superclass. So, this part of the change should be reverted. Roman

Re: [cp-patches] FYI: JComponent fixes

2006-06-23 Thread Tom Tromey
Roman == Roman Kennke [EMAIL PROTECTED] writes: Roman 1. All PropertyChangeEvent methods have been removed. According to JAPI, two of the firePropertyChange methods were public in this class, but are protected in the superclass. So, this part of the change should be reverted. Roman

[cp-patches] FYI: JComponent fixes

2006-06-22 Thread Roman Kennke
3 fixes for JComponent: 1. All PropertyChangeEvent methods have been removed. They are all handled in Component anyway and only called super. However, there was one method addPropertyChangeListener(String,PropertyChangeListener) which did not call super, but instead registered the listener to the

[cp-patches] FYI: JComponent fixes

2006-02-27 Thread Roman Kennke
This fixes some smaller issues in JComponent. The visibleRect check from repaint() is now moved to the RepaintManager.addDirtyRegion (just in case, somebody calls this method directly instead of repaint()). Also, I changed the getVisibleRect() method back to creating a new Rectangle object instead

Re: [cp-patches] FYI: JComponent fixes

2006-02-16 Thread Roman Kennke
Hi Audrius, Am Mittwoch, den 15.02.2006, 23:26 +0100 schrieb Audrius Meskauskas: Roman Kennke wrote: Index: javax/swing/JComponent.java @@ -2206,12 +2205,8 @@ */ public void repaint(long tm, int x, int y, int width, int height) { -Rectangle dirty = new Rectangle(x,

Re: [cp-patches] FYI: JComponent fixes

2006-02-16 Thread Roman Kennke
Hi Audrius, The repaint() change has caused your problems with JTable and performance. I reverted this. I still think that this should be done in the RepaintManager (if it isn't yet), because some class (user application) may call RepaintManager.addDirtyRegion() directly, bypassing repaint() and

Re: [cp-patches] FYI: JComponent fixes: New regressions.

2006-02-16 Thread Audrius Meskauskas
Now the bottom close button disappears in the Swing Demo after any attempt to expand a tree node or resize the table column. Listen, it may sound nasty, but PLEASE USE SWING ACTIVITY BOARD AND MAUVE TESTS TO CHECK THE EFFECTS of the performance fixes, optimizations and removing unnecessary

Re: [cp-patches] FYI: JComponent fixes: New regressions.

2006-02-16 Thread Michael Koch
On Thu, Feb 16, 2006 at 01:49:47PM +0100, Audrius Meskauskas wrote: Now the bottom close button disappears in the Swing Demo after any attempt to expand a tree node or resize the table column. Listen, it may sound nasty, but PLEASE USE SWING ACTIVITY BOARD AND MAUVE TESTS TO CHECK THE

Re: [cp-patches] FYI: JComponent fixes: New regressions.

2006-02-16 Thread Roman Kennke
Hi Audrius, Am Donnerstag, den 16.02.2006, 13:49 +0100 schrieb Audrius Meskauskas: Now the bottom close button disappears in the Swing Demo after any attempt to expand a tree node or resize the table column. Thank you for pointing this out. I'll look at it now. Listen, it may sound nasty,

Re: [cp-patches] FYI: JComponent fixes: New regressions.

2006-02-16 Thread Roman Kennke
Hi Audrius, Am Donnerstag, den 16.02.2006, 13:49 +0100 schrieb Audrius Meskauskas: Now the bottom close button disappears in the Swing Demo after any attempt to expand a tree node or resize the table column. It seems that we have problems with the blit scroll mode in JViewport. I changed it

[cp-patches] FYI: JComponent fixes

2006-02-15 Thread Roman Kennke
This fixes a small but annoying painting issue that happens if some components are invisible. Also, I removed some useless 'optimization' from repaint() that caused unnecessary creation of Rectangle objects. 2006-02-15 Roman Kennke [EMAIL PROTECTED] * javax/swing/JComponent.java

Re: [cp-patches] FYI: JComponent fixes

2006-02-15 Thread Audrius Meskauskas
This introduces regressions on the JTable editing that starts working again after reverting. Also, the painting seems slower and sometimes I observe the window parts painted larger than expected. Roman Kennke wrote: This fixes a small but annoying painting issue that happens if some

Re: [cp-patches] FYI: JComponent fixes

2006-02-15 Thread Audrius Meskauskas
Roman Kennke wrote: Index: javax/swing/JComponent.java @@ -2206,12 +2205,8 @@ */ public void repaint(long tm, int x, int y, int width, int height) { -Rectangle dirty = new Rectangle(x, y, width, height); -Rectangle vis = getVisibleRect(); -dirty =

[cp-patches] FYI: JComponent fixes

2005-10-07 Thread Roman Kennke
Hi, I fixed some things in JComponent. Most importantly I added some support for AncestorEvents. 2005-10-07 Roman Kennke [EMAIL PROTECTED] * javax/swing/JComponent.java (paint): Call paintBorder before paintChildren. (reshape): Fire AncestorEvent if position has