Re: [cp-patches] FYI: JTabbedPane fixes

2006-07-26 Thread Robert Schuster
Ok, I revert this and look for another way to resolve this. Thanks Mark for finding this! @Roman: The doc for setSelectedComponent() says it does the hiding and showing of the old and new selected component. However I saw no code in that method which does it. That is why I thought it should be

[cp-patches] FYI: JTabbedPane fixes

2006-07-25 Thread Robert Schuster
Hi, this patch fixes some minor JTabbedPane issues. 2006-07-25 Robert Schuster [EMAIL PROTECTED] * javax/swing/JTabbedPane.java: (remove(Component)): Rewritten. (setSelectedIndex): Implemented updating of component visibility state. cya Robert Index:

Re: [cp-patches] FYI: JTabbedPane fixes

2006-07-25 Thread Mark Wielaard
Hi Robert, On Tue, 2006-07-25 at 21:21 +0200, Robert Schuster wrote: Hi, this patch fixes some minor JTabbedPane issues. 2006-07-25 Robert Schuster [EMAIL PROTECTED] * javax/swing/JTabbedPane.java: (remove(Component)): Rewritten. (setSelectedIndex): Implemented

[cp-patches] FYI: JTabbedPane fixes

2006-03-30 Thread Roman Kennke
This patch fixes a couple of issues in the JTabbedPane: - in removeTabAt, the selection needs to be adjusted, so that it doesn't point to an illegal tab afterwards. - not only the tab must be removed, but also the component that is displayed by the tab. This has been a potential memory leak (no

Re: [cp-patches] FYI: JTabbedPane fixes

2006-03-30 Thread Mark Wielaard
Hi Roman, On Thu, 2006-03-30 at 14:18 +0200, Roman Kennke wrote: +int selectedIndex = getSelectedIndex(); +System.err.println(index: + index); +System.err.println(selectedIndex: + selectedIndex); +if (selectedIndex = index) + setSelectedIndex(selectedIndex - 1); You

Re: [cp-patches] FYI: JTabbedPane fixes

2006-03-30 Thread Roman Kennke
Hi Mark, On Thu, 2006-03-30 at 14:18 +0200, Roman Kennke wrote: +int selectedIndex = getSelectedIndex(); +System.err.println(index: + index); +System.err.println(selectedIndex: + selectedIndex); +if (selectedIndex = index) + setSelectedIndex(selectedIndex - 1);