Hi,
We continue (but don't conclude) the JTree memory leak story...
This commit implements a temporary fix for the memory leak, as well as a
patch from Roman that starts fixing the root problem (however our
javax.swing.tree.DefaultTreeModel isn't firing events properly yet).
Cheers,
Francis
20
This fixes the JTree layout, which has been broken for some weeks. These
fixes are driven and backed up by the Harmony testsuite. We now pass all
tests for AbstractLayoutCache and most tests for
VariableHeightLayoutCache (most remaining fails are mostly bogus tests
or weird unrealistic corner cases
The method JTree.isRowSelected() should delegate directly to the
TreeSelectionModel method with the same name, rather than going through
getPathForRow() and isPathSelected() as a Mauve test shows that
accompanies this fix.
2006-10-09 Roman Kennke <[EMAIL PROTECTED]>
* javax/swing/JTree.
This fixes the JTree editing bug that was introduced by my latest JTree
work, which was that after editing the JTree node didn't receive the new
value. Together with that come a couple of cosmetic and compatibility
changes.
2006-08-16 Roman Kennke <[EMAIL PROTECTED]>
PR 28750
Surely, RI shows that the tree scrolls only in one direction, down.
Roman Kennke wrote:
This fixes unit-scrolling and implements block scrolling for JTree. It
also fixes a minor glitch in VariableHeightLayoutCache.
2006-08-13 Roman Kennke <[EMAIL PROTECTED]>
* javax/swing/JTree.java
This fixes unit-scrolling and implements block scrolling for JTree. It
also fixes a minor glitch in VariableHeightLayoutCache.
2006-08-13 Roman Kennke <[EMAIL PROTECTED]>
* javax/swing/JTree.java
(getScrollableUnitIncrement): Fixed direction.
(getScrollableBlockIncreme
hello Mark,
On Wednesday 09 August 2006 08:29, Mark Wielaard wrote:
> ...
> This are most likely last only code changes on the release branch. I am
> looking at the BigInteger fixes from Raif, but those haven't hit CVS
> yet.
these, and the ResourceBundle one, can wait until the next release. tw
Hi Roman,
On Tue, 2006-08-08 at 14:10 +0200, Roman Kennke wrote:
> This fixes a regression in BasicTreeUI and reenables keyboard handling
> for JTree.
Thanks again for this regression fix. Added together with the focus
request patches for list and table to the release and generics branch.
This
This fixes a regression in BasicTreeUI and reenables keyboard handling
for JTree.
- The BasicTreeUI must requestFocus() on the JTree when a mouse click
occurs. Lightweight components are no longer requestFocus()ed automatically.
- The BasicMenuBarUI must store its ActionMap in MenuBar.actionMap
On Tue, 2006-08-01 at 16:46 +0200, Roman Kennke wrote:
> This fixes a regression in JTree/BasicTreeUI as pointed out in
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28534 .
>
> A mauve test for the regression has also been committed. Please merge
> this to the release branch.
Thanks for fixing
This fixes a regression in JTree/BasicTreeUI as pointed out in
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28534 .
A mauve test for the regression has also been committed. Please merge
this to the release branch.
2006-07-31 Roman Kennke <[EMAIL PROTECTED]>
PR 28534
* javax/
Hi Mark,
Am Dienstag, den 06.06.2006, 22:34 +0200 schrieb Mark Wielaard:
> Hi Roman,
>
> On Tue, 2006-06-06 at 17:35 +0200, Roman Kennke wrote:
> > 2006-06-06 Roman Kennke <[EMAIL PROTECTED]>
> >
> > PR 27651
> > * javax/swing/JTree.java
> > (JTree(TreeModel)): Call upda
Hi Roman,
On Tue, 2006-06-06 at 17:35 +0200, Roman Kennke wrote:
> 2006-06-06 Roman Kennke <[EMAIL PROTECTED]>
>
> PR 27651
> * javax/swing/JTree.java
> (JTree(TreeModel)): Call updateUI() before setModel().
> (setModel): Don't call updateUI here.
After this pat
This fixes the JTree bug with OpenJump. We simply shouldn't call
updateUI() from within setModel(). This causes a big re-setup of the
JTree, including some messing around with the model, which ends up
installing the wrong nodes, thus leading to the CCE reported in
http://gcc.gnu.org/bugzilla/show_b
This path fixes problems that were observed whey hiding/showing the tree
root node while the tree is displayed. It also extends the tree demo to
demonstrate the root node visibility changes.
2006-04-27 Audrius Meskauskas <[EMAIL PROTECTED]>
* examples/gnu/classpath/examples/swing/TreeDemo
The newly added tree node was not always immediately visible. I found
that our Demo is calling tree.repaint() that is not sufficient for the
Sun's implementation as well. The DefaultTreeModel.reload should be
called if we add new nodes with DefaultMutableTreeNode.add. In the past,
one of my fri
On Tue, 2006-04-25 at 20:47 +0200, Audrius Meskauskas wrote:
> Lillian Angel wrote:
>
> >Sorry for sending another email :( Here are all the problems I see with
> >the swing tree demo:
> >
> >- Every time you click new element, the tree should be repainted
> >instantly to see the new element. This
Lillian Angel wrote:
Sorry for sending another email :( Here are all the problems I see with
the swing tree demo:
- Every time you click new element, the tree should be repainted
instantly to see the new element. This happens when you add an element
to an expanded directory.
I am not sure if
I noticed that the control icons are painted behind the lines drawn for
the tree. I ran into this problem when working on BasicTreeUI. You need
to make sure all the lines are painted before painting the control
icons. It does not work if you try to paint both simulataneously.
Let me know if you ne
On Tue, 2006-04-25 at 10:20 -0400, Lillian Angel wrote:
> On Tue, 2006-04-25 at 10:19 -0400, Lillian Angel wrote:
> > I noticed that the control icons are painted behind the lines drawn for
> > the tree. I ran into this problem when working on BasicTreeUI. You need
> > to make sure all the lines ar
It was discovered that JTree multiple element selection is currently not
working as expected. This path fixes the tree ability to select multiple
nodes, if permitted.
2006-04-23 Audrius Meskauskas <[EMAIL PROTECTED]>
* examples/gnu/classpath/examples/swing/TreeDemo.java:
(createContent
This patch contains several fixes, maing the tree editing to work better
with the layout cache.
2006-04-20 Audrius Meskauskas <[EMAIL PROTECTED]>
* javax/swing/plaf/basic/BasicTreeUI.java
(finish): Invalidate path bounds.
(getMaxHeight): Set the row height to the layout cache.
(st
This should make possible to invoke the tree edting actions in the same
way as it is done by Sun:
1. Triple mouse click, or
2. Click on the selected node and no more mouse clicks for at least
about (on my impression) 800 ms.
2006-01-26 Audrius Meskauskas <[EMAIL PROTECTED]>
* javax/swing
A few NPEs were being raised after the most recent changes.
2005-10-06 Lillian Angel <[EMAIL PROTECTED]>
* javax/swing/plaf/basic/BasicTreeUI.java
(startEditing): Should always change the bounds, whenever
we start editing.
(paintRow): Fixed location where editing
The click-area for a leaf was slightly off. Fixed.
2005-10-06 Lillian Angel <[EMAIL PROTECTED]>
* javax/swing/plaf/basic/BasicTreeUI.java
(mousePressed): Shouldn't change x location for leaf.
On Wed, 2005-10-05 at 17:49 -0400, Lillian Angel wrote:
> Small fix. Added in a comm
Small fix. Added in a comment as a reminder to fix last bit of painting
problem.
2005-10-05 Lillian Angel <[EMAIL PROTECTED]>
* javax/swing/plaf/basic/BasicTreeUI.java
(paintRow): Fixed indentation.
(updateCurrentVisiblePath): Added FIXME
comment.
On Wed, 2005
Made a slight error, this is now fixed.
2005-09-26 Lillian Angel <[EMAIL PROTECTED]>
* javax/swing/ToolTipManager.java
(showTip): validating of toolTipWindow should not have been
removed.
On Tue, 2005-09-27 at 11:09 -0400, Lillian Angel wrote:
> Fixed validating of Too
2005-09-02 Lillian Angel <[EMAIL PROTECTED]>
* javax/swing/plaf/basic/BasicTreeUI.java
(mousepressed): Fixed, so that clicking on control icon will not
start editing.
On Fri, 2005-09-02 at 14:00 -0400, Lillian Angel wrote:
> JTree editing is complete and key handling is
Accidently committed the change to DefaultCellEditor. I committed the
change.
2005-08-24 Lillian Angel <[EMAIL PROTECTED]>
* javax/swing/DefaultCellEditor.java
(isCellEditable): Reversed last changes.
On Wed, 2005-08-24 at 16:36 -0400, Lillian Angel wrote:
> Still working on
Another fix.. last one, I hope.
2005-07-06 Lillian Angel <[EMAIL PROTECTED]>
* javax/swing/plaf/basic/BasicTreeUI.java
(getPathForRow): took out redundant code.
___
Classpath-patches mailing list
Classpath-patches@gnu.org
http://li
31 matches
Mail list logo
