Re: [cp-patches] FYI: LightweightPeers reworked

2006-02-24 Thread Roman Kennke
Hi Thomas, Am Donnerstag, den 23.02.2006, 20:51 -0500 schrieb Thomas Fitzsimmons: On Fri, 2006-02-24 at 00:10 +0100, Roman Kennke wrote: Hi Lillian, - reshape in Component was fixed. invalidate() was only being called on the component if it has moved or has been resized. But the

Re: [cp-patches] FYI: LightweightPeers reworked

2006-02-24 Thread Lillian Angel
On Thu, 2006-02-23 at 20:51 -0500, Thomas Fitzsimmons wrote: Lillian's gnu.testlet.java.awt.Container.LightweightContainer should demonstrate the problem but it doesn't at the moment (see my comments on mauve-patches). I updated the mauve test. It appears we still have not fixed our

Re: [cp-patches] FYI: LightweightPeers reworked

2006-02-24 Thread Thomas Fitzsimmons
On Fri, 2006-02-24 at 10:20 -0500, Lillian Angel wrote: On Thu, 2006-02-23 at 20:51 -0500, Thomas Fitzsimmons wrote: Lillian's gnu.testlet.java.awt.Container.LightweightContainer should demonstrate the problem but it doesn't at the moment (see my comments on mauve-patches). I

Re: [cp-patches] FYI: LightweightPeers reworked

2006-02-24 Thread Lillian Angel
On Fri, 2006-02-24 at 12:45 -0500, Thomas Fitzsimmons wrote: On Fri, 2006-02-24 at 10:20 -0500, Lillian Angel wrote: On Thu, 2006-02-23 at 20:51 -0500, Thomas Fitzsimmons wrote: Lillian's gnu.testlet.java.awt.Container.LightweightContainer should demonstrate the problem but it doesn't

Re: [cp-patches] FYI: LightweightPeers reworked

2006-02-24 Thread Lillian Angel
Here is a new patch for this problem. We went ahead and implemented the listener idea proposed in the last email. It appears to be the simplest (and best) fix. It does not break anything else. Roman suggested we use a HierarchyBoundsListener, but we need a Component Listener for the

Re: [cp-patches] FYI: LightweightPeers reworked

2006-02-24 Thread Thomas Fitzsimmons
On Fri, 2006-02-24 at 13:48 -0500, Lillian Angel wrote: Here is a new patch for this problem. We went ahead and implemented the listener idea proposed in the last email. It appears to be the simplest (and best) fix. It does not break anything else. Roman suggested we use a

Re: [cp-patches] FYI: LightweightPeers reworked

2006-02-23 Thread Scott Gilbertson
Our original idea of changing GLightweightPeer and creating a new class, GtkLightweightContainerPeer, has failed. Ultimately, we came up with a simpler solution that fixes our problem- and does not break anything else. * What was changed: - I applied Scott Gilbertson's patch, it is

Re: [cp-patches] FYI: LightweightPeers reworked

2006-02-23 Thread Lillian Angel
On Thu, 2006-02-23 at 16:00 -0500, Scott Gilbertson wrote: With JamVM + Classpath, the first two paints don't happen, so you get a solid gray box for two seconds at startup, followed by Pass 1 Pass 2 -- and so on. It's probably a separate issue, but somewhat related, I guess. Could you

Re: [cp-patches] FYI: LightweightPeers reworked

2006-02-23 Thread Roman Kennke
Hi Lillian, - reshape in Component was fixed. invalidate() was only being called on the component if it has moved or has been resized. But the problem is that a component could be moved, because its parent moved, and the component would not know about it. invalidate() should always

Re: [cp-patches] FYI: LightweightPeers reworked

2006-02-23 Thread Thomas Fitzsimmons
On Fri, 2006-02-24 at 00:10 +0100, Roman Kennke wrote: Hi Lillian, - reshape in Component was fixed. invalidate() was only being called on the component if it has moved or has been resized. But the problem is that a component could be moved, because its parent moved, and the