Re: [cp-patches] FYI: Vector fixlet

2006-08-17 Thread Roman Kennke
Hi Paul, Probably a dodgy test but I think this commit: On Tue, 2006-08-15 at 11:44 +0200, Roman Kennke wrote: 2006-08-15 Roman Kennke [EMAIL PROTECTED] * java/util/Vector.java (removeAll): Don't explicitly null-check here. The RI allows null arguments when Vector

Re: [cp-patches] FYI: Vector fixlet

2006-08-17 Thread Tom Tromey
Roman == Roman Kennke [EMAIL PROTECTED] writes: Roman Yes, but the JDK also fails this test, so I didn't worry about it. If it is a bogus test, please remove it. Thanks. Tom

[cp-patches] FYI: Vector fixlet

2006-08-15 Thread Roman Kennke
This removes 2 explicit null checks in Vector. The Mauve test that I'll commit right after this shows that the RI allows null arguments when the Vector is empty. In the other case we throw an NPE implicitly anyway. 2006-08-15 Roman Kennke [EMAIL PROTECTED] * java/util/Vector.java

Re: [cp-patches] FYI: Vector fixlet

2006-08-15 Thread Robert Schuster
Hi Roman, could you please add a comment to these methods that says that the NPEs are supposed to be thrown implicitly. Otherwise I find it a bit odd that the javadoc mentions the exceptions explicitly. cya Robert Roman Kennke wrote: This removes 2 explicit null checks in Vector. The Mauve test