Re: [cp-patches] Minor refactoring of PrintStream

2010-12-06 Thread Pekka Enberg
Hi all, I added the following PrintStream constructor API tests to Malva: https://github.com/penberg/malva/commit/b5020c862656c491fc81b2f4f3cee39a6444709a Some of the tests fail with GNU Classpath but Ivan's patch from June cures most of the issues:

[cp-patches] Minor refactoring of PrintStream - resubmission

2010-06-18 Thread Ivan Maidanski
Hi! This is the updated version of my patch for PrintStream (http://comments.gmane.org/gmane.comp.java.classpath.patches/12964). ChangeLog entries: * java/io/PrintStream.java: (line_separator): Convert static field to an instance one (to match the RI functionality).

Re: [cp-patches] Minor refactoring of PrintStream

2010-06-16 Thread Andrew John Hughes
2010/6/15 Ivan Maidanski iv...@mail.ru: Hi! How fast! Tue, 15 Jun 2010 19:07:18 +0100 Andrew John Hughes ahug...@redhat.com: 2010/6/15 Ivan Maidanski iv...@mail.ru: Hi! Here, the proposed changes of PrintStream are: 1. to be closer to the RI behavior (see changes for line_separator,

[cp-patches] Minor refactoring of PrintStream

2010-06-15 Thread Ivan Maidanski
Hi! Here, the proposed changes of PrintStream are: 1. to be closer to the RI behavior (see changes for line_separator, out.flush(), append()); 2. some code optimizations (like removal of writeChars() pos/len parameters). ChangeLog entries: * java/io/PrintStream.java (line_separator):

Re: [cp-patches] Minor refactoring of PrintStream

2010-06-15 Thread Andrew John Hughes
2010/6/15 Ivan Maidanski iv...@mail.ru: Hi! Here, the proposed changes of PrintStream are: 1. to be closer to the RI behavior (see changes for line_separator, out.flush(), append()); While some of these are sensible changes, how are you discovering the 'RI behaviour' in the cases where it