Re: [cp-patches] Patch: adding to top-level containers

2005-06-20 Thread Roman Kennke
Am Montag, den 20.06.2005, 12:06 -0600 schrieb Tom Tromey: > > "Roman" == Roman Kennke <[EMAIL PROTECTED]> writes: > > Roman> this is cool, thank you. Generally I would prefer to go for 1.4 > Roman> compatibility and completeness first, and add 1.5 stuff later > > Any particular reason? I th

Re: [cp-patches] Patch: adding to top-level containers

2005-06-20 Thread Tom Tromey
> "Roman" == Roman Kennke <[EMAIL PROTECTED]> writes: Roman> this is cool, thank you. Generally I would prefer to go for 1.4 Roman> compatibility and completeness first, and add 1.5 stuff later Any particular reason? It seems to me that a fair amount of 1.5 stuff has already gone into cvs he

Re: [cp-patches] Patch: adding to top-level containers

2005-06-17 Thread Roman Kennke
Hi, this is cool, thank you. Generally I would prefer to go for 1.4 compatibility and completeness first, and add 1.5 stuff later, but in this case it really does not hurt. Again, some suggestions: - comments should have the following form: /** * Sentence start with capital letter and end wi

[cp-patches] Patch: adding to top-level containers

2005-06-16 Thread Anthony Balkissoon
This patch allows directly adding to the top level containers JFrame, JApplet, JInternalFrame, JWindow, and JDialog. Before this, some were allowing, some were not, and those that were adding were doing so improperly so that keyboard and mouse input was not possible. Adding directly is allowed in