Re: [cp-patches] RFA: Container.java

Tania Bento wrote: Hey, I have implemented the applyComponentOrientation(ComponentOrientation) method. This patch fixes a failing mauve test (gnu/testlet/java/awt/Container/applyComponentOrientation). Could someone please review my implementation and approve it so that I can commit it.

[cp-patches] RFA: Container.java

Hey, I have implemented the applyComponentOrientation(ComponentOrientation) method. This patch fixes a failing mauve test (gnu/testlet/java/awt/Container/applyComponentOrientation). Could someone please review my implementation and approve it so that I can commit it. Cheers, Tania 2006-06-2

Re: [cp-patches] RFA: Container.java

Hi Tania, Hoping to set a good example, I wrote a couple of new Mauve tests for this and committed them to CVS: gnu.testlet.java.awt.Component.setComponentOrientation gnu.testlet.java.awt.Container.applyComponentOrientation Since you were looking at it, I'll leave you to fix the implementatio

Re: [cp-patches] RFA: Container.java

Hi Tania, In Sun's API specification for Component.setComponentOrientation() it says: "To set the orientation of a single component, use this method. To set the orientation of an entire component hierarchy, use |applyComponentOrientation|

Re: [cp-patches] RFA: Container.java

Hi Tania, > The applyComponentOrientation method needs to actually set the > ComponentOrientation property of the container and it doesn't need to > check if the value of the ComponentOrientation passed to it is null as > the setComponentOrientation method already does this. This change is > base

[cp-patches] RFA: Container.java

Hey, The applyComponentOrientation method needs to actually set the ComponentOrientation property of the container and it doesn't need to check if the value of the ComponentOrientation passed to it is null as the setComponentOrientation method already does this. This change is based on the result