Re: [cp-patches] RFC: @file support for gjavah & gjar

2008-06-06 Thread Robert Schuster
Hi Andrew, thanks a lot for fixing the remaining issues and committing this. Regards Robert Andrew John Hughes schrieb: > Committed with the amendments suggested by Tom and Mario: > > 2008-06-06 Andrew John Hughes <[EMAIL PROTECTED]> > > * tools/gnu/classpath/tools/common/ClasspathToo

Re: [cp-patches] RFC: @file support for gjavah & gjar

2008-06-05 Thread Andrew John Hughes
On 04/06/2008, Mario Torre <[EMAIL PROTECTED]> wrote: > Il giorno mer, 04/06/2008 alle 09.08 -0600, Tom Tromey ha scritto: > > > > Some of the indentation seems wrong to me, though I always find it a > > bit hard to tell due to diffs making tabs look weird. > > > I don't know if I say a popular t

Re: [cp-patches] RFC: @file support for gjavah & gjar

2008-06-04 Thread Mario Torre
Il giorno mer, 04/06/2008 alle 09.08 -0600, Tom Tromey ha scritto: > Some of the indentation seems wrong to me, though I always find it a > bit hard to tell due to diffs making tabs look weird. I don't know if I say a popular thing or not, but please, expand your tabs into spaces, it makes the wh

Re: [cp-patches] RFC: @file support for gjavah & gjar

2008-06-04 Thread Tom Tromey
> "Robert" == Robert Schuster <[EMAIL PROTECTED]> writes: Robert> The other tools are not affected by this change nor does this modify the Robert> core getopt functionality (except that I made the 'programName' field Robert> protected - was private). I don't think we need this to be protected

[cp-patches] RFC: @file support for gjavah & gjar

2008-06-03 Thread Robert Schuster
Hi, the following patch adds @file support to gjavah and gjar by enhancing ClasspathToolParser with a few methods and making both tools use those. The other tools are not affected by this change nor does this modify the core getopt functionality (except that I made the 'programName' field protecte