Re: [cp-patches] RFC: HTTPURLConnection fixlet

2006-02-09 Thread David Daney
Wolfgang Baer wrote: David Daney wrote: Thanks, please update: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26081 as appropriate. If this fixes that bug (which I think it does) the changelog should be prefixed with 'PR classpath/26081' Sorry forgot to include this in the changelog - I have u

Re: [cp-patches] RFC: HTTPURLConnection fixlet

2006-02-09 Thread Wolfgang Baer
David Daney wrote: > Thanks, please update: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26081 > as appropriate. > > If this fixes that bug (which I think it does) the changelog should be > prefixed with 'PR classpath/26081' Sorry forgot to include this in the changelog - I have updated it now. De

Re: [cp-patches] RFC: HTTPURLConnection fixlet

2006-02-09 Thread David Daney
Wolfgang Baer wrote: Hi all, Wolfgang Baer wrote: Hi, David Daney wrote: Perhaps make isError() a member of Response Yes, I also thought of this. Its in HTTPURLConnection because there is already a method isRedirect(Response r). Both should be moved to Response. Committed as attached.

Re: [cp-patches] RFC: HTTPURLConnection fixlet

2006-02-09 Thread Wolfgang Baer
Hi all, Wolfgang Baer wrote: > Hi, > > David Daney wrote: >> >>Perhaps make isError() a member of Response > > Yes, I also thought of this. Its in HTTPURLConnection because there is > already a method isRedirect(Response r). Both should be moved to Response. Committed as attached. Changes ove

Re: [cp-patches] RFC: HTTPURLConnection fixlet

2006-02-05 Thread Wolfgang Baer
Hi, David Daney wrote: > Wolfgang Baer wrote: >> @@ -365,6 +362,12 @@ >> int sc = response.getCode(); >> return (sc != 304 && (sc / 100) == 3); >>} >> + + private static boolean isError(Response response) >> + { >> +int sc = response.getCodeClass(); >> +return (sc == 4 ||

Re: [cp-patches] RFC: HTTPURLConnection fixlet

2006-02-05 Thread David Daney
Wolfgang Baer wrote: Index: gnu/java/net/protocol/http/HTTPURLConnection.java === RCS file: /cvsroot/classpath/classpath/gnu/java/net/protocol/http/HTTPURLConnection.java,v retrieving revision 1.17 diff -u -r1.17 HTTPURLConnection.

Re: [cp-patches] RFC: HTTPURLConnection fixlet

2006-02-05 Thread Wolfgang Baer
Hi all, David Daney wrote: > After thinking about it a bit more (and reading Sun's API reference), I > think that the exception should be thrown from getInputStream(). On any > 4??, 5?? response code getInputStream should throw an IOException. On > 404 it should the FileNotFoundException. Any t

Re: [cp-patches] RFC: HTTPURLConnection fixlet

2006-02-04 Thread David Daney
Wolfgang Baer wrote: Hi Chris, Chris Burdess wrote: Wolfgang Baer wrote: Index: HTTPURLConnection.java === RCS file: /cvsroot/classpath/classpath/gnu/java/net/protocol/http/ HTTPURLConnection.java,v retrieving revision 1.17 di

Re: [cp-patches] RFC: HTTPURLConnection fixlet

2006-02-04 Thread David Daney
Wolfgang Baer wrote: Hi Chris, Chris Burdess wrote: Wolfgang Baer wrote: Index: HTTPURLConnection.java === RCS file: /cvsroot/classpath/classpath/gnu/java/net/protocol/http/ HTTPURLConnection.java,v retrieving revision 1.17 di

Re: [cp-patches] RFC: HTTPURLConnection fixlet

2006-02-04 Thread Wolfgang Baer
Hi Chris, Chris Burdess wrote: > Wolfgang Baer wrote: >> Index: HTTPURLConnection.java >> === >> RCS file: /cvsroot/classpath/classpath/gnu/java/net/protocol/http/ >> HTTPURLConnection.java,v >> retrieving revision 1.17 >> diff -u -r

[cp-patches] RFC: HTTPURLConnection fixlet

2006-02-04 Thread Wolfgang Baer
Hi, this is the first fixlet for the failing fileNotFound test committed to mauve. 2006-02-04 Wolfgang Baer <[EMAIL PROTECTED]> * gnu/java/net/protocol/http/HTTPURLConnection.java: (connect): Don't throw FileNotFoundException. OK to commit ? Wolfgang Index: HTTPURLConnection.