Re: [cp-patches] RFC: WeakHashMap improvement

2005-11-09 Thread Roman Kennke
Hi, Am Mittwoch, den 26.10.2005, 10:37 +0200 schrieb Roman Kennke: Hi, Friedjof Siebert did some improvements on java.util.WeakHashMap that I'd like to check in. They are meant to improve reliability of this class by enabling the prove of a cast and the absence of a null-pointer.

Re: [cp-patches] RFC: WeakHashMap improvement

2005-11-09 Thread Mark Wielaard
Hi Roman, On Wed, 2005-11-09 at 23:52 +0100, Roman Kennke wrote: + if (next == null) throw new InternalError(WeakHashMap in incosistent state); As Tom pointed out in the first review inconsistent is not spelled correctly here. Cheers, Mark signature.asc Description: This is a digitally

Re: [cp-patches] RFC: WeakHashMap improvement

2005-11-09 Thread Tom Tromey
Roman == Roman Kennke [EMAIL PROTECTED] writes: Two nits... Roman + if (next == null) throw new InternalError(WeakHashMap in incosistent state); This should not all be on one line. Also, 'inconsistent' is misspelled here. Tom ___

[cp-patches] RFC: WeakHashMap improvement

2005-10-26 Thread Roman Kennke
Hi, Friedjof Siebert did some improvements on java.util.WeakHashMap that I'd like to check in. They are meant to improve reliability of this class by enabling the prove of a cast and the absence of a null-pointer. 2005-10-26 Roman Kennke [EMAIL PROTECTED] Reported by Friedjof Siebert

[cp-patches] RFC: WeakHashMap improvement

2005-10-26 Thread Roman Kennke
Hi, Friedjof Siebert did some improvements on java.util.WeakHashMap that I'd like to check in. They are meant to improve reliability of this class by enabling the prove of a cast and the absence of a null-pointer. 2005-10-26 Roman Kennke [EMAIL PROTECTED] Reported by Friedjof Siebert

Re: [cp-patches] RFC: WeakHashMap improvement

2005-10-26 Thread Tom Tromey
Roman == Roman Kennke [EMAIL PROTECTED] writes: Roman +WeakBucket prev = null; Roman +WeakBucket next = buckets[slot]; Roman +while (next != bucket) Roman + { Roman + if (next == null) throw new InternalError(WeakHashMap in incosistent state); inconsistent is