Re: [cp-patches] RFC: fix warning in cpio_df

2007-11-08 Thread Mario Torre
Il giorno gio, 08/11/2007 alle 16.44 +0100, Robert Schuster ha scritto: > Hi. > > Can you try using statfs? If it's a system where df is available we can > > try to steal some code from there also. > This is Debian Lenny/Sid x86. I am not sure whether it is normal that > statvfs is not available o

Re: [cp-patches] RFC: fix warning in cpio_df

2007-11-08 Thread Christian Thalinger
On Thu, 2007-11-08 at 16:44 +0100, Robert Schuster wrote: > Now if HAVE_STATVFS is not defined the compiler is correct mourning that > 'path' and 'type' are not used. I have seen code (in classpath) where > this issue is solved this way: > > JNIEXPORT long long > cpio_df (const char *path, CPFILE_

Re: [cp-patches] RFC: fix warning in cpio_df

2007-11-08 Thread Robert Schuster
Hi. Mario Torre schrieb: > Il giorno gio, 08/11/2007 alle 13.06 +0100, Mark Wielaard ha scritto: >> Hi Robert, >> >> On Wed, 2007-11-07 at 22:13 +0100, Robert Schuster wrote: >>> this patch marks the parameters of cpio_df as possibly unused and >>> silents the warning/lets the build continue with

Re: [cp-patches] RFC: fix warning in cpio_df

2007-11-08 Thread Mario Torre
Il giorno gio, 08/11/2007 alle 13.06 +0100, Mark Wielaard ha scritto: > Hi Robert, > > On Wed, 2007-11-07 at 22:13 +0100, Robert Schuster wrote: > > this patch marks the parameters of cpio_df as possibly unused and > > silents the warning/lets the build continue with -Wall. > > Which system is t

Re: [cp-patches] RFC: fix warning in cpio_df

2007-11-08 Thread Mark Wielaard
Hi Robert, On Wed, 2007-11-07 at 22:13 +0100, Robert Schuster wrote: > this patch marks the parameters of cpio_df as possibly unused and > silents the warning/lets the build continue with -Wall. Which system is this? I am not really opposed to the patch, but it would of course be better to figure

[cp-patches] RFC: fix warning in cpio_df

2007-11-07 Thread Robert Schuster
Hi, this patch marks the parameters of cpio_df as possibly unused and silents the warning/lets the build continue with -Wall. Ok to commit? 2007-11-06 Robert Schuster <[EMAIL PROTECTED]> * native/jni/native-lib/cpio.c: (cpio_df): Mark parameters as (possibly) unused. Regards Robert Index