Re: [cp-patches] Re: RFC: native/jni/java-nio/gnu_java_nio_VMChannel.c

2007-06-28 Thread Casey Marshall
On Jun 27, 2007, at 3:27 PM, Ito Kazumitsu wrote: Casey Marshall wrote. I meant the curly braces, the #if..#endif is appropriate. The source code now looks like this. What is the preferred way of writing this? Sorry, I'm just stupid :-) I read the patch wrong; it's good as-is. Thanks.

Re: [cp-patches] Re: RFC: native/jni/java-nio/gnu_java_nio_VMChannel.c

2007-06-27 Thread David Daney
Ito Kazumitsu wrote: Casey Marshall wrote. I meant the curly braces, the #if..#endif is appropriate. The source code now looks like this. What is the preferred way of writing this? if (ioctl (fd, FIONREAD, &avail) == -1) { #if defined(ENOTTY) && defined(HAVE_FSTAT) if (errno ==

[cp-patches] Re: RFC: native/jni/java-nio/gnu_java_nio_VMChannel.c

2007-06-27 Thread Ito Kazumitsu
Casey Marshall wrote. > I meant the curly braces, the #if..#endif is appropriate. The source code now looks like this. What is the preferred way of writing this? if (ioctl (fd, FIONREAD, &avail) == -1) { #if defined(ENOTTY) && defined(HAVE_FSTAT) if (errno == ENOTTY) {

Re: [cp-patches] Re: RFC: native/jni/java-nio/gnu_java_nio_VMChannel.c

2007-06-27 Thread Casey Marshall
On Jun 26, 2007, at 3:18 PM, Ito Kazumitsu wrote: I am afraild Casey Marshall's comment could not reach me. I have just found this comment in the mailing list archive. Your mail host dislikes it when someone from gnu.org sends mail from dreamhost.com. So it goes. Casey Marshall wrote. |

[cp-patches] Re: RFC: native/jni/java-nio/gnu_java_nio_VMChannel.c

2007-06-26 Thread Ito Kazumitsu
I am afraild Casey Marshall's comment could not reach me. I have just found this comment in the mailing list archive. Casey Marshall wrote. | Not sure why you have this block... | | > +#if defined(ENOTTY) && defined(HAVE_FSTAT) | > + if (errno == ENOTTY) | > +{ | > + if (