Re: [cp-patches] FYI: Use exception chaining in javax.net.ssl.SSLSocketFactory.getDefault()

2006-12-11 Thread David Daney
Jeroen Frijters wrote: Hi, Committed. Regards, Jeroen 2006-12-11 Jeroen Frijters [EMAIL PROTECTED] * javax/net/ssl/SSLSocketFactory.java (getDefault): Chain exception cause. Index: javax/net/ssl/SSLSocketFactory.java

RE: [cp-patches] FYI: Use exception chaining in javax.net.ssl.SSLSocketFactory.getDefault()

2006-12-11 Thread Jeroen Frijters
David Daney wrote: Jeroen Frijters wrote: throw new RuntimeException(error instantiating default socket factory: - + ex.toString()); That sounds more like an InternalError than the super-generic RuntimeException. Possibly. I don't

Re: [cp-patches] FYI: Use exception chaining in javax.net.ssl.SSLSocketFactory.getDefault()

2006-12-11 Thread David Daney
Jeroen Frijters wrote: David Daney wrote: Jeroen Frijters wrote: throw new RuntimeException(error instantiating default socket factory: - + ex.toString()); That sounds more like an InternalError than the super-generic

RE: [cp-patches] FYI: Use exception chaining in javax.net.ssl.SSLSocketFactory.getDefault()

2006-12-11 Thread Jeroen Frijters
David Daney wrote: Jeroen Frijters wrote: David Daney wrote: Jeroen Frijters wrote: throw new RuntimeException(error instantiating default socket factory: - + ex.toString()); That sounds more like an

Re: [cp-patches] FYI: Use exception chaining in javax.net.ssl.SSLSocketFactory.getDefault()

2006-12-11 Thread Casey Marshall
On Dec 11, 2006, at 8:37 AM, Jeroen Frijters wrote: David Daney wrote: Jeroen Frijters wrote: throw new RuntimeException(error instantiating default socket factory: - + ex.toString()); That sounds more like an InternalError than the

RE: [cp-patches] FYI: Use exception chaining in javax.net.ssl.SSLSocketFactory.getDefault()

2006-12-11 Thread Jeroen Frijters
Casey Marshall wrote: Really? That seems like worse behavior than just giving up when trying to create the factory. Just delaying exceptions like that seems like it will just hide bugs, instead of forcing you to deal with them up front. Well, given that this method is currently used