Re: RFR: 8271923: [macos] the text color on the selected disabled tabbed pane button remains white making text unreadable [v2]

2021-09-07 Thread Sergey Bylokhov
On Mon, 6 Sep 2021 08:00:36 GMT, Prasanta Sadhukhan wrote: >> It is seen that if a JTabbedPane is unfocused, it's title is painted with >> **white** text on grey background >> as opposed to **black** text on grey background in unfoucsed native app on >> macOSX Catalina >> and is somewhat not

Integrated: 8271603: Unnecessary Vector usage in java.desktop

2021-09-07 Thread Andrey Turbanov
On Sun, 4 Jul 2021 20:42:41 GMT, Andrey Turbanov wrote: > Usage of thread-safe collection `Vector` is unnecessary. It's recommended to > use `ArrayList` if a thread-safe implementation is not needed. In > post-BiasedLocking times, this is gets worse, as every access is synchronized. > I checke

Re: RFR: JDK-8273387: remove some unreferenced gtk-related functions

2021-09-07 Thread Pankaj Bansal
On Tue, 7 Sep 2021 07:29:19 GMT, Matthias Baesken wrote: > Please review this small change. > Looks like there are a few functions, like gtk2_paint_diamond, that are > unreferenced and can be removed. > > Thanks, Matthias src/java.desktop/unix/native/libawt_xawt/awt/gtk2_interface.c line 1853:

JDK-8269888: Thai text rendered incorrectly using some AffineTransform-derived fonts

2021-09-07 Thread Daniel Gredler
Hi all, I'm trying to figure out a fix for JDK-8269888 [1]. The font that I'm using to replicate the issue, Google Noto Sans Thai Regular [2], uses the GPOS table internally. It looks like the GPOS adjustment in HB is a two-step process, where HB first sets the glyph position x_offset using anchor

Integrated: 8273168: Remove superfluous use of boxing in java.desktop

2021-09-07 Thread Andrey Turbanov
On Tue, 31 Aug 2021 07:37:21 GMT, Andrey Turbanov wrote: > parseInt/parseLong/parseShort/parseByte/parseFloat should be preferred, as > they return primitives. While valueOf returns boxed object. This pull request has now been integrated. Changeset: 708407ed Author:Andrey Turbanov Commit

Re: RFR: 8273168: Remove superfluous use of boxing in java.desktop [v2]

2021-09-07 Thread Alexey Ivanov
On Wed, 1 Sep 2021 10:44:07 GMT, Andrey Turbanov wrote: >> parseInt/parseLong/parseShort/parseByte/parseFloat should be preferred, as >> they return primitives. While valueOf returns boxed object. > > Andrey Turbanov has updated the pull request with a new target base due to a > merge or a reb

Re: RFR: 8273375: Remove redundant 'new String' calls after concatenation in java.desktop

2021-09-07 Thread Alexey Ivanov
On Fri, 3 Sep 2021 07:53:21 GMT, Andrey Turbanov wrote: > Result of string concatenation is a newly created `String` object. There is > no need it wrap it in another `new String` call. > Such calls are confusing and produce warnings in IDE. Without them code is > easier to read. src/java.desk

Re: RFR: 8273102: Delete deprecated for removal the empty finalize() in java.desktop module

2021-09-07 Thread Iris Clark
On Sun, 29 Aug 2021 01:09:36 GMT, Sergey Bylokhov wrote: > The "java.desktop" module has a few implementations of the finalize() which > do nothing, deprecated since jdk9, and are marked "forRemoval = true" since > jdk16. > > This is a request to delete such empty methods. > > CSR: https://