Re: RFR: 8268084: [macos] Disabled JMenuItem arrow is not disabled [v7]

2021-09-21 Thread Jayathirth D V
On Mon, 13 Sep 2021 08:41:28 GMT, Prasanta Sadhukhan wrote: >> It is seen in macos disabled JMenuItem arrow is not disabled even though >> JMenuItem itself is disabled. >> In native app, same menuitem arrow is disabled for disabled menuitem. >> >> Issue is when AquaMenuPainter#paintMenuItem()

Re: RFR: 8254841: [macos] Enter or Exit events are shouldn't be displayed while resizing [v5]

2021-09-21 Thread Sergey Bylokhov
On Wed, 22 Sep 2021 02:10:26 GMT, Phil Race wrote: > I love your confidence .. so does that mean you tested it ? =) I did not test, the code which we try to exclude was added as part of the JDK-8028485, so if the flag=true in that use case we reintroduce that bug. I touched that code to make r

Re: RFR: 8254841: [macos] Enter or Exit events are shouldn't be displayed while resizing [v5]

2021-09-21 Thread Phil Race
On Wed, 22 Sep 2021 01:16:53 GMT, Sergey Bylokhov wrote: > > That seems unlikely to generate a sequence of such events > > The macOS for sure will generate the native resize events in such cases, and > I think this flag will be true in that case. I love your confidence .. so does that mean you

Integrated: 8273684: Replace usages of java.util.Stack with ArrayDeque

2021-09-21 Thread Andrey Turbanov
On Sun, 29 Aug 2021 21:14:19 GMT, Andrey Turbanov wrote: > Usage of thread-safe collection Stack is unnecessary. It's recommended to use > ArrayDequeue if a thread-safe implementation is not needed. This pull request has now been integrated. Changeset: cbe57e86 Author:Andrey Turbanov Com

Re: RFR: 8254841: [macos] Enter or Exit events are shouldn't be displayed while resizing [v5]

2021-09-21 Thread Sergey Bylokhov
On Tue, 21 Sep 2021 23:56:29 GMT, Phil Race wrote: > That seems unlikely to generate a sequence of such events The macOS for sure will generate the native resize events in such cases, and I think this flag will be true in that case. - PR: https://git.openjdk.java.net/jdk/pull/5497

Re: RFR: 8254841: [macos] Enter or Exit events are shouldn't be displayed while resizing [v5]

2021-09-21 Thread Alan Snyder
My understanding is that live resizing means the window display updates continuously as the window size is changed by the user (who is dragging a resize handle). The alternative is for AppKit to scale the original window display to fit the updated window size until the user stops dragging. Liv

Re: RFR: 8254841: [macos] Enter or Exit events are shouldn't be displayed while resizing [v5]

2021-09-21 Thread Phil Race
On Tue, 21 Sep 2021 23:39:41 GMT, Sergey Bylokhov wrote: > > _AppKit sets the value of this property to YES when a live resizing > > operation involving the view is underway. Use this property to determine > > when to optimize your view’s drawing behavior. Typically, you access this > > proper

Re: RFR: 8254841: [macos] Enter or Exit events are shouldn't be displayed while resizing [v5]

2021-09-21 Thread Sergey Bylokhov
On Tue, 21 Sep 2021 23:33:49 GMT, Sergey Bylokhov wrote: > _AppKit sets the value of this property to YES when a live resizing operation > involving the view is underway. Use this property to determine when to > optimize your view’s drawing behavior. Typically, you access this property > from

Re: RFR: 8254841: [macos] Enter or Exit events are shouldn't be displayed while resizing [v5]

2021-09-21 Thread Sergey Bylokhov
On Fri, 17 Sep 2021 16:33:10 GMT, Alisen Chung wrote: >> Added a resizing flag when the window is currently being resized to block >> mouseEntered and mouseExited events from being posted to that window. > > Alisen Chung has updated the pull request incrementally with one additional > commit s

Re: RFR: 8254841: [macos] Enter or Exit events are shouldn't be displayed while resizing [v5]

2021-09-21 Thread Phil Race
On Fri, 17 Sep 2021 16:33:10 GMT, Alisen Chung wrote: >> Added a resizing flag when the window is currently being resized to block >> mouseEntered and mouseExited events from being posted to that window. > > Alisen Chung has updated the pull request incrementally with one additional > commit s

Re: RFR: 8254841: [macos] Enter or Exit events are shouldn't be displayed while resizing [v5]

2021-09-21 Thread Phil Race
On Tue, 21 Sep 2021 19:15:43 GMT, Sergey Bylokhov wrote: >> Alisen Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added check for inLiveResize in AWTWindow > > src/java.desktop/macosx/native/libawt_lwawt/awt/AWTWindow.m line 659:

Re: RFR: 8254841: [macos] Enter or Exit events are shouldn't be displayed while resizing [v5]

2021-09-21 Thread Phil Race
On Fri, 17 Sep 2021 16:33:10 GMT, Alisen Chung wrote: >> Added a resizing flag when the window is currently being resized to block >> mouseEntered and mouseExited events from being posted to that window. > > Alisen Chung has updated the pull request incrementally with one additional > commit s

Re: RFR: 8262945: [macos] Regression Manual Test for Key Events Fails

2021-09-21 Thread Phil Race
On Tue, 21 Sep 2021 18:00:13 GMT, Alisen Chung wrote: > Added a check for active keyboard language and added support for Russian > NSEvent keyCodes to JavaVirtualKeyCode translation. Originally, only English > characters were checked for even if other languages were in native > letterCharacte

Re: RFR: 8254841: [macos] Enter or Exit events are shouldn't be displayed while resizing [v5]

2021-09-21 Thread Sergey Bylokhov
On Fri, 17 Sep 2021 16:33:10 GMT, Alisen Chung wrote: >> Added a resizing flag when the window is currently being resized to block >> mouseEntered and mouseExited events from being posted to that window. > > Alisen Chung has updated the pull request incrementally with one additional > commit s

Re: RFR: 8254841: [macos] Enter or Exit events are shouldn't be displayed while resizing [v5]

2021-09-21 Thread Alexander Zuev
On Fri, 17 Sep 2021 16:33:10 GMT, Alisen Chung wrote: >> Added a resizing flag when the window is currently being resized to block >> mouseEntered and mouseExited events from being posted to that window. > > Alisen Chung has updated the pull request incrementally with one additional > commit s

Re: RFR: 8262945: [macos] Regression Manual Test for Key Events Fails

2021-09-21 Thread Alexander Zuev
On Tue, 21 Sep 2021 18:00:13 GMT, Alisen Chung wrote: > Added a check for active keyboard language and added support for Russian > NSEvent keyCodes to JavaVirtualKeyCode translation. Originally, only English > characters were checked for even if other languages were in native > letterCharacte

RFR: 8262945: [macos] Regression Manual Test for Key Events Fails

2021-09-21 Thread Alisen Chung
Added a check for active keyboard language and added support for Russian NSEvent keyCodes to JavaVirtualKeyCode translation. Originally, only English characters were checked for even if other languages were in native letterCharacterSet. Can be easily expanded to include other languages as well.

Re: RFR: 8274070: Rectify problemlist platform for failing test on macos12

2021-09-21 Thread Alexander Zvegintsev
On Tue, 21 Sep 2021 11:39:53 GMT, Prasanta Sadhukhan wrote: > It was mentioned in JDK-8273618 > >> java/awt/FullScreen/DisplayChangeVITest/DisplayChangeVITest.java is timing >> out on a macOS 12 aarch64 (an Apple Silicon Mac Mini) system. >> I'm not seeing the same on x64. > > but it is probl

Re: RFR: 8274032 : Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/ImagePrinting/ImageTypes.java & show test UI [v2]

2021-09-21 Thread lawrence . andrews
On Tue, 21 Sep 2021 11:56:07 GMT, lawrence.andrews wrote: >> test/jdk/java/awt/print/PrinterJob/ImagePrinting/ImageTypes.java line 83: >> >>> 81: import static java.awt.image.BufferedImage.TYPE_INT_RGB; >>> 82: import static java.awt.image.BufferedImage.TYPE_USHORT_555_RGB; >>> 83: import stati

Re: RFR: 8274032 : Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/ImagePrinting/ImageTypes.java & show test UI [v2]

2021-09-21 Thread lawrence . andrews
> Problem : > 1) Testcase was failing due to parse exception yesno > 2) After removing yesno tag test frame and immediately get disposed > > Fix : > 1) Removed yesno tag > 2) Show the test frame with pass, fail button. Now user can click on the > `print' button to show the print dialog and tak

Integrated: 8274056 JavaAccessibilityUtilities leaks JNI objects

2021-09-21 Thread Artem Semenov
On Tue, 21 Sep 2021 09:51:48 GMT, Artem Semenov wrote: > The following methods in JavaAccessibilityUtilities leak JNI objects got from > up-calls to Java: > - getAxComponentSize > - getJavaRole > > Also, getAxComponentSize calls jm_getSize on wrong class. This pull request has now been int

Re: RFR: 8274032 : Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/ImagePrinting/ImageTypes.java & show test UI

2021-09-21 Thread lawrence . andrews
On Tue, 21 Sep 2021 08:13:41 GMT, Pankaj Bansal wrote: >> Problem : >> 1) Testcase was failing due to parse exception yesno >> 2) After removing yesno tag test frame and immediately get disposed >> >> Fix : >> 1) Removed yesno tag >> 2) Show the test frame with pass, fail button. Now user can

RFR: 8274070: Rectify problemlist platform for failing test on macos12

2021-09-21 Thread Prasanta Sadhukhan
It was mentioned in JDK-8273618 > java/awt/FullScreen/DisplayChangeVITest/DisplayChangeVITest.java is timing > out on a macOS 12 aarch64 (an Apple Silicon Mac Mini) system. > I'm not seeing the same on x64. but it is problemlisted for macos-all..It should be problemlisted only for macos-aarch64

Re: RFR: 8272756: Remove unnecessary explicit initialization of volatile variables in java.desktop [v2]

2021-09-21 Thread Andrey Turbanov
On Tue, 21 Sep 2021 11:37:42 GMT, Сергей Цыпанов wrote: >> This is a continuation of >> >> - https://bugs.openjdk.java.net/browse/JDK-6736490 >> - https://bugs.openjdk.java.net/browse/JDK-8035284 >> - https://bugs.openjdk.java.net/browse/JDK-8145680 >> - https://bugs.openjdk.java.net/browse/JDK

Re: RFR: 8274056 JavaAccessibilityUtilities leaks JNI objects

2021-09-21 Thread Anton Tarasov
On Tue, 21 Sep 2021 09:51:48 GMT, Artem Semenov wrote: > The following methods in JavaAccessibilityUtilities leak JNI objects got from > up-calls to Java: > - getAxComponentSize > - getJavaRole > > Also, getAxComponentSize calls jm_getSize on wrong class. Marked as reviewed by ant (Reviewe

Re: RFR: 8272756: Remove unnecessary explicit initialization of volatile variables in java.desktop

2021-09-21 Thread Сергей Цыпанов
On Mon, 20 Sep 2021 11:55:43 GMT, Andrey Turbanov wrote: >> This is a continuation of >> >> - https://bugs.openjdk.java.net/browse/JDK-6736490 >> - https://bugs.openjdk.java.net/browse/JDK-8035284 >> - https://bugs.openjdk.java.net/browse/JDK-8145680 >> - https://bugs.openjdk.java.net/browse/JD

Re: RFR: 8274056 JavaAccessibilityUtilities leaks JNI objects

2021-09-21 Thread Alexey Ivanov
On Tue, 21 Sep 2021 09:51:48 GMT, Artem Semenov wrote: > 8274056 JavaAccessibilityUtilities leaks JNI objects Marked as reviewed by aivanov (Reviewer). I would appreciate if you add more details in the description of the PR. Copying that from the JBS would be enough. I expect @forantar will

Re: RFR: 8272756: Remove unnecessary explicit initialization of volatile variables in java.desktop [v2]

2021-09-21 Thread Сергей Цыпанов
> This is a continuation of > > - https://bugs.openjdk.java.net/browse/JDK-6736490 > - https://bugs.openjdk.java.net/browse/JDK-8035284 > - https://bugs.openjdk.java.net/browse/JDK-8145680 > - https://bugs.openjdk.java.net/browse/JDK-8251548 > > As mentioned in JDK-6736490: > > _An explicit init

RFR: 8274056 JavaAccessibilityUtilities leaks JNI objects

2021-09-21 Thread Artem Semenov
8274056 JavaAccessibilityUtilities leaks JNI objects - Commit messages: - 8274056 JavaAccessibilityUtilities leaks JNI objects - Java Bug System Changes: https://git.openjdk.java.net/jdk/pull/5602/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5602&range=00 Issue: ht

Re: RFR: 8268764: Use Long.hashCode() instead of int-cast where applicable [v4]

2021-09-21 Thread Alexander Zuev
On Thu, 1 Jul 2021 12:19:53 GMT, Сергей Цыпанов wrote: >> In some JDK classes there's still the following hashCode() implementation: >> >> long objNum; >> >> public int hashCode() { >> return (int) objNum; >> } >> >> This outdated expression should be replaced with Long.hashCode(long) as

Re: RFR: 8274032 : Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/ImagePrinting/ImageTypes.java & show test UI

2021-09-21 Thread Pankaj Bansal
On Tue, 21 Sep 2021 03:24:24 GMT, lawrence.andrews wrote: > Problem : > 1) Testcase was failing due to parse exception yesno > 2) After removing yesno tag test frame and immediately get disposed > > Fix : > 1) Removed yesno tag > 2) Show the test frame with pass, fail button. Now user can cl

Re: RFR: 8273581: Change the mechanism by which JDK loads the platform-specific FontManager class [v7]

2021-09-21 Thread Alexey Ivanov
On Tue, 21 Sep 2021 08:01:32 GMT, Alexander Scherbatiy wrote: >> FontManagerFactory class uses reflection to load platform specific >> FontManager classes from "sun.font.fontmanager" property. >> >> Fix proposes creating FontManager platform specific classes directly in the >> similar way as

Re: RFR: 8273581: Change the mechanism by which JDK loads the platform-specific FontManager class [v7]

2021-09-21 Thread Alexander Scherbatiy
> FontManagerFactory class uses reflection to load platform specific > FontManager classes from "sun.font.fontmanager" property. > > Fix proposes creating FontManager platform specific classes directly in the > similar way as it has been already done for GraphicsEnvironment and AWT > Toolkit ([

Re: RFR: 8273581: Change the mechanism by which JDK loads the platform-specific FontManager class [v6]

2021-09-21 Thread Alexander Scherbatiy
On Mon, 20 Sep 2021 17:56:25 GMT, Alexey Ivanov wrote: > Should `PlatformFontInfo` classes be marked `final`? They're not supposed to > be subclassed. The final keyword is added to the `PlatformFontInfo` clases. - PR: https://git.openjdk.java.net/jdk/pull/5517