RFR: 8273617: UninitializedDisplayModeChangeTest.java times out on macOS 12

2021-09-22 Thread Prasanta Sadhukhan
java/awt/FullScreen/UninitializedDisplayModeChangeTest/UninitializedDisplayModeChangeTest.java is timing out every time on macOS 12 even though the test passed. Looks like the the main process waits for child process created in the test forever, making it timeout after jtreg timeout of 2min. Modi

Integrated: 8273578: javax/swing/JMenu/4515762/bug4515762.java fails on macOS 12

2021-09-22 Thread Prasanta Sadhukhan
On Fri, 17 Sep 2021 12:24:40 GMT, Prasanta Sadhukhan wrote: > The test sometimes fail on macos12 citing "Action has not been received". > Seems like some key events sometimes are not received reliably. > Proposed fix is to apply mach5 stability fixes which is to set autodelay to > 100ms, move

Re: RFR: 8273578: javax/swing/JMenu/4515762/bug4515762.java fails on macOS 12 [v2]

2021-09-22 Thread Prasanta Sadhukhan
> The test sometimes fail on macos12 citing "Action has not been received". > Seems like some key events sometimes are not received reliably. > Proposed fix is to apply mach5 stability fixes which is to set autodelay to > 100ms, move frame to center of screen from top-left, added extra > waitFo

Re: RFR: 8273578: javax/swing/JMenu/4515762/bug4515762.java fails on macOS 12 [v2]

2021-09-22 Thread Jayathirth D V
On Thu, 23 Sep 2021 05:08:26 GMT, Prasanta Sadhukhan wrote: >> The test sometimes fail on macos12 citing "Action has not been received". >> Seems like some key events sometimes are not received reliably. >> Proposed fix is to apply mach5 stability fixes which is to set autodelay to >> 100ms,

Re: RFR: 8273578: javax/swing/JMenu/4515762/bug4515762.java fails on macOS 12

2021-09-22 Thread Jayathirth D V
On Fri, 17 Sep 2021 12:24:40 GMT, Prasanta Sadhukhan wrote: > The test sometimes fail on macos12 citing "Action has not been received". > Seems like some key events sometimes are not received reliably. > Proposed fix is to apply mach5 stability fixes which is to set autodelay to > 100ms, move

Re: RFR: 8273578: javax/swing/JMenu/4515762/bug4515762.java fails on macOS 12

2021-09-22 Thread Sergey Bylokhov
On Fri, 17 Sep 2021 12:24:40 GMT, Prasanta Sadhukhan wrote: > The test sometimes fail on macos12 citing "Action has not been received". > Seems like some key events sometimes are not received reliably. > Proposed fix is to apply mach5 stability fixes which is to set autodelay to > 100ms, move

Re: RFR: 8274016: Replace 'for' cycles with iterator with enhanced-for in java.desktop

2021-09-22 Thread Sergey Bylokhov
On Sun, 19 Sep 2021 10:13:49 GMT, Andrey Turbanov wrote: > There are few places in code where manual `for` loop is used with Iterator to > iterate over Collection. > Instead of manual `for` cycles it's preferred to use enhanced-for cycle > instead: it's less verbose, makes code easier to read

Re: RFR: 8273578: javax/swing/JMenu/4515762/bug4515762.java fails on macOS 12

2021-09-22 Thread Jayathirth D V
On Fri, 17 Sep 2021 12:24:40 GMT, Prasanta Sadhukhan wrote: > The test sometimes fail on macos12 citing "Action has not been received". > Seems like some key events sometimes are not received reliably. > Proposed fix is to apply mach5 stability fixes which is to set autodelay to > 100ms, move

Re: RFR: 8254841: [macos] Enter and Exit events shouldn't be sent whilst resizing [v5]

2021-09-22 Thread Sergey Bylokhov
On Wed, 22 Sep 2021 17:53:09 GMT, Alisen Chung wrote: > Before the changes the mouseEntered and mouseExited events would constantly > fire, while after the fix only a mouseEntered event would fire Does it mean that after the fix we will post a few enter events w/o exit events? Then it is wors

Re: RFR: 8254841: [macos] Enter and Exit events shouldn't be sent whilst resizing [v6]

2021-09-22 Thread Alisen Chung
> Added a resizing flag when the window is currently being resized to block > mouseEntered and mouseExited events from being posted to that window. Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: marked test headful - C

Re: RFR: 8254841: [macos] Enter and Exit events shouldn't be sent whilst resizing [v5]

2021-09-22 Thread Phil Race
On Wed, 22 Sep 2021 19:26:23 GMT, Alisen Chung wrote: >> test/jdk/java/awt/event/MouseEvent/ResizeMouseExitEnterMisfire/ResizeMouseExitEnterMisfire.java >> line 38: >> >>> 36: * @bug 8254841 >>> 37: * @summary Tests spurious firing of mouseEntered and mouseExit on >>> resize >>> 38: * @run

Re: RFR: 8254841: [macos] Enter and Exit events shouldn't be sent whilst resizing [v5]

2021-09-22 Thread Alisen Chung
On Wed, 22 Sep 2021 07:49:33 GMT, Prasanta Sadhukhan wrote: >> Alisen Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added check for inLiveResize in AWTWindow > > test/jdk/java/awt/event/MouseEvent/ResizeMouseExitEnterMisfire/Res

Integrated: 8205137: Remove Applet support from SwingSet2

2021-09-22 Thread Alisen Chung
On Tue, 7 Sep 2021 22:08:58 GMT, Alisen Chung wrote: > removed support for running demo from applet for J2Ddemo and SwingSet2 > same PR as 8205137: Remove Applet support from SwingSet2 #5400 (changed > branch name) This pull request has now been integrated. Changeset: 8821b000 Author:Alis

Re: RFR: 8254841: [macos] Enter and Exit events shouldn't be sent whilst resizing [v5]

2021-09-22 Thread Alisen Chung
On Fri, 17 Sep 2021 16:33:10 GMT, Alisen Chung wrote: >> Added a resizing flag when the window is currently being resized to block >> mouseEntered and mouseExited events from being posted to that window. > > Alisen Chung has updated the pull request incrementally with one additional > commit s

Re: RFR: 8254841: [macos] Enter and Exit events shouldn't be sent whilst resizing [v5]

2021-09-22 Thread Alisen Chung
On Tue, 21 Sep 2021 22:49:04 GMT, Phil Race wrote: >> src/java.desktop/macosx/native/libawt_lwawt/awt/AWTWindow.m line 659: >> >>> 657: if (![self.nsWindow inLiveResize]) { >>> 658: [AWTWindow synthesizeMouseEnteredExitedEventsForAllWindows]; >>> 659: } >> >> Are you sure that i

Re: RFR: 8262945: [macos] Regression Manual Test for Key Events Fails

2021-09-22 Thread Alisen Chung
On Tue, 21 Sep 2021 22:39:12 GMT, Phil Race wrote: > where did this value come from ? The 0x0100 offset value is copied from share/classes/sun/awt/ExtendedKeyCodes.java. When using getExtendedKeyCodeForChar(int c), if the character isn't in the regularKeyCodesMap, that 0x0100 offset i

Integrated: 8274070: Rectify problemlist platform for failing test on macos12

2021-09-22 Thread Prasanta Sadhukhan
On Tue, 21 Sep 2021 11:39:53 GMT, Prasanta Sadhukhan wrote: > It was mentioned in JDK-8273618 > >> java/awt/FullScreen/DisplayChangeVITest/DisplayChangeVITest.java is timing >> out on a macOS 12 aarch64 (an Apple Silicon Mac Mini) system. >> I'm not seeing the same on x64. > > but it is probl

Re: RFR: 8254841: [macos] Enter and Exit events shouldn't be sent whilst resizing [v5]

2021-09-22 Thread Prasanta Sadhukhan
On Fri, 17 Sep 2021 16:33:10 GMT, Alisen Chung wrote: >> Added a resizing flag when the window is currently being resized to block >> mouseEntered and mouseExited events from being posted to that window. > > Alisen Chung has updated the pull request incrementally with one additional > commit s