Re: RFR: 8274016: Replace 'for' cycles with iterator with enhanced-for in java.desktop [v3]

2021-09-24 Thread Sergey Bylokhov
On Thu, 23 Sep 2021 09:47:21 GMT, Andrey Turbanov wrote: >> There are few places in code where manual `for` loop is used with Iterator >> to iterate over Collection. >> Instead of manual `for` cycles it's preferred to use enhanced-for cycle >> instead: it's less verbose, makes code easier to r

Re: RFR: 8262945: [macos] Regression Manual Test for Key Events Fails [v2]

2021-09-24 Thread Alisen Chung
> Added a check for active keyboard language and added support for Russian > NSEvent keyCodes to JavaVirtualKeyCode translation. Originally, only English > characters were checked for even if other languages were in native > letterCharacterSet. Can be easily expanded to include other languages a

Re: RFR: 8274296: Update or Problem List tests which may fail with uiScale=2 on macOS

2021-09-24 Thread Phil Race
On Fri, 24 Sep 2021 18:09:38 GMT, Sergey Bylokhov wrote: >> As described in https://bugs.openjdk.java.net/browse/JDK-8274106 a number of >> tests fail due to some inaccuracy in pixels copied from the screen when >> scaling down from device space to user space. >> The subject of most of these te

Re: RFR: 8273972: Multi-core choke point in CMM engine (LCMSTransform.doTransform)

2021-09-24 Thread Sergey Bylokhov
On Fri, 24 Sep 2021 04:38:13 GMT, Sergey Bylokhov wrote: > Initially, the bug was discussed here: > https://stackoverflow.com/questions/35264582/why-is-multithreading-slowing-down/35264813 > > The root cause is that if for some reason directly or indirectly the color > transform object is share

RFR: 8273972: Multi-core choke point in CMM engine (LCMSTransform.doTransform)

2021-09-24 Thread Sergey Bylokhov
Initially, the bug was discussed here: https://stackoverflow.com/questions/35264582/why-is-multithreading-slowing-down/35264813 The root cause is that if for some reason directly or indirectly the color transform object is shared across the threads it cannot be used for parallel color transforma

Re: RFR: 7001973: java/awt/Graphics2D/CopyAreaOOB.java fails

2021-09-24 Thread Sergey Bylokhov
On Fri, 24 Sep 2021 11:17:18 GMT, Masanori Yano wrote: > This is a RepaintArea's behavior. clearRect() is called before paint() > because shouldClearRectBeforePaint is true for Canvas. Then, if 2nd paint() > is called and paint() does nothing, blank window will be drawn. So the "sun.awt.noeras

Re: RFR: 8254841: [macos] Enter and Exit events shouldn't be sent whilst resizing [v5]

2021-09-24 Thread Sergey Bylokhov
On Fri, 24 Sep 2021 17:03:21 GMT, Alisen Chung wrote: > > Does the test from there still pass ? Any others fail ? > > All manual and automatic tests are passing on macOS. I guess the only test which makes sense here is the test for JDK-8013468 and it is "problem listed" due to a reflection is

Re: RFR: 8273617: UninitializedDisplayModeChangeTest.java times out on macOS 12

2021-09-24 Thread Sergey Bylokhov
On Thu, 23 Sep 2021 06:47:33 GMT, Prasanta Sadhukhan wrote: > java/awt/FullScreen/UninitializedDisplayModeChangeTest/UninitializedDisplayModeChangeTest.java > is timing out every time on macOS 12 even though the test passed. > Looks like the the main process waits for child process created in t

RE: [macOS] Is there a Roadmap for availability of NSAcccessibility implementation?

2021-09-24 Thread Koeble, Josef
Hi Alex, thank you for your quick response! We are glad to read that you will backport these fixes to JDK 17. As we are interested in a good interaction between Java Accessibility API and macOS system Accessibility API, I plan to do some tests with VoiceOver. In a first quick test with SwingSe

Re: RFR: 8274296: Update or Problem List tests which may fail with uiScale=2 on macOS

2021-09-24 Thread Sergey Bylokhov
On Fri, 24 Sep 2021 16:28:51 GMT, Phil Race wrote: > As described in https://bugs.openjdk.java.net/browse/JDK-8274106 a number of > tests fail due to some inaccuracy in pixels copied from the screen when > scaling down from device space to user space. > The subject of most of these tests is suc

Integrated: 8274296: Update or Problem List tests which may fail with uiScale=2 on macOS

2021-09-24 Thread Phil Race
On Fri, 24 Sep 2021 16:28:51 GMT, Phil Race wrote: > As described in https://bugs.openjdk.java.net/browse/JDK-8274106 a number of > tests fail due to some inaccuracy in pixels copied from the screen when > scaling down from device space to user space. > The subject of most of these tests is suc

Re: RFR: 8254841: [macos] Enter and Exit events shouldn't be sent whilst resizing [v7]

2021-09-24 Thread Phil Race
On Thu, 23 Sep 2021 20:42:28 GMT, Alisen Chung wrote: >> Added a resizing flag when the window is currently being resized to block >> mouseEntered and mouseExited events from being posted to that window. > > Alisen Chung has updated the pull request incrementally with one additional > commit s

Re: RFR: 8274296: Update or Problem List tests which may fail with uiScale=2 on macOS

2021-09-24 Thread Jayathirth D V
On Fri, 24 Sep 2021 16:28:51 GMT, Phil Race wrote: > As described in https://bugs.openjdk.java.net/browse/JDK-8274106 a number of > tests fail due to some inaccuracy in pixels copied from the screen when > scaling down from device space to user space. > The subject of most of these tests is suc

Re: RFR: 8254841: [macos] Enter and Exit events shouldn't be sent whilst resizing [v5]

2021-09-24 Thread Alisen Chung
On Thu, 23 Sep 2021 21:50:57 GMT, Phil Race wrote: > > > > I checked for when the user maximizes the window and tiles to the left > > > > or right of the screen and both seem to work. > > > > > > > > > But what is the flag value? Is it true or false? If it's true and > > > everything works ma

RFR: 8274296: Update or Problem List tests which may fail with uiScale=2 on macOS

2021-09-24 Thread Phil Race
As described in https://bugs.openjdk.java.net/browse/JDK-8274106 a number of tests fail due to some inaccuracy in pixels copied from the screen when scaling down from device space to user space. The subject of most of these tests is such that uiScale isn't important and we can have them pass wit

Re: RFR: 8273634: [TEST_BUG] Improve javax/swing/text/ParagraphView/6364882/bug6364882.java

2021-09-24 Thread Alexey Ivanov
On Fri, 24 Sep 2021 00:09:44 GMT, Sergey Bylokhov wrote: > I assume that an updated test still fail before JDK-6364882 Correct. I forgot to add this statement. The updated test fails with builds of JDK 6 until [JDK-6364882](https://bugs.openjdk.java.net/browse/JDK-6364882) is fixed, that is th

Re: RFR: 8239502: [TEST_BUG] Test javax/swing/text/FlowView/6318524/bug6318524.java never fails

2021-09-24 Thread Alexey Ivanov
On Fri, 24 Sep 2021 07:19:16 GMT, Prasanta Sadhukhan wrote: > Probably it will be better to use descriptive name for the test rather than > bugid. In the majority of cases, the test name is not detailed enough, however, it usually gives a better idea than a plain bugid. If a test fails, you s

Re: RFR: 7001973: java/awt/Graphics2D/CopyAreaOOB.java fails

2021-09-24 Thread Masanori Yano
On Fri, 17 Sep 2021 08:15:54 GMT, Sergey Bylokhov wrote: > my question was why the first CopyArea is ignored? This is a RepaintArea's behavior. clearRect() is called before paint() because shouldClearRectBeforePaint is true for Canvas. Then, if 2nd paint() is called and paint() does nothing,

Re: RFR: 8239502: [TEST_BUG] Test javax/swing/text/FlowView/6318524/bug6318524.java never fails

2021-09-24 Thread Prasanta Sadhukhan
On Thu, 23 Sep 2021 18:41:38 GMT, Alexey Ivanov wrote: > The test is being moved from the closed to open. It's nearly a complete > re-write of the original test. > > I made the test headless by painting into image. > > To detect failure, the test uses the position of the caret at the end of >