Re: RFR: 8274396: Suppress more warnings on non-serializable non-transient intance fields in client libs [v2]

2021-09-27 Thread Sergey Bylokhov
On Mon, 27 Sep 2021 22:48:24 GMT, Joe Darcy wrote: >> Follow-up changes to JDK-8231334. , augmentations to javac's Xlint:serial >> checking are out for review (#5709) and various client libraries would need >> some changes to pass under the expanded checks. >> >> The changes are to suppress wa

Re: RFR: 8274397: [macOS] Stop setting env. var JAVA_MAIN_CLASS_ in launcher code [v2]

2021-09-27 Thread Phil Race
> macOS launcher code sets JAVA_MAIN_CLASS_ which is read by AWT to set > the name of the application in the system menu bar. > > Because this set shortly after the VM is running, it causes a thread safety > issue described in https://bugs.openjdk.java.net/browse/JDK-8270549 > > Since the AWT a

Re: RFR: 8274396: Suppress more warnings on non-serializable non-transient intance fields in client libs

2021-09-27 Thread Joe Darcy
On Mon, 27 Sep 2021 21:40:13 GMT, Sergey Bylokhov wrote: > > > Can we add comments to SuppressWarnings on why it was added? Previously we > use this text > > > // Not statically typed as Serializable Added in revision; used a different comment wording. - PR: https://git.openjdk

Re: RFR: 8274396: Suppress more warnings on non-serializable non-transient intance fields in client libs [v2]

2021-09-27 Thread Joe Darcy
> Follow-up changes to JDK-8231334. , augmentations to javac's Xlint:serial > checking are out for review (#5709) and various client libraries would need > some changes to pass under the expanded checks. > > The changes are to suppress warnings where non-transient fields in > serializable types

Re: RFR: 8274396: Suppress more warnings on non-serializable non-transient intance fields in client libs

2021-09-27 Thread Sergey Bylokhov
On Mon, 27 Sep 2021 20:21:43 GMT, Joe Darcy wrote: > Follow-up changes to JDK-8231334. , augmentations to javac's Xlint:serial > checking are out for review (#5709) and various client libraries would need > some changes to pass under the expanded checks. > > The changes are to suppress warning

RFR: 8274397: [macOS] Stop setting env. var JAVA_MAIN_CLASS_ in launcher code

2021-09-27 Thread Phil Race
macOS launcher code sets JAVA_MAIN_CLASS_ which is read by AWT to set the name of the application in the system menu bar. Because this set shortly after the VM is running, it causes a thread safety issue described in https://bugs.openjdk.java.net/browse/JDK-8270549 Since the AWT already looks f

Re: RFR: 8274396: Suppress more warnings on non-serializable non-transient intance fields in client libs

2021-09-27 Thread Naoto Sato
On Mon, 27 Sep 2021 20:21:43 GMT, Joe Darcy wrote: > Follow-up changes to JDK-8231334. , augmentations to javac's Xlint:serial > checking are out for review (#5709) and various client libraries would need > some changes to pass under the expanded checks. > > The changes are to suppress warning

Re: RFR: 8274396: Suppress more warnings on non-serializable non-transient intance fields in client libs

2021-09-27 Thread Brian Burkhalter
On Mon, 27 Sep 2021 20:21:43 GMT, Joe Darcy wrote: > Follow-up changes to JDK-8231334. , augmentations to javac's Xlint:serial > checking are out for review (#5709) and various client libraries would need > some changes to pass under the expanded checks. > > The changes are to suppress warning

RFR: 8274396: Suppress more warnings on non-serializable non-transient intance fields in client libs

2021-09-27 Thread Joe Darcy
Follow-up changes to JDK-8231334. , augmentations to javac's Xlint:serial checking are out for review (#5709) and various client libraries would need some changes to pass under the expanded checks. The changes are to suppress warnings where non-transient fields in serializable types are not dec

Integrated: 8274326: [macos] Ensure initialisation of sun/lwawt/macosx/CAccessibility in JavaComponentAccessibility.m

2021-09-27 Thread Phil Race
On Sun, 26 Sep 2021 04:08:06 GMT, Phil Race wrote: > A user with a very minimal swing test case has observed that it is possible > with JDK 17 to get the exception > Exception in thread "AppKit Thread" java.lang.NoSuchMethodError: > accessibilityHitTest > They have confirmed the fix here resolv

Re: RFR: 8262945: [macos] Regression Manual Test for Key Events Fails [v3]

2021-09-27 Thread Alisen Chung
> Added a check for active keyboard language and added support for Russian > NSEvent keyCodes to JavaVirtualKeyCode translation. Originally, only English > characters were checked for even if other languages were in native > letterCharacterSet. Can be easily expanded to include other languages a

Re: RFR: 8272229: BasicSplitPaneDivider:oneTouchExpandableChanged() returns leftButton and rightButton as null with GTKLookAndFeel [v3]

2021-09-27 Thread Pankaj Bansal
> The function documentation for oneTouchExpandableChanged states that the > function does couple of things, but in reality it only does those things if > the Look and Feel supports the supportsOneTouchButtons. In case the Look and > Feel does not support supportsOneTouchButtons, this functions

Re: RFR: 8202056: Expand serial warning to check for bad overloads of serial-related methods and ineffectual fields

2021-09-27 Thread Erik Joelsson
On Mon, 27 Sep 2021 01:00:18 GMT, Joe Darcy wrote: > This is an initial PR for expanded lint warnings done under two bugs: > > 8202056: Expand serial warning to check for bad overloads of serial-related > methods and ineffectual fields > 8160675: Issue lint warning for non-serializable non-tran

Integrated: 8274317: Unnecessary reentrant synchronized block in java.awt.Cursor

2021-09-27 Thread Andrey Turbanov
On Tue, 21 Sep 2021 07:17:43 GMT, Andrey Turbanov wrote: > No need to use 'synchronized(systemCustomCursors)' in 2 places. One is enough. This pull request has now been integrated. Changeset: 7436a77e Author:Andrey Turbanov Committer: Pankaj Bansal URL: https://git.openjdk.java.ne

Re: RFR: 8274326: [macos] Ensure initialisation of sun/lwawt/macosx/CAccessibility in JavaComponentAccessibility.m

2021-09-27 Thread Alexey Ivanov
On Sun, 26 Sep 2021 04:08:06 GMT, Phil Race wrote: > A user with a very minimal swing test case has observed that it is possible > with JDK 17 to get the exception > Exception in thread "AppKit Thread" java.lang.NoSuchMethodError: > accessibilityHitTest > They have confirmed the fix here resolv

RFR: 8202056: Expand serial warning to check for bad overloads of serial-related methods and ineffectual fields

2021-09-27 Thread Joe Darcy
This is an initial PR for expanded lint warnings done under two bugs: 8202056: Expand serial warning to check for bad overloads of serial-related methods and ineffectual fields 8160675: Issue lint warning for non-serializable non-transient instance fields in serializable type to get feedback on