On Wed, 29 Sep 2021 19:48:20 GMT, Alexey Ivanov wrote:
> I made the test and its assertions more flexible in regards to the font size
> and to the number of lines.
>
> The test still requires there are at least four lines so that the text is
> wrapped before the first hard line break; thus at
On Tue, 28 Sep 2021 08:02:12 GMT, Andrey Turbanov
wrote:
> Such casts are actually redundant, but they are inserted, because variable is
> declared with too weak type.
Marked as reviewed by pbansal (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5731
On Wed, 29 Sep 2021 23:16:14 GMT, Jie Fu wrote:
>> Hi all,
>>
>> javax/swing/text/ParagraphView/6364882/bug6364882.java was observed failing
>> on our non-GUI platforms.
>> So I guess it should be marked as headful.
>>
>> Thanks.
>> Best regards,
>> Jie
>
> Will discuss it in https://github.co
On Tue, 28 Sep 2021 08:02:12 GMT, Andrey Turbanov
wrote:
> Such casts are actually redundant, but they are inserted, because variable is
> declared with too weak type.
Marked as reviewed by kizune (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5731
On Tue, 28 Sep 2021 08:02:12 GMT, Andrey Turbanov
wrote:
> Such casts are actually redundant, but they are inserted, because variable is
> declared with too weak type.
Marked as reviewed by serb (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5731
On Tue, 28 Sep 2021 23:39:45 GMT, Jie Fu wrote:
> Hi all,
>
> javax/swing/text/ParagraphView/6364882/bug6364882.java was observed failing
> on our non-GUI platforms.
> So I guess it should be marked as headful.
>
> Thanks.
> Best regards,
> Jie
Will discuss it in https://github.com/openjdk/jd
On Tue, 28 Sep 2021 23:39:45 GMT, Jie Fu wrote:
> Hi all,
>
> javax/swing/text/ParagraphView/6364882/bug6364882.java was observed failing
> on our non-GUI platforms.
> So I guess it should be marked as headful.
>
> Thanks.
> Best regards,
> Jie
This pull request has been closed without being
On Wed, 29 Sep 2021 19:48:20 GMT, Alexey Ivanov wrote:
> I made the test and its assertions more flexible in regards to the font size
> and to the number of lines.
>
> The test still requires there are at least four lines so that the text is
> wrapped before the first hard line break; thus at
On Wed, 29 Sep 2021 22:29:19 GMT, Alisen Chung
wrote:
>> Added a resizing flag when the window is currently being resized to block
>> mouseEntered and mouseExited events from being posted to that window.
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit s
> Added a resizing flag when the window is currently being resized to block
> mouseEntered and mouseExited events from being posted to that window.
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
added check for fullscreen mode to sy
On Fri, 24 Sep 2021 19:49:50 GMT, Sergey Bylokhov wrote:
> I guess the only test which makes sense here is the test for JDK-8013468 and
> it is "problem listed" due to a reflection issue. I suggest checking how it
> works.
This test fails both before and after the change. However, before the c
I made the test and its assertions more flexible in regards to the font size
and to the number of lines.
The test still requires there are at least four lines so that the text is
wrapped before the first hard line break; thus at least one line of text is
justified. This pre-requisite gets broke
On Wed, 29 Sep 2021 13:54:25 GMT, Jie Fu wrote:
>>> The image `editorPane.png` is automatically saved for analysis if the test
>>> fails, you should find in it the test artefacts along with the jtreg test
>>> log.
>>
>> It is not saved on `AssertionError` — my bad.
>> I updated the test so t
On Mon, 27 Sep 2021 13:34:44 GMT, Pankaj Bansal wrote:
>> The function documentation for oneTouchExpandableChanged states that the
>> function does couple of things, but in reality it only does those things if
>> the Look and Feel supports the supportsOneTouchButtons. In case the Look and
>>
On Fri, 17 Sep 2021 15:46:51 GMT, Andrey Turbanov
wrote:
> String.contains was introduced in Java 5.
> Some code in java.desktop still uses old approach with String.indexOf to
> check if String contains specified substring.
> I propose to migrate such usages. Makes code shorter and easier to re
On Wed, 1 Sep 2021 06:31:16 GMT, Sergey Bylokhov wrote:
> At the time Java supported applets and webstart, a special mechanism for
> launching various applications in one JVM was used to reduce memory usage and
> each application was isolated from each other.
>
> This isolation was implemented
On Wed, 29 Sep 2021 16:09:20 GMT, Phil Race wrote:
>> The test is being moved from the closed to open.
>>
>> I updated the `bug6364882.java` test so that it's headless now. If it fails,
>> the image of the `editorPane` is saved for analysis. I also added more
>> asserts which verify:
>>
>> •
On Thu, 23 Sep 2021 19:19:34 GMT, Alexey Ivanov wrote:
> The test is being moved from the closed to open.
>
> I updated the `bug6364882.java` test so that it's headless now. If it fails,
> the image of the `editorPane` is saved for analysis. I also added more
> asserts which verify:
>
> • the
On Thu, 23 Sep 2021 19:19:34 GMT, Alexey Ivanov wrote:
> The test is being moved from the closed to open.
>
> I updated the `bug6364882.java` test so that it's headless now. If it fails,
> the image of the `editorPane` is saved for analysis. I also added more
> asserts which verify:
>
> • the
On Tue, 28 Sep 2021 23:39:45 GMT, Jie Fu wrote:
> Hi all,
>
> javax/swing/text/ParagraphView/6364882/bug6364882.java was observed failing
> on our non-GUI platforms.
> So I guess it should be marked as headful.
>
> Thanks.
> Best regards,
> Jie
There are relevant comments raised by @prrace in
On Wed, 29 Sep 2021 12:25:55 GMT, Alexey Ivanov wrote:
> > The image `editorPane.png` is automatically saved for analysis if the test
> > fails, you should find in it the test artefacts along with the jtreg test
> > log.
>
> It is not saved on `AssertionError` — my bad. I updated the test so t
On Wed, 29 Sep 2021 11:44:49 GMT, Alexey Ivanov wrote:
> The image `editorPane.png` is automatically saved for analysis if the test
> fails, you should find in it the test artefacts along with the jtreg test log.
It is not saved on `AssertionError` — my bad.
I updated the test so that it save
I'd like to use fractional scaling in my swing application on Linux (GTK).
My application already works perfectly with fractional scaling on Windows
(Java seems to abide by the system settings) but on Linux the system
settings are ignored and setting GDK_SCALE only works for integer values.
Could a
On Wed, 29 Sep 2021 11:44:49 GMT, Alexey Ivanov wrote:
>>> It is possible that the test is too strict or this is a jdk bug. But I am
>>> not sure it is possible to investigate this issue based on the bug
>>> description in the JBS. @aivanov-jdk please take a look.
>>
>> Can I problemlist this
On Wed, 29 Sep 2021 01:40:24 GMT, Jie Fu wrote:
>> It is possible that the test is too strict or this is a jdk bug. But I am
>> not sure it is possible to investigate this issue based on the bug
>> description in the JBS.
>> @aivanov-jdk please take a look.
>
>> It is possible that the test is
Such casts are actually redundant, but they are inserted, because variable is
declared with too weak type.
-
Commit messages:
- [PATCH] Too weak variable type leads to unnecessary cast in java.desktop
- [PATCH] Too weak variable type leads to unnecessary cast in java.desktop
Chang
On Tue, 28 Sep 2021 08:02:12 GMT, Andrey Turbanov
wrote:
> Such casts are actually redundant, but they are inserted, because variable is
> declared with too weak type.
src/java.desktop/share/classes/javax/swing/JTree.java line 2046:
> 2044: // expensive!
> 2045:
On Fri, 17 Sep 2021 20:32:00 GMT, Andrey Turbanov
wrote:
> Fields AquaFileSystemModel.fileCache and
> AquaFileSystemModel.FilesLoader.queuedTasks are accessed only under
> synchronized(fileCacheLock).
> It means extract synchronization by Vector is not needed.
Looks fine, please update the co
Fields AquaFileSystemModel.fileCache and
AquaFileSystemModel.FilesLoader.queuedTasks are accessed only under
synchronized(fileCacheLock).
It means extract synchronization by Vector is not needed.
-
Commit messages:
- [PATCH] Unnecessary Vector usage in AquaFileSystemModel
- [PATCH
On Fri, 17 Sep 2021 15:46:51 GMT, Andrey Turbanov
wrote:
> String.contains was introduced in Java 5.
> Some code in java.desktop still uses old approach with String.indexOf to
> check if String contains specified substring.
> I propose to migrate such usages. Makes code shorter and easier to re
On Fri, 17 Sep 2021 15:46:51 GMT, Andrey Turbanov
wrote:
> String.contains was introduced in Java 5.
> Some code in java.desktop still uses old approach with String.indexOf to
> check if String contains specified substring.
> I propose to migrate such usages. Makes code shorter and easier to re
String.contains was introduced in Java 5.
Some code in java.desktop still uses old approach with String.indexOf to check
if String contains specified substring.
I propose to migrate such usages. Makes code shorter and easier to read.
-
Commit messages:
- [PATCH] Use String.contains(
On Wed, 29 Sep 2021 04:13:52 GMT, Prasanta Sadhukhan
wrote:
> Why it is considered a workaround? There are many instances where we use
> [ThreadUtilities performOnMainThreadWaiting:NO block:^()
It is a workaround because it does not fix the hang, but just skips part of the
functionality. Sinc
33 matches
Mail list logo
