On Thu, 26 Aug 2021 07:18:43 GMT, Pankaj Bansal wrote:
> The function documentation for oneTouchExpandableChanged states that the
> function does couple of things, but in reality it only does those things if
> the Look and Feel supports the supportsOneTouchButtons. In case the Look and
> Feel
On Fri, 8 Oct 2021 13:05:34 GMT, Pankaj Bansal wrote:
>> The function documentation for oneTouchExpandableChanged states that the
>> function does couple of things, but in reality it only does those things if
>> the Look and Feel supports the supportsOneTouchButtons. In case the Look and
>> F
On Sat, 2 Oct 2021 09:14:49 GMT, Andrey Turbanov
wrote:
> Flipping arguments of 'equals' method, allows simplifying boolean
> expressions: now we can remove redundant null check before.
This pull request has now been integrated.
Changeset: f640c7aa
Author:Andrey Turbanov
Committer: Serge
On Fri, 8 Oct 2021 13:05:34 GMT, Pankaj Bansal wrote:
>> The function documentation for oneTouchExpandableChanged states that the
>> function does couple of things, but in reality it only does those things if
>> the Look and Feel supports the supportsOneTouchButtons. In case the Look and
>> F
On Thu, 9 Sep 2021 06:53:13 GMT, Andrey Turbanov
wrote:
> StringBuffer is a legacy synchronized class. StringBuilder is a direct
> replacement to StringBuffer which generally have better performance
src/jdk.jpackage/share/classes/jdk/jpackage/internal/Log.java line 117:
> 115:
> 116:
On Thu, 26 Aug 2021 22:10:52 GMT, Sergey Bylokhov wrote:
>> The function documentation for oneTouchExpandableChanged states that the
>> function does couple of things, but in reality it only does those things if
>> the Look and Feel supports the supportsOneTouchButtons. In case the Look and
>
On Fri, 8 Oct 2021 19:15:39 GMT, Sergey Bylokhov wrote:
>> As far as I can see, it was. [Line
>> 64](https://github.com/stsypanov/jdk/blob/d13ca9004b8e45f7df57c849271f3cfda5c43ec9/src/java.desktop/share/classes/com/sun/imageio/plugins/tiff/TIFFIFD.java#L64):
>>
>> essentialTags = Se
On Fri, 8 Oct 2021 18:44:41 GMT, Alexey Ivanov wrote:
>> @jayathirthrao @stsypanov Looks like this was not addressed? It will be
>> good to include it in some future cleanup.
>
> As far as I can see, it was. [Line
> 64](https://github.com/stsypanov/jdk/blob/d13ca9004b8e45f7df57c849271f3cfda5c
On Fri, 8 Oct 2021 15:41:25 GMT, Alisen Chung
wrote:
> > If we do not need to synthesize additional events then why do you see a
> > difference in behavior before/after the fix here: [#5497
> > (comment)](https://github.com/openjdk/jdk/pull/5497#issuecomment-930588684)
> > ?
>
> The case I t
On Fri, 8 Oct 2021 18:35:53 GMT, Sergey Bylokhov wrote:
>> I still suggest to remove the local tag completely.
>
> @jayathirthrao @stsypanov Looks like this was not addressed? It will be
> good to include it in some future cleanup.
As far as I can see, it was. [Line
64](https://github.com/st
On Sun, 26 Sep 2021 20:57:58 GMT, Sergey Bylokhov wrote:
>> Agree.
>
> I still suggest to remove the local tag completely.
@jayathirthrao @stsypanov Looks like this was not addressed? It will be good
to include it in some future cleanup.
-
PR: https://git.openjdk.java.net/jdk/pu
On Fri, 20 Aug 2021 09:41:15 GMT, Сергей Цыпанов
wrote:
> This is a continuation of
>
> - https://bugs.openjdk.java.net/browse/JDK-6736490
> - https://bugs.openjdk.java.net/browse/JDK-8035284
> - https://bugs.openjdk.java.net/browse/JDK-8145680
> - https://bugs.openjdk.java.net/browse/JDK-82515
On Fri, 1 Oct 2021 22:28:10 GMT, Alisen Chung
wrote:
>> Added a resizing flag when the window is currently being resized to block
>> mouseEntered and mouseExited events from being posted to that window.
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit si
On Sat, 25 Sep 2021 19:30:31 GMT, Сергей Цыпанов
wrote:
>> This is a continuation of
>>
>> - https://bugs.openjdk.java.net/browse/JDK-6736490
>> - https://bugs.openjdk.java.net/browse/JDK-8035284
>> - https://bugs.openjdk.java.net/browse/JDK-8145680
>> - https://bugs.openjdk.java.net/browse/JDK
Please review this small cleanup change.
Looks like expandPacked and extendEdge from awt_ImagingLib.c are
unreferenced/unused and can be removed.
Thanks, Matthias
-
Commit messages:
- JDK-8274977
Changes: https://git.openjdk.java.net/jdk/pull/5866/files
Webrev: https://webrevs.op
On Fri, 8 Oct 2021 13:05:34 GMT, Pankaj Bansal wrote:
>> The function documentation for oneTouchExpandableChanged states that the
>> function does couple of things, but in reality it only does those things if
>> the Look and Feel supports the supportsOneTouchButtons. In case the Look and
>> F
> The function documentation for oneTouchExpandableChanged states that the
> function does couple of things, but in reality it only does those things if
> the Look and Feel supports the supportsOneTouchButtons. In case the Look and
> Feel does not support supportsOneTouchButtons, this functions
On Tue, 5 Oct 2021 09:26:00 GMT, Prasanta Sadhukhan
wrote:
>> Pankaj Bansal has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Changes according to JBS discussion
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSplitPaneDivi
> The function documentation for oneTouchExpandableChanged states that the
> function does couple of things, but in reality it only does those things if
> the Look and Feel supports the supportsOneTouchButtons. In case the Look and
> Feel does not support supportsOneTouchButtons, this functions
On Tue, 24 Aug 2021 15:49:00 GMT, Alexander Scherbatiy
wrote:
>> The issue is reproduced on macOS Big Sur 11.0.1 with jdk 16.0.1+9.
>>
>> Create a native macOS app from the Hello.java file, sign and run it in
>> sandbox:
>>
>> import javax.print.*;
>> import javax.swing.*;
>>
>> public class
In JDK 9 the native code for the robot class was reworked to get an access to
the HiDPI quality screenshots. So we allocate the data storage for the HiDPI
quality and then request the best quality from the macOS.
It works fine if the user request the screenshot of some area, since we
properly s
On Thu, 7 Oct 2021 12:39:10 GMT, Andrey Turbanov
wrote:
> Pass cause exception as constructor parameter is shorter and easier to read.
Marked as reviewed by pbansal (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5847
On Thu, 7 Oct 2021 12:39:10 GMT, Andrey Turbanov
wrote:
> Pass cause exception as constructor parameter is shorter and easier to read.
Marked as reviewed by serb (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5847
On Sat, 25 Sep 2021 19:30:31 GMT, Сергей Цыпанов
wrote:
>> This is a continuation of
>>
>> - https://bugs.openjdk.java.net/browse/JDK-6736490
>> - https://bugs.openjdk.java.net/browse/JDK-8035284
>> - https://bugs.openjdk.java.net/browse/JDK-8145680
>> - https://bugs.openjdk.java.net/browse/JDK
On Thu, 7 Oct 2021 12:39:10 GMT, Andrey Turbanov
wrote:
> Pass cause exception as constructor parameter is shorter and easier to read.
Marked as reviewed by jdv (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5847
On Thu, 7 Oct 2021 12:39:10 GMT, Andrey Turbanov
wrote:
> Pass cause exception as constructor parameter is shorter and easier to read.
Looks fine.
-
PR: https://git.openjdk.java.net/jdk/pull/5847
Pass cause exception as constructor parameter is shorter and easier to read.
-
Commit messages:
- [PATCH] Cleanup unnecessary calls to Throwable.initCause() in java.desktop
module
Changes: https://git.openjdk.java.net/jdk/pull/5847/files
Webrev: https://webrevs.openjdk.java.net/?r
27 matches
Mail list logo
