Re: RFR: 7001973: java/awt/Graphics2D/CopyAreaOOB.java fails

2021-10-11 Thread Sergey Bylokhov
On Mon, 13 Sep 2021 11:32:37 GMT, Masanori Yano wrote: > Could you please review the 7001973 fixes? > > On Windows, CopyAreaOOB.java fails with a blank window. The cause of this > problem is that paint() works one time only. Painting area is not guaranteed > when showing a window. > > I think

Re: RFR: 8274893: Update java.desktop classes to use try-with-resources

2021-10-11 Thread Sergey Bylokhov
On Tue, 5 Oct 2021 08:13:53 GMT, Andrey Turbanov wrote: > 8274893: Update java.desktop classes to use try-with-resources src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/Metacity.java line 587: > 585: // Pending: verify character encoding spec for gconf > 586:

Re: RFR: JDK-8274977: Remove expandPacked and extendEdge from awt_ImagingLib.c

2021-10-11 Thread Sergey Bylokhov
On Mon, 11 Oct 2021 06:51:58 GMT, Matthias Baesken wrote: > both functions expandPacked and extendEdge are already unused/unreferenced in > jdk11u. So I wonder what usages are planned for them and when. It is necessary to dig into the history of this file, and related bugs in JBS to say how th

Re: RFR: 8269698: Specification for methods of java.awt.im.InputContext should mention that they do nothing [v2]

2021-10-11 Thread Sergey Bylokhov
On Sat, 9 Oct 2021 11:16:29 GMT, Alexander Zvegintsev wrote: >> This fix simply describes that the `java.awt.im.InputContext` is a dummy >> implementation, which may not conform its spec. > > Alexander Zvegintsev has updated the pull request incrementally with one > additional commit since the

Re: RFR: 8274032 : Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/ImagePrinting/ImageTypes.java & show test UI [v3]

2021-10-11 Thread Sergey Bylokhov
On Mon, 4 Oct 2021 14:46:35 GMT, lawrence.andrews wrote: >> Problem : >> 1) Testcase was failing due to parse exception yesno >> 2) After removing yesno tag test frame and immediately get disposed >> >> Fix : >> 1) Removed yesno tag >> 2) Show the test frame with pass, fail button. Now user c

Integrated: 8274945: Cleanup unnecessary calls to Throwable.initCause() in java.desktop

2021-10-11 Thread Andrey Turbanov
On Thu, 7 Oct 2021 12:39:10 GMT, Andrey Turbanov wrote: > Pass cause exception as constructor parameter is shorter and easier to read. This pull request has now been integrated. Changeset: 829dea45 Author:Andrey Turbanov Committer: Pankaj Bansal URL: https://git.openjdk.java.net/jd

Re: RFR: 8274898: Cleanup usages of StringBuffer in jdk tools modules

2021-10-11 Thread Andrey Turbanov
On Fri, 8 Oct 2021 19:38:57 GMT, Сергей Цыпанов wrote: >> StringBuffer is a legacy synchronized class. StringBuilder is a direct >> replacement to StringBuffer which generally have better performance > > src/jdk.jpackage/share/classes/jdk/jpackage/internal/Log.java line 117: > >> 115: >> 116:

Re: RFR: 8274898: Cleanup usages of StringBuffer in jdk tools modules

2021-10-11 Thread Сергей Цыпанов
On Mon, 11 Oct 2021 18:52:13 GMT, Andrey Turbanov wrote: >> src/jdk.jpackage/share/classes/jdk/jpackage/internal/Log.java line 117: >> >>> 115: >>> 116: for (String s : strings) { >>> 117: sb.append(" " + s); >> >> Shouldn't it be `sb.append(" ").append(s)`?

Re: RFR: 8274898: Cleanup usages of StringBuffer in jdk tools modules

2021-10-11 Thread Сергей Цыпанов
On Thu, 9 Sep 2021 06:53:13 GMT, Andrey Turbanov wrote: > StringBuffer is a legacy synchronized class. StringBuilder is a direct > replacement to StringBuffer which generally have better performance Marked as reviewed by stsypa...@github.com (no known OpenJDK username). - PR: http

Re: RFR: 8271071 accessibility of a table on macOS lacks cell navigation [v5]

2021-10-11 Thread Victor Dyakov
On Thu, 30 Sep 2021 12:02:08 GMT, Artem Semenov wrote: >> We've extended the current implementation of TableAccessibility to make sure >> that individual cells are voiced when navigating with the keyboard. > > Artem Semenov has refreshed the contents of this pull request, and previous > commits

Re: RFR: 8271071 accessibility of a table on macOS lacks cell navigation [v5]

2021-10-11 Thread Alexander Zuev
On Thu, 30 Sep 2021 12:02:08 GMT, Artem Semenov wrote: >> We've extended the current implementation of TableAccessibility to make sure >> that individual cells are voiced when navigating with the keyboard. > > Artem Semenov has refreshed the contents of this pull request, and previous > commits