Re: RFR: 8275106: Cleanup Iterator usages in java.desktop

2021-10-14 Thread Pankaj Bansal
On Fri, 8 Oct 2021 19:37:35 GMT, Andrey Turbanov wrote: > Cycles with 'Iterator' are error-prone. It's better to use more high-level > code, which easier to read. > We can use enhanced-for or Collection.removeIf Marked as reviewed by pbansal (Reviewer). - PR: https://git.openjdk.j

Re: RFR: 8271071 accessibility of a table on macOS lacks cell navigation [v5]

2021-10-14 Thread Pankaj Bansal
On Thu, 30 Sep 2021 12:02:08 GMT, Artem Semenov wrote: >> We've extended the current implementation of TableAccessibility to make sure >> that individual cells are voiced when navigating with the keyboard. > > Artem Semenov has refreshed the contents of this pull request, and previous > commits

Integrated: 8041125: ColorConvertOp filter much slower in JDK 8 compared to JDK7

2021-10-14 Thread Sergey Bylokhov
On Wed, 6 Oct 2021 08:41:38 GMT, Sergey Bylokhov wrote: > We have improved the cmm code over a few releases and mostly resolve the > JDK-8041125. But I have executed an attached test case under a profiler and > found that: > > * less than 10% is an actual pixel transformation inside littlecms

Result: CFV: New Client Libraries Group Member : Pankaj Bansal (pbansal)

2021-10-14 Thread Philip Race
The vote for Pankaj BansalĀ  [1] is now closed. Yes: 4 Veto: 0 Abstain: 0 According to the OpenJDK Bylaws definition of Lazy Consensus [2], this is sufficient to approve the nomination. -phil. [1] https://mail.openjdk.java.net/pipermail/client-libs-dev/2021-September/000503.html [2] http://op

Result : CFV: New Client Libraries Group Member : Prasanta Sadhukhan (psadhukhan)

2021-10-14 Thread Philip Race
The vote for Prasanta Sadhukhan [1] is now closed. Yes: 4 Veto: 0 Abstain: 0 According to the OpenJDK Bylaws definition of Lazy Consensus [2], this is sufficient to approve the nomination. -phil. [1] https://mail.openjdk.java.net/pipermail/client-libs-dev/2021-September/000502.html [2] http:

Re: RFR: 8275165 : ProblemList InterpolationQualityTest.java

2021-10-14 Thread Phil Race
On Wed, 13 Oct 2021 17:02:03 GMT, lawrence.andrews wrote: > InterpolationQualityTest.java test fails consistently on windows 10 hence > adding it in the problemList. > > @shurymury So it reports the Microsoft Basic Render Driver .. - PR: https://git.openjdk.java.net/jdk/pull/593

Re: RFR: 8275165 : ProblemList InterpolationQualityTest.java

2021-10-14 Thread Phil Race
On Wed, 13 Oct 2021 17:02:03 GMT, lawrence.andrews wrote: > InterpolationQualityTest.java test fails consistently on windows 10 hence > adding it in the problemList. > > @shurymury So the way the check is done, we exclude D3D if it is known to be bad hardware. ie it is an exclude list, not a

Re: RFR: 8262945: [macos] Regression Manual Test for Key Events Fails [v3]

2021-10-14 Thread Alisen Chung
On Mon, 27 Sep 2021 16:19:21 GMT, Alisen Chung wrote: >> Added a check for active keyboard language and added support for Russian >> NSEvent keyCodes to JavaVirtualKeyCode translation. Originally, only English >> characters were checked for even if other languages were in native >> letterChara

Re: RFR: 8185429: [macos] After the dialog is closed, there is no window become active.

2021-10-14 Thread Alisen Chung
On Wed, 13 Oct 2021 20:02:10 GMT, Sergey Bylokhov wrote: >> Yea, that makes sense. I'm stuck on how to check for whether the blocker >> window was in focus since by the time setModalBlocked(false) is called the >> blocker window is no longer in focus. Do you have any suggestions on how to >> a

RFR: 8185429: [macos] After the dialog is closed, there is no window become active.

2021-10-14 Thread Alisen Chung
After a modal dialog is closed, its parent window should be pushed to the front and made key. - Commit messages: - removed from ProblemList.txt - 8185429: [macos] After the dialog is closed, there is no window become active. Changes: https://git.openjdk.java.net/jdk/pull/5884/fil

Re: RFR: 8185429: [macos] After the dialog is closed, there is no window become active.

2021-10-14 Thread Sergey Bylokhov
On Wed, 13 Oct 2021 18:48:50 GMT, Alisen Chung wrote: >> src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java line >> 1032: >> >>> 1030: execute(ptr -> nativePushNSWindowToFront(ptr)); >>> 1031: } >>> 1032: >> >> Do not we need to push the previously block

Re: RFR: 8185429: [macos] After the dialog is closed, there is no window become active.

2021-10-14 Thread Alisen Chung
On Sun, 10 Oct 2021 22:06:17 GMT, Sergey Bylokhov wrote: >> After a modal dialog is closed, its parent window should be pushed to the >> front and made key. > > src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java line > 1032: > >> 1030: execute(ptr -> nativePushNS

Re: RFR: 8185429: [macos] After the dialog is closed, there is no window become active.

2021-10-14 Thread Sergey Bylokhov
On Sun, 10 Oct 2021 21:26:05 GMT, Alisen Chung wrote: > After a modal dialog is closed, its parent window should be pushed to the > front and made key. src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java line 1032: > 1030: execute(ptr -> nativePushNSWindowToFront(

Re: RFR: 8185429: [macos] After the dialog is closed, there is no window become active.

2021-10-14 Thread Kevin Rushforth
On Sun, 10 Oct 2021 21:26:05 GMT, Alisen Chung wrote: > After a modal dialog is closed, its parent window should be pushed to the > front and made key. The error in the ProblemList reported in the Description is preventing this PR from being `rfr`. I filed [SKARA-1217](https://bugs.openjdk.ja

Re: RFR: 8185429: [macos] After the dialog is closed, there is no window become active.

2021-10-14 Thread Victor Dyakov
On Sun, 10 Oct 2021 21:26:05 GMT, Alisen Chung wrote: > After a modal dialog is closed, its parent window should be pushed to the > front and made key. @prsadhuk please review @azuev-java please review this JBS ID is referenced in the problem list, so the problem list file should be update

Re: RFR: 8275165 : ProblemList InterpolationQualityTest.java

2021-10-14 Thread Phil Race
On Wed, 13 Oct 2021 17:02:03 GMT, lawrence.andrews wrote: > InterpolationQualityTest.java test fails consistently on windows 10 hence > adding it in the problemList. > > @shurymury Yes I was also very surprised to see this stable test fail. FWIW - when connecting by VNC the VM doesn't enume

Re: RFR: 8275165 : ProblemList InterpolationQualityTest.java

2021-10-14 Thread Phil Race
On Wed, 13 Oct 2021 17:02:03 GMT, lawrence.andrews wrote: > InterpolationQualityTest.java test fails consistently on windows 10 hence > adding it in the problemList. > > @shurymury This VM can't possibly be reporting an AMD or Nvidia D3D card can it ?? That's the only two cases we should be e

Re: RFR: 8275165 : ProblemList InterpolationQualityTest.java

2021-10-14 Thread lawrence . andrews
On Wed, 13 Oct 2021 17:02:03 GMT, lawrence.andrews wrote: > InterpolationQualityTest.java test fails consistently on windows 10 hence > adding it in the problemList. > > @shurymury Its a latest window on a new VM. Checking the VM's graphic system configuration. I checked the VM graphics con

Re: RFR: 8275165 : ProblemList InterpolationQualityTest.java

2021-10-14 Thread lawrence . andrews
On Wed, 13 Oct 2021 18:10:43 GMT, Sergey Bylokhov wrote: >> InterpolationQualityTest.java test fails consistently on windows 10 hence >> adding it in the problemList. >> >> @shurymury > > I remember this test was(and is) quite stable, did you check what is the > reason of the failure. Is it po

RFR: 8275165 : ProblemList InterpolationQualityTest.java

2021-10-14 Thread lawrence . andrews
InterpolationQualityTest.java test fails consistently on windows 10 hence adding it in the problemList. @shurymury - Commit messages: - Added the right test case failure bugid - 8275165 : ProblemList InterpolationQualityTest.java Changes: https://git.openjdk.java.net/jdk/pull/593

Re: RFR: 8275165 : ProblemList InterpolationQualityTest.java

2021-10-14 Thread Sergey Bylokhov
On Wed, 13 Oct 2021 17:02:03 GMT, lawrence.andrews wrote: > InterpolationQualityTest.java test fails consistently on windows 10 hence > adding it in the problemList. > > @shurymury I remember this test was(and is) quite stable, did you check what is the reason of the failure. Is it possible