On Thu, 21 Oct 2021 05:57:30 GMT, Alexander Zuev wrote:
>> test/jdk/java/awt/Mouse/GetMousePositionTest/GetMousePositionWithOverlay.java
>> line 52:
>>
>>> 50: doTest();
>>> 51: } catch (Exception e) {
>>> 52: if (e instanceof RuntimeException) {
>>
>> Do we nee
On Thu, 21 Oct 2021 04:24:11 GMT, Prasanta Sadhukhan
wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Call dispose() from the test final block. Also added original exception to
>> the unexpected exception handle
On Wed, 20 Oct 2021 07:18:06 GMT, Sergey Bylokhov wrote:
>> This test was added under https://bugs.openjdk.java.net/browse/JDK-8255722
>> to verify rotated blit operation. But it started failing XRender pipeline
>> because of pixel color mismatch. Looks like we have minor difference in
>> pixe
On Wed, 20 Oct 2021 14:04:32 GMT, Alexander Zuev wrote:
>> 8168388: GetMousePositionTest fails with the message "Mouse position should
>> not be null"
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Call dispose() from t
Looks like the test does not fail anymore.
However some cleanup was made:
- fixed wildcard imports
- frame centered and explicitly disposed at the end
- removed unused `setAutoDelay()` call (no key/mouse key events generated)
- improved variable naming
Testing still green.
-
Commit
On Wed, 20 Oct 2021 16:48:41 GMT, Phil Race wrote:
>> The code this test exercises is very obsolete. So this removes the test that
>> triggers it along with that code.
>
> Phil Race has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8198336:
On Wed, 20 Oct 2021 14:04:32 GMT, Alexander Zuev wrote:
>> 8168388: GetMousePositionTest fails with the message "Mouse position should
>> not be null"
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Call dispose() from t
On Wed, 20 Oct 2021 16:42:41 GMT, Alexander Zvegintsev
wrote:
>> test/jdk/java/awt/Mixing/MixingOnDialog.java line 71:
>>
>>> 69: // Overlap the buttons
>>> 70: heavy.setBounds(130, 130, 200, 200);
>>> 71: light.setBounds(110, 110, 50, 50);
>>
>> Probably you can call s
On Thu, 17 Jun 2021 09:29:07 GMT, Toshio Nakamura wrote:
>> Hi,
>>
>> Could you review the fix?
>> When non-English characters were printed from JTable on MacOS,
>> CTextPipe.doDrawGlyphs was called by OSXSurfaceData.drawGlyphs. However,
>> CTextPipe seems not support glyph with slot number of
> Hi,
>
> Could you review the fix?
> When non-English characters were printed from JTable on MacOS,
> CTextPipe.doDrawGlyphs was called by OSXSurfaceData.drawGlyphs. However,
> CTextPipe seems not support glyph with slot number of composite fonts.
>
> The slot data mask of GlyphVector is 0xff0
On Tue, 19 Oct 2021 17:27:03 GMT, Alisen Chung wrote:
> added export java.desktop/sun.lwawt.macosx:open
This pull request has now been integrated.
Changeset: d1e3ca4e
Author:Alisen Chung
Committer: Phil Race
URL:
https://git.openjdk.java.net/jdk/commit/d1e3ca4ee35bf4c2ce9b6dae2518f
On Tue, 19 Oct 2021 17:27:03 GMT, Alisen Chung wrote:
> added export java.desktop/sun.lwawt.macosx:open
Marked as reviewed by prr (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6022
> The code this test exercises is very obsolete. So this removes the test that
> triggers it along with that code.
Phil Race has updated the pull request incrementally with one additional commit
since the last revision:
8198336: java/awt/FontMetrics/FontCrash.java fails in headless mode
On Wed, 20 Oct 2021 06:58:41 GMT, Sergey Bylokhov wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8198336: java/awt/FontMetrics/FontCrash.java fails in headless mode
>
> src/java.desktop/windows/classes/sun/awt/window
On Tue, 19 Oct 2021 14:12:24 GMT, Alexander Zvegintsev
wrote:
> Looks like this test does not fail anymore.
>
> It does not fail once even without changes, but I've added extra
> `waitForIdle()` just for safety.
>
> Checked on ~350 test runs.
This pull request has now been integrated.
Chang
On Wed, 20 Oct 2021 12:52:55 GMT, Prasanta Sadhukhan
wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - d.setLocationRelativeTo(null);
>> - increase auto delay
>
> test/jdk/java/awt/Mixing/MixingOnDialog.j
> Looks like the test started failing after increasing of window's title height
> in Ubuntu theme:
>
> 
> So the click happens on windows title instead of the button.
>
> For example, m
On Wed, 20 Oct 2021 08:57:43 GMT, Prasanta Sadhukhan
wrote:
> SInce you are touching the test, maybe you can consider calling dispose in
> finally block rather than being called so many times in the test.
Fixed.
-
PR: https://git.openjdk.java.net/jdk/pull/6028
> 8168388: GetMousePositionTest fails with the message "Mouse position should
> not be null"
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Call dispose() from the test final block. Also added original exception to
the unexpected
On Wed, 20 Oct 2021 12:05:57 GMT, Alexander Zvegintsev
wrote:
> Looks like the test started failing after increasing of window's title height
> in Ubuntu theme:
>
> 
> So the click ha
On Wed, 20 Oct 2021 11:53:33 GMT, Alexander Zvegintsev
wrote:
>> Looks like this test does not fail anymore.
>>
>> It does not fail once even without changes, but I've added extra
>> `waitForIdle()` just for safety.
>>
>> Checked on ~350 test runs.
>
> Alexander Zvegintsev has updated the pul
Looks like the test started failing after increasing of window's title height
in Ubuntu theme:
So the click happens on windows title instead of the button.
For example, macOS has small
> Looks like this test does not fail anymore.
>
> It does not fail once even without changes, but I've added extra
> `waitForIdle()` just for safety.
>
> Checked on ~350 test runs.
Alexander Zvegintsev has updated the pull request incrementally with one
additional commit since the last revisio
On Wed, 20 Oct 2021 08:44:38 GMT, Alexander Zuev wrote:
>> 8168388: GetMousePositionTest fails with the message "Mouse position should
>> not be null"
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removed regtesthepler
> 8168388: GetMousePositionTest fails with the message "Mouse position should
> not be null"
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Removed regtesthepler library requirement
-
Changes:
- all: https://git.op
On Wed, 20 Oct 2021 07:26:04 GMT, Sergey Bylokhov wrote:
> Please confirm that an updated test still can be used for JDK-8012026.
Yes it does. In general the logic of the test has not changed i just removed
false negative due to the mouse position was overlapped by the WM window
decorations.
On Wed, 20 Oct 2021 07:22:11 GMT, Prasanta Sadhukhan
wrote:
>> 8168388: GetMousePositionTest fails with the message "Mouse position should
>> not be null"
>
> test/jdk/java/awt/Mouse/GetMousePositionTest/GetMousePositionWithOverlay.java
> line 50:
>
>> 48:
>> 49: try {
>> 50:
On Wed, 20 Oct 2021 07:22:02 GMT, Prasanta Sadhukhan
wrote:
>> 8168388: GetMousePositionTest fails with the message "Mouse position should
>> not be null"
>
> test/jdk/java/awt/Mouse/GetMousePositionTest/GetMousePositionWithOverlay.java
> line 34:
>
>> 32: * @key headful
>> 33: * @bug 80120
On Wed, 20 Oct 2021 07:04:18 GMT, Alexander Zuev wrote:
> 8168388: GetMousePositionTest fails with the message "Mouse position should
> not be null"
Please confirm that an updated test still can be used for JDK-8012026.
-
PR: https://git.openjdk.java.net/jdk/pull/6028
On Wed, 20 Oct 2021 07:04:18 GMT, Alexander Zuev wrote:
> 8168388: GetMousePositionTest fails with the message "Mouse position should
> not be null"
test/jdk/java/awt/Mouse/GetMousePositionTest/GetMousePositionWithOverlay.java
line 34:
> 32: * @key headful
> 33: * @bug 8012026 8196435
> 34:
On Tue, 19 Oct 2021 09:56:07 GMT, Jayathirth D V wrote:
> This test was added under https://bugs.openjdk.java.net/browse/JDK-8255722 to
> verify rotated blit operation. But it started failing XRender pipeline
> because of pixel color mismatch. Looks like we have minor difference in pixel
> col
8168388: GetMousePositionTest fails with the message "Mouse position should not
be null"
-
Commit messages:
- 8168388: GetMousePositionTest fails with the message "Mouse position should
not be null"
Changes: https://git.openjdk.java.net/jdk/pull/6028/files
Webrev: https://webrevs
On Wed, 20 Oct 2021 07:04:18 GMT, Alexander Zuev wrote:
> 8168388: GetMousePositionTest fails with the message "Mouse position should
> not be null"
The main reason is that the second test frame is so small that if Window
Manager decorations are tall enough mouse ended up on top of the frame b
On Wed, 20 Oct 2021 04:12:46 GMT, Phil Race wrote:
> The code this test exercises is very obsolete. So this removes the test that
> triggers it along with that code.
src/java.desktop/windows/classes/sun/awt/windows/WToolkit.java line 696:
> 694: && ((SunFontManager) fm).usePlatform
On Tue, 19 Oct 2021 20:20:00 GMT, Alexander Zvegintsev
wrote:
>> Looks like this test does not fail anymore.
>>
>> It does not fail once even without changes, but I've added extra
>> `waitForIdle()` just for safety.
>>
>> Checked on ~350 test runs.
>
> Alexander Zvegintsev has updated the pul
35 matches
Mail list logo
