Integrated: 8275344: -Xcheck:jni produces some warnings in the LCMS.c

2021-10-21 Thread Sergey Bylokhov
On Sun, 17 Oct 2021 00:09:12 GMT, Sergey Bylokhov wrote: > The newly added test MTTransformReplacedProfile(yeah that test again) produce > some warning if check:jni is enabled: > > WARNING in native method: JNI call made with exception pending > at sun.java2d.cmm.lcms.LCMS.setTagDataNative(java

Re: RFR: 8202932: java/awt/Component/NativeInLightShow/NativeInLightShow.java fails [v2]

2021-10-21 Thread Sergey Bylokhov
On Thu, 21 Oct 2021 10:57:28 GMT, Alexander Zvegintsev wrote: >> Looks like the test does not fail anymore. >> >> However some cleanup was made: >> >> - fixed wildcard imports >> - frame centered and explicitly disposed at the end >> - removed unused `setAutoDelay()` call (no key/mouse key eve

RFR: 8275715: D3D pipeline processes multiple PaintEvent at initial drawing

2021-10-21 Thread Masanori Yano
Could you please review the 8275715 bug fixes? I think D3DScreenUpdateManager posts unnecessary PaintEvent during processing PaintEvent. When the validate method is called from createGraphics, repaintPeerTarget should not be called. - Commit messages: - 8275715: D3D pipeline proce

Re: RFR: 8202932: java/awt/Component/NativeInLightShow/NativeInLightShow.java fails [v2]

2021-10-21 Thread Alexander Zvegintsev
> Looks like the test does not fail anymore. > > However some cleanup was made: > > - fixed wildcard imports > - frame centered and explicitly disposed at the end > - removed unused `setAutoDelay()` call (no key/mouse key events generated) > - improved variable naming > > Testing still green. A

Integrated: 8168388: GetMousePositionTest fails with the message "Mouse position should not be null"

2021-10-21 Thread Alexander Zuev
On Wed, 20 Oct 2021 07:04:18 GMT, Alexander Zuev wrote: > 8168388: GetMousePositionTest fails with the message "Mouse position should > not be null" This pull request has now been integrated. Changeset: 0c3eaea1 Author:Alexander Zuev URL: https://git.openjdk.java.net/jdk/commit/0c3

Re: RFR: 8168388: GetMousePositionTest fails with the message "Mouse position should not be null" [v4]

2021-10-21 Thread Prasanta Sadhukhan
On Thu, 21 Oct 2021 09:06:30 GMT, Alexander Zuev wrote: >> 8168388: GetMousePositionTest fails with the message "Mouse position should >> not be null" > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > > Remove catch block M

Re: RFR: 8168388: GetMousePositionTest fails with the message "Mouse position should not be null" [v4]

2021-10-21 Thread Alexander Zuev
> 8168388: GetMousePositionTest fails with the message "Mouse position should > not be null" Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Remove catch block - Changes: - all: https://git.openjdk.java.net/jdk/pull

Re: RFR: 8168388: GetMousePositionTest fails with the message "Mouse position should not be null" [v3]

2021-10-21 Thread Alexander Zuev
On Thu, 21 Oct 2021 06:10:56 GMT, Prasanta Sadhukhan wrote: >> The catch block was already there and i decided not to remove it and moved >> the rest of the code instead of the try block. > > I know it was already there but since you are touching the test, it might be > better to better the co

Re: RFR: 8225777: java/awt/Mixing/MixingOnDialog.java fails on Ubuntu [v2]

2021-10-21 Thread Sergey Bylokhov
On Thu, 21 Oct 2021 01:34:01 GMT, Sergey Bylokhov wrote: >> Yes, `setUndecorated` is one of possible solutions, however it looks equal >> to changing location. >> >> Updated the delay and dialog's location. > > Can you please double-check all Mixing tests, some of the problem listed, but > I t

Re: RFR: 7001973: java/awt/Graphics2D/CopyAreaOOB.java fails

2021-10-21 Thread Masanori Yano
On Tue, 12 Oct 2021 06:27:14 GMT, Sergey Bylokhov wrote: >> Could you please review the 7001973 fixes? >> >> On Windows, CopyAreaOOB.java fails with a blank window. The cause of this >> problem is that paint() works one time only. Painting area is not guaranteed >> when showing a window. >> >

Re: RFR: 8202932: java/awt/Component/NativeInLightShow/NativeInLightShow.java fails

2021-10-21 Thread Sergey Bylokhov
On Thu, 21 Oct 2021 02:04:01 GMT, Alexander Zvegintsev wrote: > Looks like the test does not fail anymore. > > However some cleanup was made: > > - fixed wildcard imports > - frame centered and explicitly disposed at the end > - removed unused `setAutoDelay()` call (no key/mouse key events gen