Re: RFR: 8017175: [TESTBUG] javax/swing/JPopupMenu/4634626/bug4634626.java sometimes failed on mac [v2]

2021-10-26 Thread Prasanta Sadhukhan
On Wed, 27 Oct 2021 05:15:32 GMT, Alexander Zuev wrote: >> Moved Swing component modification to the EDT. >> Increased wait time for popup to show up. >> Made checking variabled volatile. >> Generic code cleanup. >> Removed the test from ProblemList.txt > > Alexander Zuev has updated the pull req

Re: RFR: 8017175: [TESTBUG] javax/swing/JPopupMenu/4634626/bug4634626.java sometimes failed on mac [v2]

2021-10-26 Thread Prasanta Sadhukhan
On Wed, 27 Oct 2021 05:18:08 GMT, Prasanta Sadhukhan wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Moving access to the popup visibility status to EDT > > test/jdk/javax/swing/JPopupMenu/4634626/bug4634626.jav

Re: RFR: 8017175: [TESTBUG] javax/swing/JPopupMenu/4634626/bug4634626.java sometimes failed on mac [v2]

2021-10-26 Thread Alexander Zuev
> Moved Swing component modification to the EDT. > Increased wait time for popup to show up. > Made checking variabled volatile. > Generic code cleanup. > Removed the test from ProblemList.txt Alexander Zuev has updated the pull request incrementally with one additional commit since the last revi

Re: RFR: 8017175: [TESTBUG] javax/swing/JPopupMenu/4634626/bug4634626.java sometimes failed on mac [v2]

2021-10-26 Thread Alexander Zuev
On Wed, 27 Oct 2021 01:41:30 GMT, Sergey Bylokhov wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Moving access to the popup visibility status to EDT > > test/jdk/javax/swing/JPopupMenu/4634626/bug4634626.java li

Re: RFR: 8275851: Deproblemlist open/test/jdk/javax/swing/JComponent/6683775/bug6683775.java [v2]

2021-10-26 Thread Prasanta Sadhukhan
> Test was problemlisted long time back by JDK-8193211 but it is passing > now..Modified testFrame access in EDT and dispose in finally block for better > safeguard. Problemlisted test was marked for 8u so did not close it.. > Several iterations of the test pass in all platforms in mainline.. Pr

Re: RFR: 8275851: Deproblemlist open/test/jdk/javax/swing/JComponent/6683775/bug6683775.java [v2]

2021-10-26 Thread Prasanta Sadhukhan
On Wed, 27 Oct 2021 01:52:35 GMT, Sergey Bylokhov wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Review fix > > test/jdk/javax/swing/JComponent/6683775/bug6683775.java line 89: > >> 87: >> 88: } fi

Integrated: 8202926: Test java/awt/Focus/WindowUpdateFocusabilityTest/WindowUpdateFocusabilityTest.html fails

2021-10-26 Thread Alexander Zvegintsev
On Tue, 26 Oct 2021 18:14:59 GMT, Alexander Zvegintsev wrote: > The test is still failing on Ubuntu 16.04 (`window1` and `window2` are not > placed in front, so they are not receiving events). > > Looks like this was fixed in later releases. I've manually checked this test > on Ubuntu 18.04,

Re: RFR: 8275851: Deproblemlist open/test/jdk/javax/swing/JComponent/6683775/bug6683775.java

2021-10-26 Thread Sergey Bylokhov
On Mon, 25 Oct 2021 06:47:38 GMT, Prasanta Sadhukhan wrote: > Test was problemlisted long time back by JDK-8193211 but it is passing > now..Modified testFrame access in EDT and dispose in finally block for better > safeguard. Problemlisted test was marked for 8u so did not close it.. > Several

Re: RFR: 8017175: [TESTBUG] javax/swing/JPopupMenu/4634626/bug4634626.java sometimes failed on mac

2021-10-26 Thread Sergey Bylokhov
On Mon, 25 Oct 2021 12:23:15 GMT, Alexander Zuev wrote: > Moved Swing component modification to the EDT. > Increased wait time for popup to show up. > Made checking variabled volatile. > Generic code cleanup. > Removed the test from ProblemList.txt test/jdk/javax/swing/JPopupMenu/4634626/bug4634

RFR: 8196017: java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails

2021-10-26 Thread Alexander Zuev
The problem here is that due to the approximation of the coordinates when converting to and from screen cordinate system on screen with 125% magnification two things can happen: 1. New mouse position calculated can be 149/149 which is the same as the starting position and system can refuse to ge

Re: RFR: JDK-8275923: Override the LPR path using a system property

2021-10-26 Thread Phil Race
On Wed, 20 Oct 2021 20:38:17 GMT, Rolf van Kleef wrote: > On some select systems, the LPR binary may be placed elsewhere (for example > at `/app/bin/lpr`). For that reason, we need to be able to override this > value. This proposal also allows overriding the LP's path, as it could > experience

Fwd: Re: Allow overriding lp and lpr binary paths in PSPrintJob

2021-10-26 Thread Rolf van Kleef
> Well .. > > 1) Please read the comment the bots added to your PR. > There are steps you need to take before we can even look at your contribution. > > 2) PRs need a JBS bug ID else the bots will still reject it. > You'll need to submit an RFE at bugreport.java.com and go from there. I have sub

Re: RFR: 8202926: Test java/awt/Focus/WindowUpdateFocusabilityTest/WindowUpdateFocusabilityTest.html fails

2021-10-26 Thread Sergey Bylokhov
On Tue, 26 Oct 2021 18:14:59 GMT, Alexander Zvegintsev wrote: > The test is still failing on Ubuntu 16.04 (`window1` and `window2` are not > placed in front, so they are not receiving events). > > Looks like this was fixed in later releases. I've manually checked this test > on Ubuntu 18.04,

Re: RFR: 8275689: [TESTBUG] Use color tolerance only for XRender in BlitRotateClippedArea test

2021-10-26 Thread Sergey Bylokhov
On Tue, 26 Oct 2021 16:24:35 GMT, Jayathirth D V wrote: > This is follow up change after : > https://bugs.openjdk.java.net/browse/JDK-8255724 > > Now color tolerance is only added for Linux(XRender is default pipeline in > Linux and Solaris is not supported anymore). So I am using > jdk.test.

RFR: 8202926: Test java/awt/Focus/WindowUpdateFocusabilityTest/WindowUpdateFocusabilityTest.html fails

2021-10-26 Thread Alexander Zvegintsev
The test is still failing on Ubuntu 16.04 (`window1` and `window2` are not placed in front, so they are not receiving events). Looks like this was fixed in later releases. I've manually checked this test on Ubuntu 18.04, 20.04, 21.04 and they are not affected. We can remove the test from the p

Integrated: 8275872: Sync J2DBench run and analyze Makefile targets with build.xml

2021-10-26 Thread Jiří Vaněk
On Thu, 21 Oct 2021 17:04:08 GMT, Jiří Vaněk wrote: > The run targets of makefile to run J2DBench.jar/J2DAnalyzer.jar were > lacking the dist directory. This patch is fixing it. Note, that > build.xml have correct paths This pull request has now been integrated. Changeset: f1f5e269 Author:J

Re: RFR: 8275872: Sync J2DBench run and analyze Makefile targets with build.xml [v2]

2021-10-26 Thread Andrew John Hughes
On Tue, 26 Oct 2021 08:25:35 GMT, Jiří Vaněk wrote: >> The run targets of makefile to run J2DBench.jar/J2DAnalyzer.jar were >> lacking the dist directory. This patch is fixing it. Note, that >> build.xml have correct paths > > Jiří Vaněk has refreshed the contents of this pull request, and previo

Re: RFR: 8275689: [TESTBUG] Use color tolerance only for XRender in BlitRotateClippedArea test

2021-10-26 Thread Jayathirth D V
On Tue, 26 Oct 2021 16:24:35 GMT, Jayathirth D V wrote: > This is follow up change after : > https://bugs.openjdk.java.net/browse/JDK-8255724 > > Now color tolerance is only added for Linux(XRender is default pipeline in > Linux and Solaris is not supported anymore). So I am using > jdk.test.

RFR: 8275689: [TESTBUG] Use color tolerance only for XRender in BlitRotateClippedArea test

2021-10-26 Thread Jayathirth D V
This is follow up change after : https://bugs.openjdk.java.net/browse/JDK-8255724 Now color tolerance is only added for Linux(XRender is default pipeline in Linux and Solaris is not supported anymore). So I am using jdk.test.lib.Platform to determine which OS we are running on. CI run on all p

Re: RFR: 8275720: CommonComponentAccessibility.createWithParent isWrapped causes mem leak [v2]

2021-10-26 Thread Anton Tarasov
> This is a reimplementation of the `isWrapped` logic in the method: > > `+[CommonComponentAccessibility > createWithParent:accessible:role:index:withEnv:withView:isWrapped:]` > > The `isWrapped` arg was used to create an a11y element which is wrapped into > an object that does not have direct

Integrated: 8275720: CommonComponentAccessibility.createWithParent isWrapped causes mem leak

2021-10-26 Thread Anton Tarasov
On Fri, 22 Oct 2021 16:02:32 GMT, Anton Tarasov wrote: > This is a reimplementation of the `isWrapped` logic in the method: > > `+[CommonComponentAccessibility > createWithParent:accessible:role:index:withEnv:withView:isWrapped:]` > > The `isWrapped` arg was used to create an a11y element whic

Integrated: 8275809: crash in [CommonComponentAccessibility getCAccessible:withEnv:]

2021-10-26 Thread Anton Tarasov
On Fri, 22 Oct 2021 16:47:24 GMT, Anton Tarasov wrote: > Adding a JNI weak ref check. There's a couple of other similar places in the > code where a JNI weak ref is checked for null, in the rest of the code we > pass such refs to java where they are checked for null. So, I was not able to > ey

Integrated: 8275819: [TableRowAccessibility accessibilityChildren] method is ineffective

2021-10-26 Thread Anton Tarasov
On Fri, 22 Oct 2021 18:29:01 GMT, Anton Tarasov wrote: > Retrieve only cells for a particular table row when requested, not the whole > table. This pull request has now been integrated. Changeset: b98ed550 Author:Anton Tarasov URL: https://git.openjdk.java.net/jdk/commit/b98ed55060

RFR: JDK-8275923: Override the LPR path using a system property

2021-10-26 Thread Rolf van Kleef
On some select systems, the LPR binary may be placed elsewhere (for example at `/app/bin/lpr`). For that reason, we need to be able to override this value. This proposal also allows overriding the LP's path, as it could experience similar difficulties. - Commit messages: - Overrid

Re: RFR: JDK-8275923: Override the LPR path using a system property

2021-10-26 Thread Rolf van Kleef
On Thu, 21 Oct 2021 23:31:30 GMT, Magnus Ihse Bursie wrote: >> On some select systems, the LPR binary may be placed elsewhere (for example >> at `/app/bin/lpr`). For that reason, we need to be able to override this >> value. This proposal also allows overriding the LP's path, as it could >> ex

Re: RFR: JDK-8275923: Override the LPR path using a system property

2021-10-26 Thread Magnus Ihse Bursie
On Wed, 20 Oct 2021 20:38:17 GMT, Rolf van Kleef wrote: > On some select systems, the LPR binary may be placed elsewhere (for example > at `/app/bin/lpr`). For that reason, we need to be able to override this > value. This proposal also allows overriding the LP's path, as it could > experience

Re: RFR: 8275872: Sync J2DBench run and analyze Makefile targets with build.xml [v2]

2021-10-26 Thread Jiří Vaněk
On Tue, 26 Oct 2021 12:27:57 GMT, David Holmes wrote: >> Attmept done. Looks like the summary is there already once. Thanx again. > > @judovana please do not use "force push" in a PR as it makes the review > process very difficult and can leave orphaned comments. You can simply push > additiona

Re: RFR: 8275872: Sync J2DBench run and analyze Makefile targets with build.xml [v2]

2021-10-26 Thread David Holmes
On Tue, 26 Oct 2021 11:13:19 GMT, Jiří Vaněk wrote: >> Jiří Vaněk has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. > > Attmept done. Looks like the summary is th

Re: RFR: 8275872: Sync J2DBench run and analyze Makefile targets with build.xml [v2]

2021-10-26 Thread Jiří Vaněk
On Tue, 26 Oct 2021 08:25:35 GMT, Jiří Vaněk wrote: >> The run targets of makefile to run J2DBench.jar/J2DAnalyzer.jar were >> lacking the dist directory. This patch is fixing it. Note, that >> build.xml have correct paths > > Jiří Vaněk has refreshed the contents of this pull request, and previo

Re: RFR: 8275872: Sync J2DBench run and analyze Makefile targets with build.xml [v2]

2021-10-26 Thread Magnus Ihse Bursie
On Tue, 26 Oct 2021 08:25:35 GMT, Jiří Vaněk wrote: >> The run targets of makefile to run J2DBench.jar/J2DAnalyzer.jar were >> lacking the dist directory. This patch is fixing it. Note, that >> build.xml have correct paths > > Jiří Vaněk has refreshed the contents of this pull request, and previo

Re: RFR: 8275872: Sync J2DBench run and analyze Makefile targets with build.xml

2021-10-26 Thread Magnus Ihse Bursie
On Mon, 25 Oct 2021 16:08:12 GMT, Jiří Vaněk wrote: >> this looks fine, please update the copyright date > > @mrserb @gnu-andrew hi! Thanx! The PR was amended. @judovana Unfortunately you got "tricked" by @gnu-andrew 's comment into issuing a `/summary` comment, when you shouldn't have. That

RFR: 8213120: java/awt/TextArea/AutoScrollOnSelectAndAppend/AutoScrollOnSelectAndAppend.java fails on mac10.13

2021-10-26 Thread Jayathirth D V
Looks like this test was failing in one local system in JDK12 and it was problemlisted. I ran this test multiple times in our CI systems it doesnt fail. Made modifications to move test window to the middle of the screen and added autodelay for robot. Tested in our CI systems with modifications an

Re: RFR: 8275872: Sync J2DBench run and analyze Makefile targets with build.xml [v2]

2021-10-26 Thread Magnus Ihse Bursie
On Tue, 26 Oct 2021 08:20:46 GMT, Jiří Vaněk wrote: >> The run targets of makefile to run J2DBench.jar/J2DAnalyzer.jar were >> lacking the dist directory. This patch is fixing it. Note, that >> build.xml have correct paths > > Jiří Vaněk has refreshed the contents of this pull request, and previo

Re: RFR: 8275872: Sync J2DBench run and analyze Makefile targets with build.xml [v2]

2021-10-26 Thread Jiří Vaněk
On Mon, 25 Oct 2021 23:11:01 GMT, Sergey Bylokhov wrote: >> Jiří Vaněk has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. The pull request contains one >> new com

Re: RFR: 8275872: Sync J2DBench run and analyze Makefile targets with build.xml [v2]

2021-10-26 Thread Jiří Vaněk
> The run targets of makefile to run J2DBench.jar/J2DAnalyzer.jar were > lacking the dist directory. This patch is fixing it. Note, that > build.xml have correct paths Jiří Vaněk has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will sh