Re: RFR: 8270874: JFrame paint artifacts when dragged from standard monitor to HiDPI monitor

2021-11-15 Thread Sergey Bylokhov
On Mon, 15 Nov 2021 10:00:37 GMT, Jayathirth D V wrote: > Please correct my understanding. Does this refined repaint logic apply even > for overlapping Windows? What happens when 2 windows are overlapping and we > move top window slowly? Any performance/power impact? Initially, this code was u

Re: RFR: 8176501: Method Shape.getBounds2D() incorrectly includes Bezier control points in bounding box [v5]

2021-11-15 Thread Jeremy
On Tue, 9 Nov 2021 10:34:11 GMT, Laurent Bourgès wrote: >> Jeremy has updated the pull request incrementally with one additional commit >> since the last revision: >> >> 8176501: Method Shape.getBounds2D() incorrectly includes Bezier control >> points in bounding box >> >> Addressing co

Re: RFR: 8176501: Method Shape.getBounds2D() incorrectly includes Bezier control points in bounding box [v7]

2021-11-15 Thread Jeremy
On Mon, 15 Nov 2021 20:52:00 GMT, Laurent Bourgès wrote: >> Jeremy has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - 8176501: Method Shape.getBounds2D() incorrectly includes Bezier control >> points in bounding box >> >>This a

Re: RFR: 8176501: Method Shape.getBounds2D() incorrectly includes Bezier control points in bounding box [v8]

2021-11-15 Thread Jeremy
> This removes code that relied on consulting the Bezier control points to > calculate the Rectangle2D bounding box. Instead it's pretty straight-forward > to convert the Bezier control points into the x & y parametric equations. At > their most complex these equations are cubic polynomials, so

Re: RFR: 8262297: ImageIO.write() method will throw IndexOutOfBoundsException [v3]

2021-11-15 Thread Sergey Bylokhov
On Mon, 15 Nov 2021 08:06:13 GMT, Jayathirth D V wrote: >> Masanori Yano has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - 8262297: ImageIO.write() method will throw IndexOutOfBoundsException >> - 8262297: ImageIO.write() method will th

Re: RFR: 8176501: Method Shape.getBounds2D() incorrectly includes Bezier control points in bounding box [v7]

2021-11-15 Thread Laurent Bourgès
On Fri, 12 Nov 2021 05:47:12 GMT, Jeremy wrote: >> This removes code that relied on consulting the Bezier control points to >> calculate the Rectangle2D bounding box. Instead it's pretty straight-forward >> to convert the Bezier control points into the x & y parametric equations. At >> their m

Re: RFR: 8276794: Change nested classes in java.desktop to static nested classes

2021-11-15 Thread Sergey Bylokhov
On Thu, 14 Oct 2021 07:47:33 GMT, Andrey Turbanov wrote: > Non-static classes hold a link to their parent classes, which in many cases > can be avoided. > I updated only private and package-private classes. Didn't touch > public/protected to not break external code. > Similar cleanup in java.ba

Re: RFR: 8276905: Use appropriate macosx_version_minimum value while compiling metal shaders [v4]

2021-11-15 Thread Phil Race
On Mon, 15 Nov 2021 14:00:59 GMT, Jayathirth D V wrote: >> When JDK is built on BigSur with Xcode12.5 and used to run jtreg tests in >> macOS10.15 with Xcode <=12.4 we are getting compilation error. We dont set >> any deployment target when when we use xcrun to create .air file and this >> iss

Re: RFR: 8190264: JScrollBar ignores its border when using macOS Mac OS X Aqua look and feel [v3]

2021-11-15 Thread Alisen Chung
> Adjusted the AquaLF scrollbar to account for border inset settings when > dragging the thumb and clicking on the track. Alisen Chung has updated the pull request incrementally with two additional commits since the last revision: - removed trailing whitespace - test change - Ch

Re: RFR: 8190264: JScrollBar ignores its border when using macOS Mac OS X Aqua look and feel [v2]

2021-11-15 Thread Alisen Chung
> Adjusted the AquaLF scrollbar to account for border inset settings when > dragging the thumb and clicking on the track. Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: added test - Changes: - all: https://git.openjd

Re: RFR: 8276905: Use appropriate macosx_version_minimum value while compiling metal shaders [v4]

2021-11-15 Thread Jayathirth D V
On Mon, 15 Nov 2021 14:33:21 GMT, Magnus Ihse Bursie wrote: > Looks good to me also. Please let Phil have a say as well before integrating. Thanks Magnus for the review. Yes i have already Re-Requested review from Phil on latest patch. Also i am waiting on Vitaly(JBS submitter) to verify the la

Re: RFR: 8276905: Function frag_col has a deployment target which is incompatible with this OS [v4]

2021-11-15 Thread Magnus Ihse Bursie
On Mon, 15 Nov 2021 14:00:59 GMT, Jayathirth D V wrote: >> When JDK is built on BigSur with Xcode12.5 and used to run jtreg tests in >> macOS10.15 with Xcode <=12.4 we are getting compilation error. We dont set >> any deployment target when when we use xcrun to create .air file and this >> iss

Re: RFR: 8276905: Function frag_col has a deployment target which is incompatible with this OS [v3]

2021-11-15 Thread Kevin Rushforth
On Mon, 15 Nov 2021 13:44:11 GMT, Jayathirth D V wrote: >> When JDK is built on BigSur with Xcode12.5 and used to run jtreg tests in >> macOS10.15 with Xcode <=12.4 we are getting compilation error. We dont set >> any deployment target when when we use xcrun to create .air file and this >> iss

Re: RFR: 8276905: Function frag_col has a deployment target which is incompatible with this OS [v2]

2021-11-15 Thread Jayathirth D V
On Mon, 15 Nov 2021 13:28:30 GMT, Kevin Rushforth wrote: > The JDK itself has a minimum version of 11.0 on macOS aarch64 systems > (because apple only supports it on macOS >= 11), so it probably doesn't > matter much. You might wish to file a low-priority follow-up issue to change > the runtim

Re: RFR: 8276905: Function frag_col has a deployment target which is incompatible with this OS [v3]

2021-11-15 Thread Jayathirth D V
On Mon, 15 Nov 2021 13:46:29 GMT, Kevin Rushforth wrote: >> Jayathirth D V has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Use 10.14 macOS version > > make/modules/java.desktop/lib/Awt2dLibraries.gmk line 844: > >> 842: # for aarch64 is

Re: RFR: 8276905: Function frag_col has a deployment target which is incompatible with this OS [v4]

2021-11-15 Thread Kevin Rushforth
On Mon, 15 Nov 2021 13:57:25 GMT, Jayathirth D V wrote: >> When JDK is built on BigSur with Xcode12.5 and used to run jtreg tests in >> macOS10.15 with Xcode <=12.4 we are getting compilation error. We dont set >> any deployment target when when we use xcrun to create .air file and this >> iss

Re: RFR: 8276905: Function frag_col has a deployment target which is incompatible with this OS [v4]

2021-11-15 Thread Erik Joelsson
On Mon, 15 Nov 2021 13:57:25 GMT, Jayathirth D V wrote: >> When JDK is built on BigSur with Xcode12.5 and used to run jtreg tests in >> macOS10.15 with Xcode <=12.4 we are getting compilation error. We dont set >> any deployment target when when we use xcrun to create .air file and this >> iss

Re: RFR: 8276905: Function frag_col has a deployment target which is incompatible with this OS [v4]

2021-11-15 Thread Jayathirth D V
> When JDK is built on BigSur with Xcode12.5 and used to run jtreg tests in > macOS10.15 with Xcode <=12.4 we are getting compilation error. We dont set > any deployment target when when we use xcrun to create .air file and this > issue looks similar to https://developer.apple.com/forums/thread/

Re: RFR: 8276905: Function frag_col has a deployment target which is incompatible with this OS [v3]

2021-11-15 Thread Jayathirth D V
> When JDK is built on BigSur with Xcode12.5 and used to run jtreg tests in > macOS10.15 with Xcode <=12.4 we are getting compilation error. We dont set > any deployment target when when we use xcrun to create .air file and this > issue looks similar to https://developer.apple.com/forums/thread/

Re: RFR: 8276905: Function frag_col has a deployment target which is incompatible with this OS [v2]

2021-11-15 Thread Erik Joelsson
On Mon, 15 Nov 2021 07:17:45 GMT, Jayathirth D V wrote: > A question popped up while doing this. By making 11.0 as minimum macosx > version on aarch64, are we not restricting metal to be used only on >=11.0 on > aarch 64? Correct, but there are no older versions of Macos on aarch64, so this is

Re: RFR: 8276905: Function frag_col has a deployment target which is incompatible with this OS [v2]

2021-11-15 Thread Kevin Rushforth
On Thu, 11 Nov 2021 15:32:01 GMT, Jayathirth D V wrote: >> When JDK is built on BigSur with Xcode12.5 and used to run jtreg tests in >> macOS10.15 with Xcode <=12.4 we are getting compilation error. We dont set >> any deployment target when when we use xcrun to create .air file and this >> iss

Re: RFR: 8270874: JFrame paint artifacts when dragged from standard monitor to HiDPI monitor

2021-11-15 Thread Jayathirth D V
On Wed, 10 Nov 2021 18:45:12 GMT, Sergey Bylokhov wrote: > The bug occurs more often if initially the window is moved partly outside of > the first screen(let's name this part as the invisible part), and then slowly > moved to the second screen where that invisible part became visible on the >

Re: RFR: 8233568: [TESTBUG] AWT event tests failing on MacOS

2021-11-15 Thread Jayathirth D V
On Thu, 21 Oct 2021 15:47:36 GMT, Alisen Chung wrote: > Tests passing on macos, so removing from ProblemList Are these tests verified to pass on CI or local machine? If CI please add the link in JBS. Also it looks all these tests are related to java/awt/event. It is possible that these tests w

Re: RFR: 8262297: ImageIO.write() method will throw IndexOutOfBoundsException [v3]

2021-11-15 Thread Jayathirth D V
On Fri, 12 Nov 2021 09:12:07 GMT, Masanori Yano wrote: >> Could you please review the 8262297 bug fixes? >> >> In this case, ImageIO.write() should throw java.io.IOException rather than >> java.lang.IndexOutOfBoundsException. IndexOutOfBoundsException is caught and >> wrapped in IIOException i