Re: RFR: 8266435: WBMPImageReader.read() should not truncate the input stream

2021-11-24 Thread Sergey Bylokhov
On Tue, 23 Nov 2021 11:05:27 GMT, Jayathirth D V wrote: > If we use a custom stream and specify limit on stream.read() length, > WBMPImageReader.read() doesnt verify whether we are decoded complete data or > not. We can check the length of data decoded and rerun the stream.read() or > use read

Re: RFR: 8277497 Last column cell in the JTAble row is read as empty cell

2021-11-24 Thread Sergey Bylokhov
On Wed, 24 Nov 2021 15:16:54 GMT, Artem Semenov wrote: > Testing https://bugs.openjdk.java.net/browse/JDK-8271071 > Step to reproduce > 1) Run SwingSet2 in JDK 18 ( I used b24 ) > 2) Enable Voiceover. > 3) Select JTable demo > 4) Click any row in the table or select the first row . Observe t

Re: RFR: 8274640: Cleanup unnecessary null comparison before instanceof check in java.desktop

2021-11-24 Thread Andrey Turbanov
On Sat, 11 Sep 2021 14:59:21 GMT, Andrey Turbanov wrote: > Updated code checks both non-null and instance of a class in java.desktop > module classes. > The checks and explicit casts could also be replaced with pattern matching > for the instanceof operator. > Similar cleanups > 1. [JDK-827348

Re: RFR: 8277497 Last column cell in the JTAble row is read as empty cell

2021-11-24 Thread Anton Tarasov
On Wed, 24 Nov 2021 15:16:54 GMT, Artem Semenov wrote: > Testing https://bugs.openjdk.java.net/browse/JDK-8271071 > Step to reproduce > 1) Run SwingSet2 in JDK 18 ( I used b24 ) > 2) Enable Voiceover. > 3) Select JTable demo > 4) Click any row in the table or select the first row . Observe t

RFR: 8277497 Last column cell in the JTAble row is read as empty cell

2021-11-24 Thread Artem Semenov
Testing https://bugs.openjdk.java.net/browse/JDK-8271071 Step to reproduce 1) Run SwingSet2 in JDK 18 ( I used b24 ) 2) Enable Voiceover. 3) Select JTable demo 4) Click any row in the table or select the first row . Observe that row is selected & VoiceOver reads the column values or navigate

Re: RFR: 8262297: ImageIO.write() method will throw IndexOutOfBoundsException [v5]

2021-11-24 Thread Jayathirth D V
On Wed, 24 Nov 2021 11:09:42 GMT, Masanori Yano wrote: >> Could you please review the 8262297 bug fixes? >> >> In this case, ImageIO.write() should throw java.io.IOException rather than >> java.lang.IndexOutOfBoundsException. IndexOutOfBoundsException is caught and >> wrapped in IIOException i

Re: RFR: 8181571: printing to CUPS fails on mac sandbox app [v3]

2021-11-24 Thread Alexander Scherbatiy
On Tue, 24 Aug 2021 15:49:00 GMT, Alexander Scherbatiy wrote: >> The issue is reproduced on macOS Big Sur 11.0.1 with jdk 16.0.1+9. >> >> Create a native macOS app from the Hello.java file, sign and run it in >> sandbox: >> >> import javax.print.*; >> import javax.swing.*; >> >> public class

Re: RFR: 8262297: ImageIO.write() method will throw IndexOutOfBoundsException [v4]

2021-11-24 Thread Masanori Yano
On Tue, 23 Nov 2021 11:30:40 GMT, Jayathirth D V wrote: >> test/jdk/javax/imageio/plugins/bmp/BMPBitsPerPixelTest.java line 62: >> >>> 60: } >>> 61: BufferedImage img = new BufferedImage(10, 10, imageType, >>> (IndexColorModel)cm); >>> 62: ImageIO.write(img,

Re: RFR: 8262297: ImageIO.write() method will throw IndexOutOfBoundsException [v5]

2021-11-24 Thread Masanori Yano
> Could you please review the 8262297 bug fixes? > > In this case, ImageIO.write() should throw java.io.IOException rather than > java.lang.IndexOutOfBoundsException. IndexOutOfBoundsException is caught and > wrapped in IIOException in ImageIO.write() with this fix. In addition, > IndexOutOfBou