RFR: 8277817: java/awt/dnd/BadSerializationTest/BadSerializationTest.java failed: ClassNotFoundException: com.apple.laf.AquaImageFactory$SystemColorProxy

2021-11-29 Thread Liam Miller-Cushon
This change updates the serialized objects used by `java/awt/dnd/BadSerializationTest/BadSerializationTest.java` after [JDK-8271623](https://bugs.openjdk.java.net/browse/JDK-8271623), using a similar approach to the previous fix in [JDK-8039082](https://bugs.openjdk.java.net/browse/JDK-8039082)

Withdrawn: 8274597: [TESTBUG] Two of the dnd tests times out and fails

2021-11-29 Thread duke
On Thu, 30 Sep 2021 14:24:50 GMT, Manukumar V S wrote: > These two dnd tests fails most of the time with a time out, mostly noticed in > windows 11 machines. > 1. java/awt/dnd/AcceptDropMultipleTimes/AcceptDropMultipleTimes.java > 2. java/awt/dnd/DropTargetEnterExitTest/MissedDragExitTest.java >

Re: RFR: 8277497 Last column cell in the JTAble row is read as empty cell [v4]

2021-11-29 Thread Alexander Zuev
On Thu, 25 Nov 2021 09:00:32 GMT, Artem Semenov wrote: >> Testing https://bugs.openjdk.java.net/browse/JDK-8271071 >> Step to reproduce >> 1) Run SwingSet2 in JDK 18 ( I used b24 ) >> 2) Enable Voiceover. >> 3) Select JTable demo >> 4) Click any row in the table or select the first row . Obs

Re: RFR: 8272392 Lanai: SwingSet2. Black background on expanding tree node [v2]

2021-11-29 Thread Victor Dyakov
On Fri, 26 Nov 2021 09:02:37 GMT, Alexey Ushakov wrote: >> Removed creation of the separate encoder depending on destination properties >> as we don't use this info to customize the encoder properties > > Alexey Ushakov has updated the pull request incrementally with one additional > commit sin

Re: RFR: 8275715: D3D pipeline processes multiple PaintEvent at initial drawing [v2]

2021-11-29 Thread Masanori Yano
On Thu, 28 Oct 2021 08:27:44 GMT, Masanori Yano wrote: >> Could you please review the 8275715 bug fixes? >> >> I think D3DScreenUpdateManager posts unnecessary PaintEvent during >> processing PaintEvent. When the validate method is called from >> createGraphics, repaintPeerTarget should not be

Re: RFR: 8274640: Cleanup unnecessary null comparison before instanceof check in java.desktop [v2]

2021-11-29 Thread Alexey Ivanov
On Mon, 29 Nov 2021 08:17:41 GMT, Andrey Turbanov wrote: >> Updated code checks both non-null and instance of a class in java.desktop >> module classes. >> The checks and explicit casts could also be replaced with pattern matching >> for the instanceof operator. >> Similar cleanups >> 1. [JDK-

Re: RFR: 8274640: Cleanup unnecessary null comparison before instanceof check in java.desktop [v2]

2021-11-29 Thread Alexey Ivanov
On Mon, 29 Nov 2021 08:01:56 GMT, Andrey Turbanov wrote: >> src/java.desktop/macosx/classes/com/apple/laf/AquaRootPaneUI.java line 78: >> >>> 76: final Component parent = c.getParent(); >>> 77: >>> 78: if (parent instanceof JFrame frameParent) { >> >> The `frameParent` variable

Re: RFR: 8274640: Cleanup unnecessary null comparison before instanceof check in java.desktop [v2]

2021-11-29 Thread Alexey Ivanov
On Mon, 29 Nov 2021 08:00:19 GMT, Andrey Turbanov wrote: >> src/java.desktop/unix/classes/sun/awt/X11/XWindow.java line 312: >> >>> 310: } >>> 311: >>> 312: return window.getContentWindow(); >> >> Is the branch where 0 was returned impossible? > > Yes. It was impossible. > Only

Re: RFR: 8277868: Use Comparable.compare() instead of surrogate code [v2]

2021-11-29 Thread Сергей Цыпанов
> Instead of something like > > long x; > long y; > return (x < y) ? -1 : ((x == y) ? 0 : 1); > > we can use `return Long.compare(x, y);` > > All replacements are done with IDE. Сергей Цыпанов has updated the pull request incrementally with one additional commit since the last revision: 827

Re: RFR: 8277868: Use Comparable.compare() instead of surrogate code [v2]

2021-11-29 Thread Сергей Цыпанов
On Sat, 27 Nov 2021 22:50:55 GMT, Michael Bien wrote: >> Сергей Цыпанов has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8277868: Use Integer.signum() in BasicTableUI > > src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTableUI.

Re: RFR: 8274640: Cleanup unnecessary null comparison before instanceof check in java.desktop [v2]

2021-11-29 Thread Andrey Turbanov
On Sat, 27 Nov 2021 16:27:36 GMT, Alexey Ivanov wrote: >> Andrey Turbanov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8274640: Cleanup unnecessary null comparison before instanceof check in >> java.desktop >> apply review comments

Re: RFR: 8274640: Cleanup unnecessary null comparison before instanceof check in java.desktop [v2]

2021-11-29 Thread Andrey Turbanov
> Updated code checks both non-null and instance of a class in java.desktop > module classes. > The checks and explicit casts could also be replaced with pattern matching > for the instanceof operator. > Similar cleanups > 1. [JDK-8273484](https://bugs.openjdk.java.net/browse/JDK-8273484) java.n

Re: RFR: 8274640: Cleanup unnecessary null comparison before instanceof check in java.desktop

2021-11-29 Thread Andrey Turbanov
On Sat, 27 Nov 2021 16:37:03 GMT, Alexey Ivanov wrote: >> Updated code checks both non-null and instance of a class in java.desktop >> module classes. >> The checks and explicit casts could also be replaced with pattern matching >> for the instanceof operator. >> Similar cleanups >> 1. [JDK-82