The "missing-explicit-ctor" check was disabled by the
[JDK-8071961](https://bugs.openjdk.java.net/browse/JDK-8071961) and later was
fixed by the [JDK-8250853](https://bugs.openjdk.java.net/browse/JDK-8250853).
So we can re-enable this check again.
The fix will remove the "Java.gmk" file and as
On Fri, 3 Dec 2021 20:20:48 GMT, Alexey Ivanov wrote:
> Can't we call it explicitly in the case where colorBits == NULL?
I would use the default handlers for bad_alloc since they can be changed in
feature and keeping code that is intended to be used in two places is usually
not a good idea.
>
The documentation for following methods used object equality mentioning
'equals()'. I have replaced the equals() with == operator where necessary with
some formattings.
sun.awt.util.IdentityLinkedList#contains
sun.awt.util.IdentityArrayList#contains
sun.awt.util.IdentityArrayList#indexOf
sun.awt
On Fri, 3 Dec 2021 07:30:43 GMT, ANUPAM DEV wrote:
> The documentation for following methods used equals() for object equality:
>
> sun.awt.util.IdentityLinkedList#contains
> sun.awt.util.IdentityArrayList#contains
> sun.awt.util.IdentityArrayList#indexOf
> sun.awt.util.IdentityArrayList#lastInd
On Fri, 3 Dec 2021 01:18:20 GMT, Joe Darcy wrote:
> In JDK 18, JDK-8189591 added the ability to suppress doclint warnings.
> Therefore, it is now possible to enable the full doclint checks for the
> java.desktop module if the instances of warnings are suppressed. This patch
> does this; it wou
On Fri, 3 Dec 2021 01:18:20 GMT, Joe Darcy wrote:
> In JDK 18, JDK-8189591 added the ability to suppress doclint warnings.
> Therefore, it is now possible to enable the full doclint checks for the
> java.desktop module if the instances of warnings are suppressed. This patch
> does this; it wou
On Mon, 13 Sep 2021 18:03:39 GMT, Alisen Chung wrote:
> Added a resizing flag when the window is currently being resized to block
> mouseEntered and mouseExited events from being posted to that window.
This pull request has been closed without being integrated.
-
PR: https://git.o
On Fri, 3 Dec 2021 01:18:20 GMT, Joe Darcy wrote:
> In JDK 18, JDK-8189591 added the ability to suppress doclint warnings.
> Therefore, it is now possible to enable the full doclint checks for the
> java.desktop module if the instances of warnings are suppressed. This patch
> does this; it wou
On Fri, 3 Dec 2021 07:30:43 GMT, ANUPAM DEV wrote:
> The documentation for following methods used equals() for object equality:
>
> sun.awt.util.IdentityLinkedList#contains
> sun.awt.util.IdentityArrayList#contains
> sun.awt.util.IdentityArrayList#indexOf
> sun.awt.util.IdentityArrayList#lastInd
On Fri, 3 Dec 2021 20:14:23 GMT, Alexander Zuev wrote:
> Yes, but then handle_bad_alloc() will not be called which will not raise the
> OutOfMemoryError on the java side.
Can't we call it explicitly in the case where `colorBits == NULL`?
Alternatively, since you don't use the macros for try an
On Fri, 3 Dec 2021 13:26:57 GMT, Alexey Ivanov wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Eliminate potential resource leak.
>
> src/java.desktop/windows/native/libawt/windows/ShellFolder2.cpp line 1068:
>
On Fri, 3 Dec 2021 19:11:19 GMT, Sergey Bylokhov wrote:
>> Is using robot to get the pixel color alright?
>
> You can render directly to the BufferedImage instead of the JFrame, so in
> this case, it will not be necessary to use a robot, you will be able to check
> the pixel directly.
For exam
On Thu, 2 Dec 2021 20:18:51 GMT, Alisen Chung wrote:
>> But it is not necessary to use the robot at all? Can you try to set the
>> scollbar thumb position/move it programmatically w/o a robot? If it is
>> possible then it will be rendered on top of the red area -> it will be
>> possible to ren
On Mon, 1 Nov 2021 20:03:42 GMT, Sergey Bylokhov wrote:
> Please take a look to one more wagon in this train:
> [JDK-8176795](https://bugs.openjdk.java.net/browse/JDK-8176795)->[JDK-8204931](https://bugs.openjdk.java.net/browse/JDK-8204931)->[JDK-8214579](https://bugs.openjdk.java.net/browse/JDK-
On Mon, 1 Nov 2021 20:03:42 GMT, Sergey Bylokhov wrote:
> Please take a look to one more wagon in this train:
> [JDK-8176795](https://bugs.openjdk.java.net/browse/JDK-8176795)->[JDK-8204931](https://bugs.openjdk.java.net/browse/JDK-8204931)->[JDK-8214579](https://bugs.openjdk.java.net/browse/JDK-
On Thu, 2 Dec 2021 08:27:37 GMT, Prasanta Sadhukhan
wrote:
> Few tests are failing on macos12-aarch64 systems due to mismatch in color
> value obtained from robot.getPixelColor and expected color.
> More details on the failures can be seen in JDK-8277816. Till the root cause
> is investigated,
On Thu, 2 Dec 2021 08:27:37 GMT, Prasanta Sadhukhan
wrote:
> Few tests are failing on macos12-aarch64 systems due to mismatch in color
> value obtained from robot.getPixelColor and expected color.
> More details on the failures can be seen in JDK-8277816. Till the root cause
> is investigated,
On Thu, 2 Dec 2021 08:27:37 GMT, Prasanta Sadhukhan
wrote:
> Few tests are failing on macos12-aarch64 systems due to mismatch in color
> value obtained from robot.getPixelColor and expected color.
> More details on the failures can be seen in JDK-8277816. Till the root cause
> is investigated,
On Thu, 2 Dec 2021 08:27:37 GMT, Prasanta Sadhukhan
wrote:
> Few tests are failing on macos12-aarch64 systems due to mismatch in color
> value obtained from robot.getPixelColor and expected color.
> More details on the failures can be seen in JDK-8277816. Till the root cause
> is investigated,
On Wed, 1 Dec 2021 07:55:30 GMT, Jayathirth D V wrote:
> I used test case present in https://bugs.openjdk.java.net/browse/JDK-8267963
> to check how it behaves with this PR and noticed that it is causes
> regresssion related to how ruler text looks and also if we move Ruler between
> monitors
On Wed, 1 Dec 2021 06:57:25 GMT, Jayathirth D V wrote:
>> Alexey Ushakov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8272392 Lanai: SwingSet2. Black background on expanding tree node
>>
>> Fixed incorrect addition of the values
On Wed, 1 Dec 2021 07:08:39 GMT, Jayathirth D V wrote:
>> Alexey Ushakov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8272392 Lanai: SwingSet2. Black background on expanding tree node
>>
>> Corrected prototype of the reset method
> Removed creation of the separate encoder depending on destination properties
> as we don't use this info to customize the encoder properties
Alexey Ushakov has updated the pull request incrementally with one additional
commit since the last revision:
8272392 Lanai: SwingSet2. Black backgrou
On Thu, 2 Dec 2021 22:05:00 GMT, Alexander Zuev wrote:
>> Made colorBits and maskBits arrays dynamic so they are allocated on heap
>> instead of stack.
>> Added regression test.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
On Fri, 3 Dec 2021 01:18:20 GMT, Joe Darcy wrote:
> In JDK 18, JDK-8189591 added the ability to suppress doclint warnings.
> Therefore, it is now possible to enable the full doclint checks for the
> java.desktop module if the instances of warnings are suppressed. This patch
> does this; it wou
On Sat, 11 Sep 2021 14:59:21 GMT, Andrey Turbanov wrote:
> Updated code checks both non-null and instance of a class in java.desktop
> module classes.
> The checks and explicit casts could also be replaced with pattern matching
> for the instanceof operator.
> Similar cleanups
> 1. [JDK-827348
On Thu, 28 Oct 2021 08:27:44 GMT, Masanori Yano wrote:
>> Could you please review the 8275715 bug fixes?
>>
>> I think D3DScreenUpdateManager posts unnecessary PaintEvent during
>> processing PaintEvent. When the validate method is called from
>> createGraphics, repaintPeerTarget should not be
On Thu, 2 Dec 2021 00:00:35 GMT, Sergey Bylokhov wrote:
>> src/java.desktop/share/classes/javax/swing/JLabel.java line 1110:
>>
>>> 1108: }
>>> 1109: }
>>> 1110: if ((name == null) || name.isEmpty()) {
>>
>> I continue our discussion from code
> Testing https://bugs.openjdk.java.net/browse/JDK-8271071
> Step to reproduce
> 1) Run SwingSet2 in JDK 18 ( I used b24 )
> 2) Enable Voiceover.
> 3) Select JTable demo
> 4) Click any row in the table or select the first row . Observe that row is
> selected & VoiceOver reads the column value
29 matches
Mail list logo
