Re: RFR: 6496103: isFileHidingEnabled return false by default [v2]

2021-12-14 Thread Tejesh R
> The default value of this property is derived from native platform. The same > is updated in the documentation. Tejesh R has updated the pull request incrementally with one additional commit since the last revision: 6496103: isFileHidingEnabled return false by default - Change

Re: RFR: 6496103: isFileHidingEnabled return false by default [v2]

2021-12-14 Thread Tejesh R
On Wed, 15 Dec 2021 01:20:45 GMT, Sergey Bylokhov wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 6496103: isFileHidingEnabled return false by default > > src/java.desktop/share/classes/javax/swing/JFileChooser.java li

Re: RFR: 6462028: MaskFormatter API documentation refers to getDisplayValue [v5]

2021-12-14 Thread Tejesh R
On Mon, 6 Dec 2021 17:16:20 GMT, Phil Race wrote: >> src/java.desktop/share/classes/javax/swing/text/MaskFormatter.java line 103: >> >>> 101: * MaskFormatter formatter = new MaskFormatter("###-"); >>> 102: * formatter.setPlaceholderCharacter('_'); >>> 103: * formatter.getDisplayValu

RFR: 8278828 : java/awt/a11y/AccessibleTextTest.java's createTextArea() just shows instructions on the UI

2021-12-14 Thread lawrence . andrews
1) Test scenario was just showing test instruction with JTextArea. So added the JTextArea as the instruction and method says. 2) JTextArea is filled with contents so that and an Emoji character making sure that screen reader can read Emoji also. 3) Now user can user arrow keys to navigate the JT

Re: RFR: 8190264: JScrollBar ignores its border when using macOS Mac OS X Aqua look and feel [v10]

2021-12-14 Thread Sergey Bylokhov
On Wed, 8 Dec 2021 20:52:42 GMT, Alisen Chung wrote: >> Adjusted the AquaLF scrollbar to account for border inset settings when >> dragging the thumb and clicking on the track. > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > >

Re: RFR: 6465404: some problems in CellEditor related API docs [v5]

2021-12-14 Thread Sergey Bylokhov
On Wed, 8 Dec 2021 13:09:26 GMT, Alexey Ivanov wrote: >> I'm not sure this fix is going in the right direction. Isn't the doc saying >> that if you want to use one of these components as the cell of a JTable it >> should implement this interface ? >> And the problem with JListBox is that it is

Re: RFR: 6496103: isFileHidingEnabled return false by default

2021-12-14 Thread Sergey Bylokhov
On Thu, 9 Dec 2021 09:40:38 GMT, Tejesh R wrote: > The default value of this property is derived from native platform. The same > is updated in the documentation. src/java.desktop/share/classes/javax/swing/JFileChooser.java line 1416: > 1414: * Returns true if hidden files are not shown i

Re: RFR: 8278050: Armenian text isn't rendered on macOS if text layout is performed

2021-12-14 Thread Sergey Bylokhov
On Wed, 1 Dec 2021 10:52:38 GMT, Dmitry Batrak wrote: > The problem is related to the implementation of font fallback on macOS, > specifically to the path used when text layout > is performed, i.e. the one using `FontSubstitution` and cascade lists. > `CTFontCopyDefaultCascadeListForLanguages`'

Re: RFR: 8278348: [macos12] javax/swing/JTree/4908142/bug4908142.java fails in macos12

2021-12-14 Thread Sergey Bylokhov
On Tue, 14 Dec 2021 05:44:17 GMT, Prasanta Sadhukhan wrote: > Test seem to be failing in macos12.0.1 (although it does not seem to affect > 12.1) due to keypresses of "a", "a", "d" is not selecting "aad" but "ade" > which seems to point to the fact that 2 exclusive "a" keypress are considered

Integrated: 8275843: Random crashes while the UI code is executed

2021-12-14 Thread Sergey Bylokhov
On Mon, 1 Nov 2021 20:03:42 GMT, Sergey Bylokhov wrote: > Please take a look to one more wagon in this train: > [JDK-8176795](https://bugs.openjdk.java.net/browse/JDK-8176795)->[JDK-8204931](https://bugs.openjdk.java.net/browse/JDK-8204931)->[JDK-8214579](https://bugs.openjdk.java.net/browse/JDK-

Re: RFR: 8277463: JFileChooser with Metal L&F doesn't show non-canonical UNC path in - Look in

2021-12-14 Thread Prasanta Sadhukhan
On Fri, 10 Dec 2021 08:59:55 GMT, Masanori Yano wrote: > I would like to fix the bug reported in JDK-8277463. > > As reporter's investigation, ShellFolder.getNormalizedFile() returns > incorrect value for non-canonical Windows UNC path. getNormalizedFile() is > used for symbolic link path, but

Re: RFR: 8275843: Random crashes while the UI code is executed [v3]

2021-12-14 Thread Sergey Bylokhov
> Please take a look to one more wagon in this train: > [JDK-8176795](https://bugs.openjdk.java.net/browse/JDK-8176795)->[JDK-8204931](https://bugs.openjdk.java.net/browse/JDK-8204931)->[JDK-8214579](https://bugs.openjdk.java.net/browse/JDK-8214579)->[JDK-8227392](https://bugs.openjdk.java.net/brow

Re: RFR: 8275715: D3D pipeline processes multiple PaintEvent at initial drawing [v2]

2021-12-14 Thread Masanori Yano
On Thu, 18 Nov 2021 00:02:30 GMT, Sergey Bylokhov wrote: >> @mrserb Can I hope this fix will be integrated after JDK-8270874 is fixed? > > Yes. @mrserb @prrace JDK 18 has been forked, so please resume the review of this fix. - PR: https://git.openjdk.java.net/jdk/pull/6064

Re: RFR: 7001973: java/awt/Graphics2D/CopyAreaOOB.java fails [v2]

2021-12-14 Thread Masanori Yano
On Tue, 26 Oct 2021 04:52:37 GMT, Sergey Bylokhov wrote: >> Masanori Yano has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> com

Re: RFR: 8277463: JFileChooser with Metal L&F doesn't show non-canonical UNC path in - Look in

2021-12-14 Thread Masanori Yano
On Fri, 10 Dec 2021 10:05:04 GMT, Prasanta Sadhukhan wrote: >> I would like to fix the bug reported in JDK-8277463. >> >> As reporter's investigation, ShellFolder.getNormalizedFile() returns >> incorrect value for non-canonical Windows UNC path. getNormalizedFile() is >> used for symbolic lin