Re: RFR: 8278937: JCK test for java_awt/geom/Line2D.Float fails after 8277868

2021-12-16 Thread Jayathirth D V
On Fri, 17 Dec 2021 02:40:04 GMT, Phil Race wrote: > This reverts the uses of Float.compare() and Double.compare() made by the fix > for 8277868 > since it appears clear that for better or worse they are not 100% compatible > with the previous code. > These uses are all in the desktop module >

RFR: 8278937: JCK test for java_awt/geom/Line2D.Float fails after 8277868

2021-12-16 Thread Phil Race
This reverts the uses of Float.compare() and Double.compare() made by the fix for 8277868 since it appears clear that for better or worse they are not 100% compatible with the previous code. These uses are all in the desktop module For comparison the original changes are here : https://github.c

Re: RFR: 8176501: Method Shape.getBounds2D() incorrectly includes Bezier control points in bounding box [v10]

2021-12-16 Thread Jeremy
On Wed, 15 Dec 2021 23:49:24 GMT, Phil Race wrote: >> Jeremy has updated the pull request incrementally with one additional commit >> since the last revision: >> >> 8176501: Method Shape.getBounds2D() incorrectly includes Bezier control >> points in bounding box >> >> Addressing code re

Integrated: 8277868: Use Comparable.compare() instead of surrogate code

2021-12-16 Thread Сергей Цыпанов
On Fri, 26 Nov 2021 12:46:59 GMT, Сергей Цыпанов wrote: > Instead of something like > > long x; > long y; > return (x < y) ? -1 : ((x == y) ? 0 : 1); > > we can use `return Long.compare(x, y);` > > All replacements are done with IDE. This pull request has now been integrated. Changeset: 20db

Re: RFR: 8278828 : java/awt/a11y/AccessibleTextTest.java's createTextArea() just shows instructions on the UI

2021-12-16 Thread Artem Semenov
On Thu, 16 Dec 2021 14:18:37 GMT, lawrence.andrews wrote: >> test/jdk/java/awt/a11y/AccessibleTextTest.java line 142: >> >>> 140: panel.setLayout(new FlowLayout()); >>> 141: JTextArea textArea = new JTextArea(value); >>> 142: panel.add(textArea); >> >> Hello. @mrserb Th

Withdrawn: 8225777: java/awt/Mixing/MixingOnDialog.java fails on Ubuntu

2021-12-16 Thread duke
On Wed, 20 Oct 2021 12:05:57 GMT, Alexander Zvegintsev wrote: > Looks like the test started failing after increasing of window's title height > in Ubuntu theme: > > ![image](https://user-images.githubusercontent.com/77687766/138088503-f380bcb2-1ffc-4d58-b6b2-2efc56b7975c.png) > So the click ha

Re: RFR: 8176501: Method Shape.getBounds2D() incorrectly includes Bezier control points in bounding box [v12]

2021-12-16 Thread Jeremy
> This removes code that relied on consulting the Bezier control points to > calculate the Rectangle2D bounding box. Instead it's pretty straight-forward > to convert the Bezier control points into the x & y parametric equations. At > their most complex these equations are cubic polynomials, so

RFR: 8278908: [macOS] Unexpected text normalization on pasting from clipboard

2021-12-16 Thread Dmitry Batrak
The fix just removes the explicit normalization of text obtained from system clipboard in JDK code, as I've found no good justification for such a normalization, at least for the latest macOS version. The same fix was performed in JetBrains Runtime by a user's request more than 4 years ago, and

Re: RFR: 8278828 : java/awt/a11y/AccessibleTextTest.java's createTextArea() just shows instructions on the UI

2021-12-16 Thread lawrence . andrews
On Thu, 16 Dec 2021 08:32:40 GMT, Artem Semenov wrote: >> 1) Test scenario was just showing test instruction with JTextArea. So added >> the JTextArea as the instruction and method says. >> 2) JTextArea is filled with contents so that and an Emoji character making >> sure that screen reader ca

Re: RFR: 8176501: Method Shape.getBounds2D() incorrectly includes Bezier control points in bounding box [v10]

2021-12-16 Thread Laurent Bourgès
On Fri, 19 Nov 2021 19:09:54 GMT, Jeremy wrote: >> This removes code that relied on consulting the Bezier control points to >> calculate the Rectangle2D bounding box. Instead it's pretty straight-forward >> to convert the Bezier control points into the x & y parametric equations. At >> their m

Re: RFR: 8176501: Method Shape.getBounds2D() incorrectly includes Bezier control points in bounding box [v11]

2021-12-16 Thread Jeremy
> This removes code that relied on consulting the Bezier control points to > calculate the Rectangle2D bounding box. Instead it's pretty straight-forward > to convert the Bezier control points into the x & y parametric equations. At > their most complex these equations are cubic polynomials, so

Re: RFR: 6465404: some problems in CellEditor related API docs [v5]

2021-12-16 Thread Tejesh R
On Thu, 16 Dec 2021 10:04:49 GMT, Tejesh R wrote: >>> The object that implements the interface is not necessarily the editor for >>> values. DefaultCellEditor is the perfect example: it's not an editor >>> itself, it's not even a component, all it does is configures a delegate, a >>> JComponen

Re: RFR: 6465404: some problems in CellEditor related API docs [v5]

2021-12-16 Thread Tejesh R
On Thu, 16 Dec 2021 05:18:04 GMT, Sergey Bylokhov wrote: >> Hm… It's not the other way around. `DefaultCellEditor` implements >> `TableCellEditor`; the interface defines the `getTableCellEditorComponent` >> method that returns the _real component_ which will be used as the value >> editor. >>

Re: RFR: 8278828 : java/awt/a11y/AccessibleTextTest.java's createTextArea() just shows instructions on the UI

2021-12-16 Thread Artem Semenov
On Wed, 15 Dec 2021 02:21:35 GMT, lawrence.andrews wrote: > 1) Test scenario was just showing test instruction with JTextArea. So added > the JTextArea as the instruction and method says. > 2) JTextArea is filled with contents so that and an Emoji character making > sure that screen reader ca

Re: [jdk18] RFR: 8278604 SwingSet2 table demo does not have accessible description set for images

2021-12-16 Thread Alexander Zuev
On Wed, 15 Dec 2021 12:43:40 GMT, Artem Semenov wrote: > SwingSet2 demo is often used to check accessibility for different Swing > components and has some shortcomings. The major one is that images within the > table demo do not have accessible description set which makes accessibility > perfo