Re: RFR: 8277463: JFileChooser with Metal L&F doesn't show non-canonical UNC path in - Look in [v2]

2021-12-20 Thread Sergey Bylokhov
On Mon, 20 Dec 2021 09:32:24 GMT, Masanori Yano wrote: >> test/jdk/javax/swing/JFileChooser/8277463/UNCFileChooserTest.java line 105: >> >>> 103: throw new RuntimeException("Enter the directory path to >>> test."); >>> 104: } >>> 105: >>> UIManager.setLookAndFeel("j

Re: RFR: 6465404: some problems in CellEditor related API docs [v5]

2021-12-20 Thread Sergey Bylokhov
On Fri, 17 Dec 2021 19:04:56 GMT, Alexey Ivanov wrote: >>> > The object that implements the interface is not necessarily the editor >>> > for values. DefaultCellEditor is the perfect example: it's not an editor >>> > itself, it's not even a component, all it does is configures a delegate, >>>

[jdk18] Integrated: 8278609: [macos] accessibility frame is misplaced on a secondary monitor on macOS

2021-12-20 Thread Aleksandr Veselov
On Mon, 20 Dec 2021 09:26:31 GMT, Aleksandr Veselov wrote: > Use primary screen instead of window main screen to properly convert mouse > position from screen coordinates to window ones. > > Copy of [jdk/6815](https://github.com/openjdk/jdk/pull/6815) This pull request has now been integrated

Re: [jdk18] RFR: 8278609: [macos] accessibility frame is misplaced on a secondary monitor on macOS

2021-12-20 Thread Alexander Zuev
On Mon, 20 Dec 2021 09:26:31 GMT, Aleksandr Veselov wrote: > Use primary screen instead of window main screen to properly convert mouse > position from screen coordinates to window ones. > > Copy of [jdk/6815](https://github.com/openjdk/jdk/pull/6815) Looks good. - Marked as rev

Integrated: 6462028: MaskFormatter API documentation refers to getDisplayValue

2021-12-20 Thread Tejesh R
On Thu, 25 Nov 2021 09:54:47 GMT, Tejesh R wrote: > MaskFormatter API doesn't have getDisplayValue method, hence removed from > Documentation. This pull request has now been integrated. Changeset: 31fbb872 Author:TejeshR13 Committer: Jayathirth D V URL: https://git.openjdk.java.ne

Re: [jdk18] RFR: 8278609: [macos] accessibility frame is misplaced on a secondary monitor on macOS

2021-12-20 Thread Anton Tarasov
On Mon, 20 Dec 2021 09:26:31 GMT, Aleksandr Veselov wrote: > Use primary screen instead of window main screen to properly convert mouse > position from screen coordinates to window ones. > > Copy of [jdk/6815](https://github.com/openjdk/jdk/pull/6815) @azuev-java please review. -

Re: RFR: 8277463: JFileChooser with Metal L&F doesn't show non-canonical UNC path in - Look in

2021-12-20 Thread Masanori Yano
On Wed, 15 Dec 2021 22:58:39 GMT, Sergey Bylokhov wrote: >> I would like to fix the bug reported in JDK-8277463. >> >> As reporter's investigation, ShellFolder.getNormalizedFile() returns >> incorrect value for non-canonical Windows UNC path. getNormalizedFile() is >> used for symbolic link pa

Re: RFR: 8277463: JFileChooser with Metal L&F doesn't show non-canonical UNC path in - Look in [v2]

2021-12-20 Thread Masanori Yano
On Wed, 15 Dec 2021 03:50:11 GMT, Sergey Bylokhov wrote: >> Masanori Yano has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8277463: JFileChooser with Metal L&F doesn't show non-canonical UNC path >> in - Look in > > test/jdk/javax/swing/

Re: RFR: 8277463: JFileChooser with Metal L&F doesn't show non-canonical UNC path in - Look in [v2]

2021-12-20 Thread Masanori Yano
> I would like to fix the bug reported in JDK-8277463. > > As reporter's investigation, ShellFolder.getNormalizedFile() returns > incorrect value for non-canonical Windows UNC path. getNormalizedFile() is > used for symbolic link path, but Windows environment does not handle symbolic > link. An

Re: [jdk18] RFR: 8278609: accessibility frame is misplaced on a secondary monitor on macOS

2021-12-20 Thread Anton Tarasov
On Mon, 20 Dec 2021 09:26:31 GMT, Aleksandr Veselov wrote: > Use primary screen instead of window main screen to properly convert mouse > position from screen coordinates to window ones. > > Copy of [jdk/6815](https://github.com/openjdk/jdk/pull/6815) Marked as reviewed by ant (Reviewer). --

[jdk18] RFR: 8278609: accessibility frame is misplaced on a secondary monitor on macOS

2021-12-20 Thread Aleksandr Veselov
Use primary screen instead of window main screen to properly convert mouse position from screen coordinates to window ones. Copy of [jdk/6815](https://github.com/openjdk/jdk/pull/6815) - Commit messages: - 8278609: accessibility frame is misplaced on a secondary monitor on macOS C

Re: RFR: 8278609: accessibility frame is misplaced on a secondary monitor on macOS

2021-12-20 Thread Aleksandr Veselov
On Mon, 13 Dec 2021 15:33:48 GMT, Aleksandr Veselov wrote: > Use primary screen instead of window main screen to properly convert mouse > position from screen coordinates to window ones. Changes moved to [jdk18/48](https://github.com/openjdk/jdk18/pull/48), closing - PR: https://

Withdrawn: 8278609: accessibility frame is misplaced on a secondary monitor on macOS

2021-12-20 Thread Aleksandr Veselov
On Mon, 13 Dec 2021 15:33:48 GMT, Aleksandr Veselov wrote: > Use primary screen instead of window main screen to properly convert mouse > position from screen coordinates to window ones. This pull request has been closed without being integrated. - PR: https://git.openjdk.java.ne