Re: RFR: 8280047: Broken link to Swing Connection document from javax.swing package docs [v2]

2022-01-17 Thread Prasanta Sadhukhan
On Mon, 17 Jan 2022 14:55:46 GMT, Alexey Ivanov wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Typo fix > > src/java.desktop/share/classes/javax/swing/package-info.java line 139: > >> 137: * https://do

Re: RFR: 8280047: Broken link to Swing Connection document from javax.swing package docs [v3]

2022-01-17 Thread Prasanta Sadhukhan
> Fixed the broken link with appropriate link to swing document. Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: Fix other links - Changes: - all: https://git.openjdk.java.net/jdk/pull/7104/files - new: https:/

Re: [jdk18] RFR: 8279227: Access Bridge: Wrong frame position and hit test result on HiDPI display [v4]

2022-01-17 Thread Alexander Zuev
On Fri, 14 Jan 2022 17:31:09 GMT, Aleksandr Veselov wrote: >> Perform scaling while converting sizes and coordinates to provide correct >> positions of accessible elements on HiDPI screen and make hit-test work >> properly. It uses FontRenderContext to receive display scale without API >> cha

Re: [jdk18] RFR: 8279227: Access Bridge: Wrong frame position and hit test result on HiDPI display [v4]

2022-01-17 Thread Anton Tarasov
On Fri, 14 Jan 2022 17:34:11 GMT, Aleksandr Veselov wrote: > I've fixed receiving GC at given point and now hit-test and frame bounds seem > to be calculated correctly. But it looks like NVDA does not work correctly > with different DPI on the second display, so it (at least v. 2021.3.1) has t

Re: [jdk18] RFR: 8279227: Access Bridge: Wrong frame position and hit test result on HiDPI display [v4]

2022-01-17 Thread Anton Tarasov
On Fri, 14 Jan 2022 17:31:09 GMT, Aleksandr Veselov wrote: >> Perform scaling while converting sizes and coordinates to provide correct >> positions of accessible elements on HiDPI screen and make hit-test work >> properly. It uses FontRenderContext to receive display scale without API >> cha

Re: RFR: 8280047: Broken link to Swing Connection document from javax.swing package docs [v2]

2022-01-17 Thread Alexey Ivanov
On Mon, 17 Jan 2022 14:32:59 GMT, Prasanta Sadhukhan wrote: >> Fixed the broken link with appropriate link to swing document. > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > Typo fix Marked as reviewed by aivanov (R

Re: RFR: 8280047: Broken link to Swing Connection document from javax.swing package docs [v2]

2022-01-17 Thread Prasanta Sadhukhan
On Mon, 17 Jan 2022 13:31:27 GMT, Kevin Rushforth wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Typo fix > > src/java.desktop/share/classes/javax/swing/package-info.java line 135: > >> 133: * please see:

Re: RFR: 8280047: Broken link to Swing Connection document from javax.swing package docs [v2]

2022-01-17 Thread Kevin Rushforth
On Mon, 17 Jan 2022 14:30:08 GMT, Prasanta Sadhukhan wrote: >> Fixed the broken link with appropriate link to swing document. > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > Typo fix Marked as reviewed by kcr (Autho

Re: RFR: 8280047: Broken link to Swing Connection document from javax.swing package docs [v2]

2022-01-17 Thread Prasanta Sadhukhan
> Fixed the broken link with appropriate link to swing document. Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: Typo fix - Changes: - all: https://git.openjdk.java.net/jdk/pull/7104/files - new: https://git.op

Re: RFR: 8280047: Broken link to Swing Connection document from javax.swing package docs

2022-01-17 Thread Kevin Rushforth
On Mon, 17 Jan 2022 13:33:01 GMT, Kevin Rushforth wrote: > ...you have a typo in the HTML link. I see that the GitHub actions run failed for the same reason. - PR: https://git.openjdk.java.net/jdk/pull/7104

Re: RFR: 8280047: Broken link to Swing Connection document from javax.swing package docs

2022-01-17 Thread Kevin Rushforth
On Mon, 17 Jan 2022 06:25:59 GMT, Prasanta Sadhukhan wrote: > Fixed the broken link with appropriate link to swing document. This looks like a good replacement, but you have a typo in the HTML link. Once fixed, please run `make docs` and check the generated html page. src/java.desktop/share/c

Re: RFR: 8190264: JScrollBar ignores its border when using macOS Mac OS X Aqua look and feel [v13]

2022-01-17 Thread Alexey Ivanov
On Tue, 11 Jan 2022 20:58:05 GMT, Alisen Chung wrote: >> Adjusted the AquaLF scrollbar to account for border inset settings when >> dragging the thumb and clicking on the track. > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: >

Re: RFR: 8275715: D3D pipeline processes multiple PaintEvent at initial drawing [v2]

2022-01-17 Thread Masanori Yano
On Thu, 28 Oct 2021 08:27:44 GMT, Masanori Yano wrote: >> Could you please review the 8275715 bug fixes? >> >> I think D3DScreenUpdateManager posts unnecessary PaintEvent during >> processing PaintEvent. When the validate method is called from >> createGraphics, repaintPeerTarget should not be

Re: RFR: 8280035: Use Class.isInstance instead of Class.isAssignableFrom where applicable

2022-01-17 Thread Erik Gahlin
On Thu, 13 Jan 2022 08:39:04 GMT, Andrey Turbanov wrote: >> Method `Class.isAssignableFrom` is often used in form of: >> >> if (clazz.isAssignableFrom(obj.getClass())) { >> Such condition could be simplified to more shorter and performarnt code >> >> if (clazz.isInstance(obj)) { >>