Re: RFR: 8280468: Crashes in getConfigColormap, getConfigVisualId, XVisualIDFromVisual on Linux

2022-01-23 Thread Maxim Kartashev
On Fri, 21 Jan 2022 17:02:38 GMT, Maxim Kartashev wrote: > These crashes were not reproducible, so the fix is based on a hypothesis that > there are two possible reasons for them: > 1. `makeDefaultConfig()` returning `NULL`. > 2. A race condition when the number of screens changes. > The race sc

Re: RFR: 8278254: Cleanup doclint warnings in java.desktop module [v4]

2022-01-23 Thread Prasanta Sadhukhan
On Fri, 21 Jan 2022 07:43:17 GMT, Sergey Bylokhov wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix > > src/java.desktop/share/classes/javax/swing/filechooser/FileSystemView.java > line 353: > >> 351:

Re: RFR: 8278254: Cleanup doclint warnings in java.desktop module [v5]

2022-01-23 Thread Prasanta Sadhukhan
> The changes done under JDK-8278175 suppress on a per-file basis various > missing comments that would otherwise trigger doclint warnings. Fixed them so > as to remove the doclint:missing warnings. Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since t

RFR: 8280132: Incorrect comparator com.sun.beans.introspect.MethodInfo.MethodOrder

2022-01-23 Thread Sergey Bylokhov
In jdk 9 we started to sort the list of methods for each class for two reasons: 1. We had a number of bugs which state that our JavaBeans randomly does not work, examples: JDK-6807471[1] , JDK-6788525[2], the reason was that the order of methods from Class.getMethods() is not specified. 2. We t

Re: Kindly request your attention for a really annoying visual Java bug on Linux Mint

2022-01-23 Thread Stefan Reich
Hello Alexey, thanks a lot for investigating and submitting the bug. I don't think I can sign up at bugs.openjdk.java.net directly, right? I have also done some further testing, for example on an older version of Peppermint Linux (also on my ThinkPad). Same kind of errors appear. So it doesn't se

Re: RFR: JDK-8280492: Address remaining doclint issues in JDK build

2022-01-23 Thread Lance Andersen
On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote: > Use presumed syntax that will be introduced by JDK-8280488. Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7189

Re: RFR: JDK-8280492: Address remaining doclint issues in JDK build

2022-01-23 Thread Sergey Bylokhov
On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote: > Use presumed syntax that will be introduced by JDK-8280488. Marked as reviewed by serb (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7189