Re: RFR: JDK-6998249: Wrong behavior/Javadoc of JTable.tableChanged(TableModelEvent e)

2022-01-28 Thread Phil Race
On Fri, 28 Jan 2022 20:03:10 GMT, Harshitha Onkar wrote: >> I said most of the doc is changing which is clearly not most of the doc for >> JTable so it means just this method. >> >> To the latter point the doc you are proposing is asserting that it does not >> apply to rows. >> Now since we al

Re: RFR: 8278908: [macOS] Unexpected text normalization on pasting from clipboard

2022-01-28 Thread Alexey Ivanov
On Thu, 16 Dec 2021 15:53:26 GMT, Dmitry Batrak wrote: > The fix just removes the explicit normalization of text obtained from system > clipboard in JDK code, as I've found no > good justification for such a normalization, at least for the latest macOS > version. > The same fix was performed in

Re: RFR: JDK-6998249: Wrong behavior/Javadoc of JTable.tableChanged(TableModelEvent e)

2022-01-28 Thread Harshitha Onkar
On Fri, 28 Jan 2022 21:32:16 GMT, Phil Race wrote: >> Updated JTable's tableChanged() method docs to explicitly mention the >> coordinate system of the rows and columns. > >> I wasn't able to locate the code that does model-to-view coordinate mapping >> for rows from here. > > That's worrying

Re: RFR: JDK-6998249: Wrong behavior/Javadoc of JTable.tableChanged(TableModelEvent e)

2022-01-28 Thread Phil Race
On Thu, 27 Jan 2022 22:11:27 GMT, Harshitha Onkar wrote: > Updated JTable's tableChanged() method docs to explicitly mention the > coordinate system of the rows and columns. > I wasn't able to locate the code that does model-to-view coordinate mapping > for rows from here. That's worrying. S

Re: RFR: 8278254: Cleanup doclint warnings in java.desktop module [v5]

2022-01-28 Thread Alexey Ivanov
On Mon, 24 Jan 2022 06:03:42 GMT, Prasanta Sadhukhan wrote: >> The changes done under JDK-8278175 suppress on a per-file basis various >> missing comments that would otherwise trigger doclint warnings. Fixed them >> so as to remove the doclint:missing warnings. > > Prasanta Sadhukhan has updat

RFR: 8202836 : [macosx] test java/awt/Graphics/TextAAHintsTest.java fails

2022-01-28 Thread lawrence . andrews
1) Removed =yesno that was causing the test to fail with following exception test result: Error. Parse Exception: Arguments to `manual' option not supported: yesno After removing =yesno, test was just passing without user interaction so fixed the following Add the following so that user can user

Re: RFR: JDK-6998249: Wrong behavior/Javadoc of JTable.tableChanged(TableModelEvent e)

2022-01-28 Thread Harshitha Onkar
On Fri, 28 Jan 2022 03:17:42 GMT, Phil Race wrote: >> @prrace Should all instances of "code tags" (entire JTable) changed to >> {@code...} or for the tableChanged method only? >> I was not able to understand the last point clearly. Can you please >> elaborate? > > I said most of the doc is chan

Re: RFR: 8274939: Incorrect size of the pixel storage is used by the robot on macOS

2022-01-28 Thread Sergey Bylokhov
On Fri, 8 Oct 2021 10:23:13 GMT, Sergey Bylokhov wrote: > In JDK 9 the native code for the robot class was reworked to get an access to > the HiDPI quality screenshots. So we allocate the data storage for the HiDPI > quality and then request the best quality from the macOS. > > It works fine i

Re: RFR: 8274939: Incorrect size of the pixel storage is used by the robot on macOS

2022-01-28 Thread Sergey Bylokhov
On Fri, 28 Jan 2022 09:00:25 GMT, Maxim Kartashev wrote: > I just filed [JDK-8280861](https://bugs.openjdk.java.net/browse/JDK-8280861) > for that and the issue with coordinates scaling on Linux. It looks similar to what is done on macOS where two types of coordinates are needed: the user's sp

RFR: 8241192: [macosx] Wrong letter typed after ´ symbol when using Finnish layout

2022-01-28 Thread Prasanta Sadhukhan
If we press " ´ " (on U.S. keyboard layout it is the [+] button just before the [delete] button), and then press "s" , 2 "´" characters are entered in a text field instead of "´s" with "Finish" keyboard layout. This is because, although " ´ " is construed as "complex" char and inserted properly

Re: RFR: 8274939: Incorrect size of the pixel storage is used by the robot on macOS

2022-01-28 Thread Maxim Kartashev
On Fri, 8 Oct 2021 10:23:13 GMT, Sergey Bylokhov wrote: > In JDK 9 the native code for the robot class was reworked to get an access to > the HiDPI quality screenshots. So we allocate the data storage for the HiDPI > quality and then request the best quality from the macOS. > > It works fine i